Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1034256yba; Thu, 16 May 2019 13:06:54 -0700 (PDT) X-Google-Smtp-Source: APXvYqz3bak2yF9liFWYBoCG/Rv5CqNQrUwaX0IX0Cjg3JWlmMM+If8vWIZOvNs0dgsjFiG1kyx1 X-Received: by 2002:a65:5003:: with SMTP id f3mr50754400pgo.336.1558037214526; Thu, 16 May 2019 13:06:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558037214; cv=none; d=google.com; s=arc-20160816; b=DKxy1MQmIy7fjencehuF8x0bP3YXHt0itH4W3y5XNYy2lNjkJ61M3zkJETN/7y01Kr eD6f8hLP7MKRdDLEn5vNwqSIOS121AJShk4bcOXj9Zb2Dtgk8YRS6wFx0ChcRo7p1CTn G5H2lwaMi05MTh07eIkblGMFq0HmXmt1DBlipxeSAQ93as1/QiM2/i949L4C9J6jjAh1 1dec2SuICXS8m3uEY0u80XC6VsXlEt2aIFq5xjYdw3tZ/inmilumy0Ksm1GwyAtd0M4l B90SfHwbvgz8lG4NPp1k3DBs/6a4mDr5pOLbQ0UGj04wq4lVr9o1Ezn77ffZqYdoJ/sc RyCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=qnP8DXdnAI8r0utqzxoUpU/7eSgQlDA+ZQxN0RGd3jc=; b=xcDzu9WPpWOf5vKFCp6gA251hbc/pfH5KyiaJOeSUyv+bSJggGeppw2KEZcFBdQqBK +MqegU2TJju9oO63tGc137Gxrdx8L7Pfz96heHzvUEpyhKMLP3MFyd2OVZKHznPjE1eP MBJQNIhhAznUSG8TIGB9Aa38km1WjuD19HWizkMQNYkcA2z22/aMAgkgTmMCP8fz89a0 aoy/edZr/btARhzyqugSXSbLEL0DfzxpzjsViFrSWNQPpOkVEH0GqmS+cwRqkBJe2osU G9KKemPCcSqnrnt66QkX5V5vNPkfN1Re0q4J74445q7LAoogtYJKoGMVVCHbCZ6gqRY3 CNVg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r84si6843270pfa.10.2019.05.16.13.06.38; Thu, 16 May 2019 13:06:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727340AbfEPRAi (ORCPT + 99 others); Thu, 16 May 2019 13:00:38 -0400 Received: from mx2.suse.de ([195.135.220.15]:44620 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726449AbfEPRAh (ORCPT ); Thu, 16 May 2019 13:00:37 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id B3E93AD0A; Thu, 16 May 2019 17:00:36 +0000 (UTC) Date: Thu, 16 May 2019 19:00:35 +0200 From: Michal =?iso-8859-1?Q?Koutn=FD?= To: Konstantin Khlebnikov Cc: mkoutny@suse.cz, linux-mm@kvack.org, akpm@linux-foundation.org, oleg@redhat.com, linux-kernel@vger.kernel.org Subject: Re: mm: use down_read_killable for locking mmap_sem in access_remote_vm Message-ID: <20190516170034.GO13687@blackbody.suse.cz> References: <20190515083825.GJ13687@blackbody.suse.cz> <11ee83c8-5f0f-0950-a588-037bdcf9084e@yandex-team.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <11ee83c8-5f0f-0950-a588-037bdcf9084e@yandex-team.ru> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 15, 2019 at 11:48:32AM +0300, Konstantin Khlebnikov wrote: > This function ignores any error like reading from unmapped area and > returns only size of successful transfer. It never returned any error codes. This is a point I missed. Hence no need to adjust consumers of __access_remote_vm() (they won't actually handle -EINTR correctly w/out further changes). This beats my original idea with simplicity. Reviewed-by: Michal Koutn? Michal