Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Vineet Gupta <Vineet.Gupta1@synopsys.com>
To:     Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
CC:     "paltsev@snyopsys.com" <paltsev@snyopsys.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
        "linux-snps-arc@lists.infradead.org" 
        <linux-snps-arc@lists.infradead.org>
Subject: Re: [PATCH 4/9] ARC: mm: do_page_fault refactor #3: tidyup vma
 access permission code
Thread-Topic: [PATCH 4/9] ARC: mm: do_page_fault refactor #3: tidyup vma
 access permission code
Thread-Index: AQHVCrVZlKJI28iPlEu8hsRog7Qd0g==
Date:   Thu, 16 May 2019 17:37:51 +0000
Message-ID: <C2D7FE5348E1B147BCA15975FBA2307501A2517B16@us01wembx1.internal.synopsys.com>
References: <1557880176-24964-1-git-send-email-vgupta@synopsys.com>
 <1557880176-24964-5-git-send-email-vgupta@synopsys.com>
 <1558027448.2682.11.camel@synopsys.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 5/16/19 10:24 AM, Eugeniy Paltsev wrote:=0A=
>> +	unsigned int write =3D 0, exec =3D 0, mask;=0A=
> Probably it's better to use 'bool' type for 'write' and 'exec' as we real=
ly use them as a boolean variables.=0A=
=0A=
Right those are semantics, but the generated code for "bool" is not ideal -=
 given=0A=
it is inherently a "char" it is promoted first to an int with an additional=
 EXTB=0A=
which I really dislike.=0A=
Guess it is more of a style thing.=0A=
=0A=
-Vineet=0A=