Date: Sat, 12 Nov 2005 03:13:20 -0800
From: Paul Jackson <pj@sgi.com>
To: Alexander Nyberg <alexn@telia.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: Some debugging patches on top of -mm
Message-Id: <20051112031320.40543ae4.pj@sgi.com>
In-Reply-To: <20050905195001.GA10223@localhost.localdomain>
References: <20050905195001.GA10223@localhost.localdomain>
Organization: SGI
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1686
Lines: 35

Alexander,

This patch, known as page-owner-tracking-leak-detector.patch has
apparently been sitting in Andrew's *-mm for the last two months.

I just noticed it now, when reading mm/page_alloc.c.

I'd like to know if the #ifdef's and CONFIG_PAGE_OWNER specific code
can be removed from page_alloc.c, and put in a header file.  Ideally,
you patch would add just one line to the __alloc_pages() code - a call
to set_page_owner() that either became no code (a static inline empty
function) or a call to your code, if this feature was CONFIG enabled.

The *.c files are where all the logic comes together, and it is vital
to the long term readability of these files that we avoid #ifdef's in
these files.  Any one feature can be ifdef'd in, with seeming little
harm to the readability of the code (especially in the eyes of the
author of that particular bit of ifdef'd code ;).  But imagine what
a deity-awful mess these files would be if we had all been doing that
over the years with our various favorite features.

I am not sure which header file - quite possibly in a new header
file just for this feature (unless others have the good sense to
recommend better.)  Static inline code that is only called from
one place should work fine in a header file, at least technically.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.925.600.0401
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/