Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1158508yba; Thu, 16 May 2019 15:36:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqwrJQffmaRwuS/zQm3xV0a/t4QyZAHJKpL9qIqh8S3KqTLq1yrI6ol7P9aw8jKNd8/iidLj X-Received: by 2002:a17:902:56a:: with SMTP id 97mr14277667plf.20.1558046197744; Thu, 16 May 2019 15:36:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558046197; cv=none; d=google.com; s=arc-20160816; b=V8Qxtm4PDFffMio0jEykQZO43miKH5hDKQ9AdLalWMKwH7ZJm83uNlvXUD1Xq418aq 2ZWK5PnA2VybfBYL/PsnreR8W7hzZkRiryQA6UOUtZRrdqkXiemLQnQj5dZK8SUR7BJd KRvli87T96GaJYdqlbhklGVnsnVV4BWjhRisBg8ejb6IG8SJug22vHTZb/ONsa8+i9Te M0LVR9a2KqAYNa1gsLnUJPSrPuuxiYZdX3zhH/sdg0mFtxqb5hj58S7suztDnKgvjwpV /btNsV1ftd9PHJGXEgtZOq3MBARLNZjhs5doaBRgOGwfudjbbGP4EDgqJpYABsrALvk1 JFvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=RLsybBG6sLbUggVAi7bXCzaTyEG1llzt4l8NvXBkWD0=; b=SfMtHjays9/41vvRUOcATlGSMYop4Bk9b0T5BLvcIaziH8dF44Y0Vp3uKK1SzJMWEx sIxerobIJ3rwnOKY/sVbwz3pjmRwCv0H+TNS/Rju4biUvJN4fJrj/LiwPY6KYWrh7NTz /pTMvodJB9/aE6hkHDBTVBuAOAFH6OTdWppwWrFcgfjbKU1zIq8HO5hdxK1RhGn/btxq SCn67DfO9hPBX9/7Csoq27Q5bd3J+SrF3GRYc86mYV3UOe6iCYOqc0W0TRF2z0uJDBLG GQSZ5j/V4nb46cI9pY905xm+AZh5Y6gnXvvjXD5mOqozZ6x2iTmGIsv/jk3tQ5ZD3ljJ a6rA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=kQKmujFh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1si6165627pgx.176.2019.05.16.15.36.22; Thu, 16 May 2019 15:36:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=kQKmujFh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728689AbfEPVdr (ORCPT + 99 others); Thu, 16 May 2019 17:33:47 -0400 Received: from mail-ot1-f67.google.com ([209.85.210.67]:43782 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727108AbfEPVdq (ORCPT ); Thu, 16 May 2019 17:33:46 -0400 Received: by mail-ot1-f67.google.com with SMTP id i8so4819525oth.10 for ; Thu, 16 May 2019 14:33:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=RLsybBG6sLbUggVAi7bXCzaTyEG1llzt4l8NvXBkWD0=; b=kQKmujFhtAo72AB0snHcaDCif3+naULFQoilmAIC6cMGnoXGg8ewZ21JUB4lOVYrqn ziRwjT6PsQTzua7xc3imb9UZ4NgeYhIEclPb/biFpQyoDbDFAidppg+ZW3qHPFUXx0ze 5IfccJ4XP9KqRDLcfeOaEywCQOBdZZYgC0GDrZWN+2m3m3f856Op6UdFGfgCGpOJ6QAl XXlLDRMeCUo3PgBP/hzld3xTl1ISadWuhZWoCvRqCNp1Qkc85SGbOHdmYMnoRrFT0++7 rMqZUYKbrckThZrps3MkJEXsX5U4dRBUE5FB9eYeCVbeOysRMEsHfr2+3ePDXRIYTIjy zJoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=RLsybBG6sLbUggVAi7bXCzaTyEG1llzt4l8NvXBkWD0=; b=gLeE93IzZHs5M92UagAJiw8DXP9WxfjfQApMVqrxSWZT54dA17UPtYOfO5bK2JRMAa T4LYS4SvndmqpQRZ9aZnf/oI4kknLofG405UL1kpq748t1QjBqdpjlIzQTPqXOhzj5sp JN5sugvL72wlin78sE+b0l0B7V6U9We+JzW2Qp3zLv/7g063PZaoVzqgcRgf/uXjgM2t Aw+p2+XbN5u2UVHYwFDYlm59QEfKGdA1tze22goT/xknb6pAdPHuwt9mSPXjG5HtpWUv 13DLUCCcmmQCqfDdPrdPoB8vrOu43urBsww0mNeu5RE6M0NvZkL9j4F8cl/CqyQ3OHbv LMog== X-Gm-Message-State: APjAAAVlLEBSH0lECjQxss1mBsEAJgf6rnzWGTHpuW0c/NKZvTkF0Coc cTf/LvY9aaXpakAPIfoPgHA= X-Received: by 2002:a9d:7154:: with SMTP id y20mr7131771otj.369.1558042425977; Thu, 16 May 2019 14:33:45 -0700 (PDT) Received: from madhuleo ([2605:6000:1023:606d:10b5:228a:3958:f004]) by smtp.gmail.com with ESMTPSA id 69sm2282544oty.46.2019.05.16.14.33.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 16 May 2019 14:33:44 -0700 (PDT) From: Madhumitha Prabakaran To: eric@anholt.net, stefan.wahren@i2se.com, gregkh@linuxfoundation.org, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Cc: Madhumitha Prabakaran Subject: [PATCH v2] Staging: bcm2835-camera: Prefer kernel types Date: Thu, 16 May 2019 16:33:40 -0500 Message-Id: <20190516213340.9311-1-madhumithabiw@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the warning issued by checkpatch Prefer kernel type 'u32' over 'uint32_t'. Along with that include a blank line after a declaration to maintain Linux kernel coding style. Signed-off-by: Madhumitha Prabakaran --- Changes in v2: - Modified subject line - Included one more change in control.c --- drivers/staging/vc04_services/bcm2835-camera/controls.c | 3 ++- drivers/staging/vc04_services/bcm2835-camera/mmal-msg.h | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-camera/controls.c b/drivers/staging/vc04_services/bcm2835-camera/controls.c index 74410fedffad..5ad957e23895 100644 --- a/drivers/staging/vc04_services/bcm2835-camera/controls.c +++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c @@ -52,7 +52,8 @@ static const s64 ev_bias_qmenu[] = { static const s64 iso_qmenu[] = { 0, 100000, 200000, 400000, 800000, }; -static const uint32_t iso_values[] = { + +static const u32 iso_values[] = { 0, 100, 200, 400, 800, }; diff --git a/drivers/staging/vc04_services/bcm2835-camera/mmal-msg.h b/drivers/staging/vc04_services/bcm2835-camera/mmal-msg.h index d1c57edbe2b8..90793c9f9a0f 100644 --- a/drivers/staging/vc04_services/bcm2835-camera/mmal-msg.h +++ b/drivers/staging/vc04_services/bcm2835-camera/mmal-msg.h @@ -309,7 +309,7 @@ struct mmal_msg_port_parameter_set { u32 port_handle; /* port */ u32 id; /* Parameter ID */ u32 size; /* Parameter size */ - uint32_t value[MMAL_WORKER_PORT_PARAMETER_SPACE]; + u32 value[MMAL_WORKER_PORT_PARAMETER_SPACE]; }; struct mmal_msg_port_parameter_set_reply { @@ -331,7 +331,7 @@ struct mmal_msg_port_parameter_get_reply { u32 status; /* Status of mmal_port_parameter_get call */ u32 id; /* Parameter ID */ u32 size; /* Parameter size */ - uint32_t value[MMAL_WORKER_PORT_PARAMETER_SPACE]; + u32 value[MMAL_WORKER_PORT_PARAMETER_SPACE]; }; /* event messages */ -- 2.17.1