Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1200690yba; Thu, 16 May 2019 16:31:47 -0700 (PDT) X-Google-Smtp-Source: APXvYqy1qTh1qnO+mmNXzpM0378n07JgTplJp8zrLngfDCa0HVmCo0+CYlS3j9bP7K3wWwJbHnoB X-Received: by 2002:a62:5487:: with SMTP id i129mr57211884pfb.68.1558049507614; Thu, 16 May 2019 16:31:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558049507; cv=none; d=google.com; s=arc-20160816; b=CyoN8uR+L8t0bVTtTg6D+QzI/L6cbRhihURvBE3W811AJRY4KuoGKNVV673x7Hk8RT Ozcg7obx/N3VSGtnR8fs84igGb+tKIiCyDJ7cjj4QW7JboGu+60sZE3cMHqW+6MEV2Ao 1RO+W1FCib+lb9vIswIuAE/9GlmoTOWG4lAUyiTpCj/Wb4P7Mpjy3cSNa9/PQjIE1XVF v9mr9gGKcJKPCL2GjW5WgVw/J+aCvGelCmjDd0dFfabsmVxBIbnEeI9yo5xqmO2C4KDd vz2Z7p/4U4himi8w1fe6jaTQ5y3wHNAKkNxlb1T1NhBeI3ffG417vJ7pPQaP7k0OPoQq MPEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:from:subject:mime-version :message-id:date:dkim-signature; bh=bCifeYOTD3ZRMR+f0DJzC8Jsulb5gaAzagPHZLEhx8E=; b=PyYXSEoCZBtc8PWwuPezJY7RPHeTxgqxcbUX9e0eA8UfOJa7dqY3sTgUFrcfqLXmZI bop5UUG8xSIBGpH4MrYMnb8XFALQjmfGgiI8xbf2jGMItS8z21N4bij5xOnMJUJFdAcR lp2y2b3ToOMyT2cXuyuE1GpqsExXj8b/lNxT1nYpkEb/pbeAGsRQUNTz4Z38j2LLjvox ZmOVwlLgeGk6jAk96k9yifG9ccfDMeP0u0usWzfxzQSEuK+opMUkVLv4Wd0/FSlhRzL9 SCakxXmY4CTaSmLpw4U51lk1UenvUkZAqPNtWRuOqXI4D5LHL/fvvOM1ahRB+R+aONzY X8hA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b="eB3u/4N9"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a7si6098129pgw.133.2019.05.16.16.31.31; Thu, 16 May 2019 16:31:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b="eB3u/4N9"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728791AbfEPVm2 (ORCPT + 99 others); Thu, 16 May 2019 17:42:28 -0400 Received: from mail-oi1-f201.google.com ([209.85.167.201]:55371 "EHLO mail-oi1-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726732AbfEPVm2 (ORCPT ); Thu, 16 May 2019 17:42:28 -0400 Received: by mail-oi1-f201.google.com with SMTP id c64so2028895oia.22 for ; Thu, 16 May 2019 14:42:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=bCifeYOTD3ZRMR+f0DJzC8Jsulb5gaAzagPHZLEhx8E=; b=eB3u/4N9Lqf1dpOkY9UM43yqpeZDopx8/soQCcOB2zamnS3shAPt6eJYcUjtwZ68aN 54eUKlps4CZWJTRsXL5V2YpQgv3Ck8tGgZQ8VLWpucd6LkJHBsNaIqOw9gAdbwMA7old W0P0pDzR/Nmr+Ivj0q5UG/63CCRxK+iwccajCg4qF8mOs+Qvo8wrikc+rDwnPQ7PdNmY sspwXzouTux0Y/5Bg0xxiy5L0ebt8zvxEx4O9M7FKN1+sHpXbRg0I7d0+fRrjZAWGrc3 DyXwJmdvqYDva/ZbQUHx1aTKWkgX+/wLP2keuESnXg8vHpK7Iswkjlpks48QPQoNjWg9 9sWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=bCifeYOTD3ZRMR+f0DJzC8Jsulb5gaAzagPHZLEhx8E=; b=KBAZtV78T3h9Hl5c3fmxFXwDusHi/x3W6/M/MPbSwJ8a3rrmKzk37J1QN5uz+bpLQL j3Ckakb8oDuIiQfG4ydx7C3QCkuxonKtMp7mF5xfMioXkNNZrssdQFOJcN+SRHoaHeE4 xLPvQyZufqIHBa5iyl1lyiVStoRNPjtM7sA5Q0omDBTTDFXMe+i330BO6GaN9lzkJ1l/ feu7apgviVzryFb6DUN/lpPry6thugzmjWOAqbDGpx7vpJ+xgK1v16HJlM5D731DnVjt 470fVRu1kWhN/AeDS+mxMK7qBJvsLbIRItiOYGd403TFCKVKoR65cdHzr7jCIfW6EpTO p9BQ== X-Gm-Message-State: APjAAAVPVefcCs9RoTK4P4cK90qnnUsUH1cgmg7qbLbwAXVQMcGxB+G8 CXhBaxeh2csrVnIjDDKYG43tvaFgtQ== X-Received: by 2002:a9d:7347:: with SMTP id l7mr511806otk.183.1558042947824; Thu, 16 May 2019 14:42:27 -0700 (PDT) Date: Thu, 16 May 2019 14:42:07 -0700 Message-Id: <20190516214209.139726-1-kunyi@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.21.0.1020.gf2820cf01a-goog Subject: [PATCH 0/2] Fix LED GPIO trigger behavior From: Kun Yi To: linux-leds@vger.kernel.org Cc: Kun Yi , jacek.anaszewski@gmail.com, pavel@ucw.cz, dmurphy@ti.com, u.kleine-koenig@pengutronix.de, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org *** BLURB HERE *** Hello there, I recently tested ledtrig-gpio on an embedded controller and one of the issues I had involve not requesting the user input pin as GPIO. In many embedded systems, a pin could be muxed as several functions, and requesting the pin as GPIO is necessary to let pinmux select the pin as a GPIO instead of, say an I2C pin. I'd like to learn whether it is appropriate to assume user of ledtrig-gpio really intends to use GPIOs and not some weird pins that are used as other functions. Kun Yi (2): ledtrig-gpio: Request user input pin as GPIO ledtrig-gpio: 0 is a valid GPIO number drivers/leds/trigger/ledtrig-gpio.c | 35 ++++++++++++++++++++--------- 1 file changed, 24 insertions(+), 11 deletions(-) -- 2.21.0.1020.gf2820cf01a-goog