Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH net 3/4] vhost: vsock: add weight support
To:     Stefan Hajnoczi <stefanha@redhat.com>
Cc:     mst@redhat.com, virtualization@lists.linux-foundation.org,
        kvm@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, pbonzini@redhat.com
References: <1557992862-27320-1-git-send-email-jasowang@redhat.com>
 <1557992862-27320-4-git-send-email-jasowang@redhat.com>
 <20190516093352.GQ29507@stefanha-x1.localdomain>
From:   Jason Wang <jasowang@redhat.com>
Message-ID: <70c24182-9238-1a69-8e35-53c98b957bc7@redhat.com>
Date:   Fri, 17 May 2019 09:05:30 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <20190516093352.GQ29507@stefanha-x1.localdomain>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2019/5/16 下午5:33, Stefan Hajnoczi wrote:
> On Thu, May 16, 2019 at 03:47:41AM -0400, Jason Wang wrote:
>> @@ -183,7 +184,8 @@ static struct vhost_vsock *vhost_vsock_get(u32 guest_cid)
>>   		virtio_transport_deliver_tap_pkt(pkt);
>>   
>>   		virtio_transport_free_pkt(pkt);
>> -	}
>> +		total_len += pkt->len;
> Please increment total_len before virtio_transport_free_pkt(pkt) to
> avoid use-after-free.


Right, let me fix this.

Thanks