Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 16 May 2019 20:07:08 -0700 (PDT)
Subject:     Re: [GIT PULL] RISC-V Patches for the 5.2 Merge Window, Part 1 v2
In-Reply-To: <CAHk-=wiHtaVsbK4dZ79_h0R307Qv-Fdgdkp3SZ+F+QvzHHGrOQ@mail.gmail.com>
CC:     linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
From:   Palmer Dabbelt <palmer@sifive.com>
To:     Linus Torvalds <torvalds@linux-foundation.org>
Message-ID: <mhng-dd3bf038-f2d1-4318-af23-018200dd31af@palmer-mbp2014>
Mime-Version: 1.0 (MHng)
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 16 May 2019 19:17:17 PDT (-0700), Linus Torvalds wrote:
> On Thu, May 16, 2019 at 5:27 PM Palmer Dabbelt <palmer@sifive.com> wrote:
>>
>>
>>   git://git.kernel.org/pub/scm/linux/kernel/git/palmer/riscv-linux.git tags/riscv-for-linus-5.2-mw1
>
> Oh no no no.
>
> You're creating a binary file from your build or something like that:
>
>>  modules.builtin.modinfo                            | Bin 0 -> 46064 bytes
>
> which is completely unacceptable.
>
> I have no idea what you're doing, but this kind of "random garbage in
> git commits" is not going to fly. And the fact that you're adding
> random files really means that you are doing something *horribly*
> wrong.

Sorry, I have no idea how I missed that.  It looks like I managed to screw
something up while trying to fix up that patch, but I'm not really sure what I
did.  I'll try to figure out how to not screw it up next time.

Thanks for catching this!