Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1417849yba; Thu, 16 May 2019 21:42:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqz3Fi8CsZ/Ng1N+KH5iEUzchq6SXXlJ1K91m4LRAHu1rWzLcMk4ciRs5RdkLj4uwhv4rgtZ X-Received: by 2002:a62:4d03:: with SMTP id a3mr59992489pfb.2.1558068124346; Thu, 16 May 2019 21:42:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558068124; cv=none; d=google.com; s=arc-20160816; b=U7W1aklZg0sAyFRFPACu5BfqauTuYKqpmAUS/3BZs8QbVzjxzewS9NdGHQ7BAj7PIo +gF4JkOU1teJIjoBnaoE74/s7kKOLaDNVXe5HJ2iZaI2TKviZUqbAd2qkZWySa3VAOGO SP8CcqnmJqRA6qFDHYQKJrC9tDE5GUPf3nG6SDiwb12ZjP8kjV88rR2l7BVDcZahlNVi bSwe/AtfYBZbK6rXAh0eKdJ4pOnKEapdNpuDyAlokd2BazMlV+ffYqD8CkSkWYHX8/W3 EgDgsPondygLuyIphl5BuankozEgMLYBhCXEYlM1BfeTIWhhnJxMacSVRmu/+LtChq3q dfLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=4HJiSDZ6NVpZlfpbAIE9JY9i5H7mtH87panNL0CH9Zw=; b=R36FbBsC2OLFzPzX9VA9ZPu6ZfVKweADBbOZR7pHkm0R+BHshBuM7/WtiotAiVAK86 ips9KthQ3k5PPmL8ppVjA+TR1UG+Qvqz9gRxMR2QIlXU1Ow0vBRnTu/mloeDlqvARQEo cZUam2CbJEq0b5lpaRkCgKimKDrB+WmpvR0YXpUFCQS+mTDlkkwikUvnkSTljCVcp2u4 qmmh533t7CM10I86SlZQ2jKfc0PiljqWFGS2ZzUfItV3saJ8Ys6tzEbID0nbdl0XvxPu LG/W0aySga8MN0rIiOx5rf7hp+TxkHozB+9PfmMUBvnj1T43s8waefJQ+nOeb4eA2Yjl A+gA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=joMy3Udn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 18si7226295pfo.13.2019.05.16.21.41.48; Thu, 16 May 2019 21:42:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=joMy3Udn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727386AbfEQC4a (ORCPT + 99 others); Thu, 16 May 2019 22:56:30 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:39282 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727108AbfEQC4a (ORCPT ); Thu, 16 May 2019 22:56:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=4HJiSDZ6NVpZlfpbAIE9JY9i5H7mtH87panNL0CH9Zw=; b=joMy3UdnsiCdt1hoeX13+Vv6h LAb/YlelQoJg7XbXDsVeak+AK5oiHXrplz9aGnkr5ikxMvftHA1d864zkhZUa7INRGljf3cop5faP 6eLUOQWenVHaZqNYk0FpGvaRzfthCKI//0n63yuNpBVSwQwrM04ognUMtqpwrowWlHP+EzWZwHDQt VYLFo+QzkJp2hyaqrNyEOSkbuF0RdzAkrqLZgtTOJ4MZDZ6aoUA2pHNk19c5b4bJGIndt+0aPROMw uUW5VNR1jtv2m7Vn1ceu8dz9MH/ntT9SeaaiPZaWC+wuizEVbbi/1JlJe5AbV4fOkY5Uv5mVOejYj O/LWOHXmw==; Received: from willy by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1hRT2q-000080-Sj; Fri, 17 May 2019 02:56:28 +0000 Date: Thu, 16 May 2019 19:56:28 -0700 From: Matthew Wilcox To: sunqiuyang Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, yuchao0@huawei.com, miaoxie@huawei.com, fangwei1@huawei.com, stummala@codeaurora.org Subject: Re: [PATCH v2 1/1] f2fs: ioctl for removing a range from F2FS Message-ID: <20190517025628.GF31704@bombadil.infradead.org> References: <20190517021647.43083-1-sunqiuyang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190517021647.43083-1-sunqiuyang@huawei.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 17, 2019 at 10:16:47AM +0800, sunqiuyang wrote: > +++ b/fs/f2fs/f2fs.h > @@ -423,6 +423,8 @@ static inline bool __has_cursum_space(struct f2fs_journal *journal, > #define F2FS_IOC_SET_PIN_FILE _IOW(F2FS_IOCTL_MAGIC, 13, __u32) > #define F2FS_IOC_GET_PIN_FILE _IOR(F2FS_IOCTL_MAGIC, 14, __u32) > #define F2FS_IOC_PRECACHE_EXTENTS _IO(F2FS_IOCTL_MAGIC, 15) > +#define F2FS_IOC_SHRINK_RESIZE _IOW(F2FS_IOCTL_MAGIC, 16, \ > + struct f2fs_resize_param) Why not match ext4? fs/ext4/ext4.h:#define EXT4_IOC_RESIZE_FS _IOW('f', 16, __u64)