Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1487006yba; Thu, 16 May 2019 23:21:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqxJD531J9X9+2/rRRwT4Igz1cpKdS95nkWO1lpDeHYXt4dFHP7hsHHOFrwesR1lNXlS7ktx X-Received: by 2002:a63:2d6:: with SMTP id 205mr54553801pgc.114.1558074063506; Thu, 16 May 2019 23:21:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558074063; cv=none; d=google.com; s=arc-20160816; b=rXlozexgNmTeU6qD2bdnK7JfzY+At5WDp2oZwskhqe4h7qX4MW6fgJ9qvG0kIh8BaT cUyokVoJ3SWcWRdI12lScrj42Ix51gztg7XVwf/fgFwqLE3xnAa90AX2teweQwUoLj2s vQ/fusR2szLXE7sJXiGjkGkRk3Qprn3lXOAM1eNASSh4BwO7rHR/b5zd/V7+NmGf1oAP /1Qkjt1EY7OGl8/+S+drZhpBOWhpTXLxWql4d+ZMuyzMmpfl2TSRw7xE31WlNO9evOVD WqfWtuCltGrVp0+lgPITG6Vk5+4sT0NnMyZyyAu8LWN7XMuXYHyJIgpiKfHUIPDTr3Qf 5i2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject; bh=XZUN1rSQFoJQRTlk7qizj3g35k1ro3ZlvPQUs7PXq7Y=; b=01XMaTqMmG7el/4oyKV5yhucBzCALMhZtp4ysJVR9YeaSLCnuxmINjCLWGn3hcbHoQ 5+geCQYpxwn5OkdIy7d0PCdFxBCKCLI3LnwtlmZx1GzdUFPM+85+xvd2VoApwiWRyrYV wypgrIrIfiz3GJ+67K6SIW8zJu15Ugb/oIRElWPCLaTR6KYA931C+yVj5ccNSWki3QLI xCYZ0DTz2JeBjjTAaeaMZmG5gHGdOETvhqJXxiuAvDcv5vkyd2D2XlYHZ3gEKdSE0vOI ZfruijppggBcNr9SbauS61TM/jnHpKUSISo4Hm3zHYjLsj470SBm9gJp1MhXa1ePeW7z Rf+A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v10si7349351pgr.422.2019.05.16.23.20.48; Thu, 16 May 2019 23:21:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727594AbfEQEsp (ORCPT + 99 others); Fri, 17 May 2019 00:48:45 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:38515 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725929AbfEQEsp (ORCPT ); Fri, 17 May 2019 00:48:45 -0400 Received: by mail-wm1-f68.google.com with SMTP id t5so4039877wmh.3; Thu, 16 May 2019 21:48:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=XZUN1rSQFoJQRTlk7qizj3g35k1ro3ZlvPQUs7PXq7Y=; b=pP2QeoXeOy8xx2ayam6uA8wkuZa55P6em7OfhwNznGVSMyXzA4VYNM6TunUUHjecjb c7vz7lKFZsioQrR3/tzMgzLQIZbIBwD8DgmJ3ZN8wLZ+T8HFU82IFh2LqzOJsU2rJnDK D8gf4em2B1e2jGlInvV/z+NVZV2SIjF1QhDQ/Lm2JWLmdPyemSh047Y+j/jM/Igl1tPV bfbdPyDK7rHASwg6/QyNnYA2ea4IFUFEA+MTh1h1J+G7z0VIkPaz3k9ZM7Q67Gk+VKgT 7r1O6goVYRX8iiPqgW+KUA5eJpBDTQnNUxgxFgjrvNz1OIQZodsEDquG2Er/zm6E5+jp O1Lg== X-Gm-Message-State: APjAAAUk5Nj920TUZ7RydmFWeR4Hu19LDkuODy8gOBr4G+LbGy/nOydD ikgWwhgeYQHB15kZLIVntz0= X-Received: by 2002:a1c:b756:: with SMTP id h83mr564817wmf.64.1558068522865; Thu, 16 May 2019 21:48:42 -0700 (PDT) Received: from ?IPv6:2a0b:e7c0:0:107::49? ([2a0b:e7c0:0:107::49]) by smtp.gmail.com with ESMTPSA id o6sm12612149wrh.55.2019.05.16.21.48.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 May 2019 21:48:41 -0700 (PDT) Subject: Re: [PATCH] memcg: make it work on sparse non-0-node systems To: Michal Hocko , Vladimir Davydov Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Johannes Weiner , cgroups@vger.kernel.org, Raghavendra K T References: <359d98e6-044a-7686-8522-bdd2489e9456@suse.cz> <20190429105939.11962-1-jslaby@suse.cz> <20190509122526.ck25wscwanooxa3t@esperanza> <20190516135923.GV16651@dhcp22.suse.cz> From: Jiri Slaby Openpgp: preference=signencrypt Autocrypt: addr=jslaby@suse.cz; prefer-encrypt=mutual; keydata= mQINBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABtBtKaXJpIFNsYWJ5 IDxqc2xhYnlAc3VzZS5jej6JAjgEEwECACIFAk6S6NgCGwMGCwkIBwMCBhUIAgkKCwQWAgMB Ah4BAheAAAoJEL0lsQQGtHBJgDsP/j9wh0vzWXsOPO3rDpHjeC3BT5DKwjVN/KtP7uZttlkB duReCYMTZGzSrmK27QhCflZ7Tw0Naq4FtmQSH8dkqVFugirhlCOGSnDYiZAAubjTrNLTqf7e 5poQxE8mmniH/Asg4KufD9bpxSIi7gYIzaY3hqvYbVF1vYwaMTujojlixvesf0AFlE4x8WKs wpk43fmo0ZLcwObTnC3Hl1JBsPujCVY8t4E7zmLm7kOB+8EHaHiRZ4fFDWweuTzRDIJtVmrH LWvRDAYg+IH3SoxtdJe28xD9KoJw4jOX1URuzIU6dklQAnsKVqxz/rpp1+UVV6Ky6OBEFuoR 613qxHCFuPbkRdpKmHyE0UzmniJgMif3v0zm/+1A/VIxpyN74cgwxjhxhj/XZWN/LnFuER1W zTHcwaQNjq/I62AiPec5KgxtDeV+VllpKmFOtJ194nm9QM9oDSRBMzrG/2AY/6GgOdZ0+qe+ 4BpXyt8TmqkWHIsVpE7I5zVDgKE/YTyhDuqYUaWMoI19bUlBBUQfdgdgSKRMJX4vE72dl8BZ +/ONKWECTQ0hYntShkmdczcUEsWjtIwZvFOqgGDbev46skyakWyod6vSbOJtEHmEq04NegUD al3W7Y/FKSO8NqcfrsRNFWHZ3bZ2Q5X0tR6fc6gnZkNEtOm5fcWLY+NVz4HLaKrJuQINBE6S 54YBEADPnA1iy/lr3PXC4QNjl2f4DJruzW2Co37YdVMjrgXeXpiDvneEXxTNNlxUyLeDMcIQ K8obCkEHAOIkDZXZG8nr4mKzyloy040V0+XA9paVs6/ice5l+yJ1eSTs9UKvj/pyVmCAY1Co SNN7sfPaefAmIpduGacp9heXF+1Pop2PJSSAcCzwZ3PWdAJ/w1Z1Dg/tMCHGFZ2QCg4iFzg5 Bqk4N34WcG24vigIbRzxTNnxsNlU1H+tiB81fngUp2pszzgXNV7CWCkaNxRzXi7kvH+MFHu2 1m/TuujzxSv0ZHqjV+mpJBQX/VX62da0xCgMidrqn9RCNaJWJxDZOPtNCAWvgWrxkPFFvXRl t52z637jleVFL257EkMI+u6UnawUKopa+Tf+R/c+1Qg0NHYbiTbbw0pU39olBQaoJN7JpZ99 T1GIlT6zD9FeI2tIvarTv0wdNa0308l00bas+d6juXRrGIpYiTuWlJofLMFaaLYCuP+e4d8x rGlzvTxoJ5wHanilSE2hUy2NSEoPj7W+CqJYojo6wTJkFEiVbZFFzKwjAnrjwxh6O9/V3O+Z XB5RrjN8hAf/4bSo8qa2y3i39cuMT8k3nhec4P9M7UWTSmYnIBJsclDQRx5wSh0Mc9Y/psx9 B42WbV4xrtiiydfBtO6tH6c9mT5Ng+d1sN/VTSPyfQARAQABiQIfBBgBAgAJBQJOkueGAhsM AAoJEL0lsQQGtHBJN7UQAIDvgxaW8iGuEZZ36XFtewH56WYvVUefs6+Pep9ox/9ZXcETv0vk DUgPKnQAajG/ViOATWqADYHINAEuNvTKtLWmlipAI5JBgE+5g9UOT4i69OmP/is3a/dHlFZ3 qjNk1EEGyvioeycJhla0RjakKw5PoETbypxsBTXk5EyrSdD/I2Hez9YGW/RcI/WC8Y4Z/7FS ITZhASwaCOzy/vX2yC6iTx4AMFt+a6Z6uH/xGE8pG5NbGtd02r+m7SfuEDoG3Hs1iMGecPyV XxCVvSV6dwRQFc0UOZ1a6ywwCWfGOYqFnJvfSbUiCMV8bfRSWhnNQYLIuSv/nckyi8CzCYIg c21cfBvnwiSfWLZTTj1oWyj5a0PPgGOdgGoIvVjYXul3yXYeYOqbYjiC5t99JpEeIFupxIGV ciMk6t3pDrq7n7Vi/faqT+c4vnjazJi0UMfYnnAzYBa9+NkfW0w5W9Uy7kW/v7SffH/2yFiK 9HKkJqkN9xYEYaxtfl5pelF8idoxMZpTvCZY7jhnl2IemZCBMs6s338wS12Qro5WEAxV6cjD VSdmcD5l9plhKGLmgVNCTe8DPv81oDn9s0cIRLg9wNnDtj8aIiH8lBHwfUkpn32iv0uMV6Ae sLxhDWfOR4N+wu1gzXWgLel4drkCJcuYK5IL1qaZDcuGR8RPo3jbFO7Y Message-ID: <68075828-8fd7-adbb-c1d9-5eb39fbf18cb@suse.cz> Date: Fri, 17 May 2019 06:48:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190516135923.GV16651@dhcp22.suse.cz> Content-Type: text/plain; charset=iso-8859-2 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16. 05. 19, 15:59, Michal Hocko wrote: >> However, I tend to agree with Michal that (ab)using node[0].memcg_lrus >> to check if a list_lru is memcg aware looks confusing. I guess we could >> simply add a bool flag to list_lru instead. Something like this, may be: > > Yes, this makes much more sense to me! I am not sure if I should send a patch with this solution or Vladimir will (given he is an author and has a diff already)? thanks, -- js suse labs