Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1617917yba; Fri, 17 May 2019 02:17:54 -0700 (PDT) X-Google-Smtp-Source: APXvYqx4lMuV5cHRrL2MN5MSD/kDmu3KLrPyBaGdVrghs50YiNhSDbt/b9c7ZR//bjiVe+NO7mnO X-Received: by 2002:a63:5c5f:: with SMTP id n31mr56195780pgm.325.1558084674883; Fri, 17 May 2019 02:17:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558084674; cv=none; d=google.com; s=arc-20160816; b=Dm3nm3JliLnuvh/5xasgysaBM+4Hkz2drCmTZFyaijgAs7XdbNHPy1nJ71OUHj3H/j rIp3atR5ouPZO5DAQLpr0OPMMahqkpR0CHy3akgZhH/brgrSIhOHPMpnTVo5f1MVz8uK PZ04QoWpZtY20TitvYmJeKl30P2s2zuPkaJqERW1hPdI7v4ZJ2nuRdq0YgHUh2WIRil6 GU6Wfd0+oXJnoW0Ne5+H3W5Lcjq6fGas/7exIzu1v0oZnCJoSYbZAjnmtHtGWR7MsigE 4dVBmRZuGucYQMz8q4W+DuGH1YbboupToduLxfVr3nZGzxkeLszUynrQZNqq5aMgKb5B D27A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=HSbPI4eEan//6xudJw1F2L8+pF1ioH0CaCIeDrFnWvo=; b=hhvicetBpi4LEC5DwEnNgzFxUt5TeSI2pDgttlO0fbWYc4fhopdfsVxvgdZW8Z0j/r hQM6G6PvwtBWDtVIfx+zoDMnLJ0vC3sijQ1lZYH4bKkDMUoNUd8wfp+hYyVcWcoMfgae 73lE7h3MftdDP9IQDysaLrsQznJMxN8zKgmDPZnNmL8268O6DSibKY5LoAYR6SkN/83U zENdo/+2fR/0/H/eu8ZSdffSCnrIMHa/4rIJ88ZZAQJNQEVV00G0IRXhprKMINF5Q8+x C7TXASwFzeWg4WIbwqtf+ZlQLUyv+xUiyYgrGOg/gf6dDXi0Qr0AAD674X/613kTp4n9 Rzmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=AnTZv7Gd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l27si7308660pgm.172.2019.05.17.02.17.39; Fri, 17 May 2019 02:17:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=AnTZv7Gd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728318AbfEQHb4 (ORCPT + 99 others); Fri, 17 May 2019 03:31:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:43968 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727361AbfEQHb4 (ORCPT ); Fri, 17 May 2019 03:31:56 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 16BD1206A3; Fri, 17 May 2019 07:31:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558078315; bh=W80f0Osmfp2T/2G+HffeiwRgi9eEG28g8hfA/rYHfV4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AnTZv7Gdtfl8lB37+XTgoUosol4ItZo2FUfZvDbTGqk5YeTBuIkBW8dUAceharY+n fqfW/TGAG14Qm9b4DL7/k7AMS4IbfG/Ycqovq0BgJr5RdLr1vNk7P2ckTPLTOgQWXj 0M0P1EtYNk6hUfSEEAiXPyrusp6rBGFtqBSvRAZk= Date: Fri, 17 May 2019 09:31:53 +0200 From: Greg Kroah-Hartman To: Quentin Deslandes Cc: "kernel-janitors@vger.kernel.org" , "devel@driverdev.osuosl.org" , Mukesh Ojha , "linux-kernel@vger.kernel.org" , Forest Bond , Ojaswin Mujoo Subject: Re: [PATCH v2] staging: vt6656: returns error code on vnt_int_start_interrupt fail Message-ID: <20190517073153.GA4776@kroah.com> References: <20190516093046.1400-1-quentin.deslandes@itdev.co.uk> <20190516115653.15120-1-quentin.deslandes@itdev.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190516115653.15120-1-quentin.deslandes@itdev.co.uk> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 16, 2019 at 11:57:15AM +0000, Quentin Deslandes wrote: > Returns error code from 'vnt_int_start_interrupt()' so the device's private > buffers will be correctly freed and 'struct ieee80211_hw' start function > will return an error code. > > Signed-off-by: Quentin Deslandes > --- > drivers/staging/vt6656/int.c | 4 +++- > drivers/staging/vt6656/int.h | 2 +- > drivers/staging/vt6656/main_usb.c | 12 +++++++++--- > 3 files changed, 13 insertions(+), 5 deletions(-) What changed from v1? Always put that below the --- line. Please fix up and resend a v3. thanks, greg k-h