Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Claudiu Manoil <claudiu.manoil@nxp.com>
To:     Pavel Machek <pavel@denx.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Sasha Levin <sashal@kernel.org>,
        "alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>
Subject: RE: [PATCH 4.19 042/113] ocelot: Dont sleep in atomic context
 (irqs_disabled())
Thread-Topic: [PATCH 4.19 042/113] ocelot: Dont sleep in atomic context
 (irqs_disabled())
Thread-Index: AQHVCxCoh95StDwt4EaQOEY0AHPDXKZu+5YAgAAJm2A=
Date:   Fri, 17 May 2019 09:27:01 +0000
Message-ID: <VI1PR04MB488053E08D56380DBB6EFB05960B0@VI1PR04MB4880.eurprd04.prod.outlook.com>
References: <20190515090652.640988966@linuxfoundation.org>
 <20190515090656.813206864@linuxfoundation.org> <20190517081642.GC17012@amd>
In-Reply-To: <20190517081642.GC17012@amd>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: a7ec9e43-a86b-45fe-7b42-08d6daa9d1af
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2019 09:27:02.0021
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB2973
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


>-----Original Message-----
>From: Pavel Machek <pavel@denx.de>
>Sent: Friday, May 17, 2019 11:17 AM
>To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>Cc: linux-kernel@vger.kernel.org; stable@vger.kernel.org; Claudiu Manoil
><claudiu.manoil@nxp.com>; David S. Miller <davem@davemloft.net>; Sasha
>Levin <sashal@kernel.org>
>Subject: Re: [PATCH 4.19 042/113] ocelot: Dont sleep in atomic context
>(irqs_disabled())
>
>On Wed 2019-05-15 12:55:33, Greg Kroah-Hartman wrote:
>> [ Upstream commit a8fd48b50deaa20808bbf0f6685f6f1acba6a64c ]
>>
>> Preemption disabled at:
>>  [<ffff000008cabd54>] dev_set_rx_mode+0x1c/0x38
>>  Call trace:
>>  [<ffff00000808a5c0>] dump_backtrace+0x0/0x3d0
>>  [<ffff00000808a9a4>] show_stack+0x14/0x20
>>  [<ffff000008e6c0c0>] dump_stack+0xac/0xe4
>>  [<ffff0000080fe76c>] ___might_sleep+0x164/0x238
>>  [<ffff0000080fe890>] __might_sleep+0x50/0x88
>>  [<ffff0000082261e4>] kmem_cache_alloc+0x17c/0x1d0
>>  [<ffff000000ea0ae8>] ocelot_set_rx_mode+0x108/0x188
>[mscc_ocelot_common]
>>  [<ffff000008cabcf0>] __dev_set_rx_mode+0x58/0xa0
>>  [<ffff000008cabd5c>] dev_set_rx_mode+0x24/0x38
>>
>> Fixes: a556c76adc05 ("net: mscc: Add initial Ocelot switch support")
>
>Is it right fix? Warning is gone, but now allocation is more likely to
>fail, causing mc_add() to fail under memory pressure.
>

So far this contributes to fixing a kernel hang issue, seen occasionally
when the switch interfaces were brought up.
Other than that I would look into improving this code.
It looks suboptimal at least.  Do we really need to allocate whole
struct netdev_hw_addr elements? Can the allocation size be reduced?
What about pre-allocating enough room for ha elements outside the
atomic context (set_rx_mode() in this case)?

Thanks,
Claudiu