Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2229623yba; Fri, 17 May 2019 12:56:57 -0700 (PDT) X-Google-Smtp-Source: APXvYqwLt85Ix0Yy+TvZMCiY/7XgvmQvnbXD63ou31IxE9x9CK5oNxTTI9CAy6dzU/NwpmthMM6o X-Received: by 2002:a17:902:6809:: with SMTP id h9mr59227451plk.129.1558123017764; Fri, 17 May 2019 12:56:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558123017; cv=none; d=google.com; s=arc-20160816; b=hzGECOFShmKNL59wUb65KEOooYyoVbPnCONjaE3wqrDcP2bb4K+172omrBCfCpwdHL h5mog2QhxA8Ig2wqgKBGmRM4L+jknRHPuV/KdkyfGB0kAA5msXM7LOBcwTzW2fJOHOlS WAryFAxER+FgBO3bSkVYl4Y2MHtM6toE+Ed030upeENJ9xmULeIX6xw6MXjNK8UsodD/ f04DzC9OHtvQLD3cMqmUBiS0ko3XYbKBgf8nv9Uhjs0aV2mJj53Ki/dvqMlQNmTmLwfA +RjglNhbY4ywOfNin/YhfSVVKEKpIFRzxMmBEfIGIUoL8XA3rLXlcEWAsqc/gY3Xx54v dZjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=K9GmkzfNZM0M8grbCdwcCTV4Oj4a/oUTzMQk9GWZvlQ=; b=aPUxp4C+ZCBAdH5kyTGZU7pDe1dFMYgpQvqawgPm9GL1xuehy2ROX/FORMmzp+GopQ yUeagASl2H2T1gTHUyeSjXl1Hv3quObAsLcvbcA+ojECD6Qnz+GRHd519VA/Xub8fHNW TD627mNxcxbcYKTABuQ2oitCps5ckO/qUSccOypb9A8KC2xfyTL1e3U3liuLM+Ig6MVu LdNgaI8AUTUuCUzL3z76OPJZrZs5KgJQfeLpigEXrjJorYl6Mh+edy2iiZemFsJmkO+o RNnWPEd/8vnDGpauTxgFzGp9qiMqQCptp7EP37s1RjKMtfWTTEwBdpoQcBu8ezoWKKYZ uzqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Awo8jfRw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o33si7752495pld.268.2019.05.17.12.56.41; Fri, 17 May 2019 12:56:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Awo8jfRw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729131AbfEQR7a (ORCPT + 99 others); Fri, 17 May 2019 13:59:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:55714 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728536AbfEQR73 (ORCPT ); Fri, 17 May 2019 13:59:29 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8E16921773; Fri, 17 May 2019 17:59:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558115969; bh=SWL63IOuJG5gM5oQVFmjLL4N6Eo6juwVs637U8pmW3c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Awo8jfRwqiLbT4uODENudpkr3n04WnSim8CidHfOxdmkowkaMyYyxbO/A+pXFKRYB ud7LuUB2+LYBY4084ih5NRclyWBW/sQZLKYGeseqa7U0/d6EvTH923bBN3Sy5OIs4o UdaX4xTRzNjihMcRiAGeutga/17xArb/5I5iTWTE= Date: Fri, 17 May 2019 19:59:26 +0200 From: Greg Kroah-Hartman To: Liming Sun Cc: Andy Shevchenko , Darren Hart , Vadim Pasternak , David Woods , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Mauro Carvalho Chehab , Jonathan Cameron , Nicolas Ferre , "Paul E. McKenney" Subject: Re: [PATCH v5 2/2] platform/mellanox/mlxbf-bootctl: Add the ABI definitions Message-ID: <20190517175926.GA24535@kroah.com> References: <0b74e9ad12360b56bc0a3c2ca972798c424f2610.1548790896.git.lsun@mellanox.com> <1558115345-32476-2-git-send-email-lsun@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1558115345-32476-2-git-send-email-lsun@mellanox.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 17, 2019 at 01:49:05PM -0400, Liming Sun wrote: > This commit adds the ABI definitions exposed to userspace for > the platform/mellanox/mlxbf-bootctl driver. > > Reviewed-by: Vadim Pasternak > Signed-off-by: Liming Sun > --- > .../ABI/testing/sysfs-platform-mellanox-bootctl | 58 ++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 59 insertions(+) > create mode 100644 Documentation/ABI/testing/sysfs-platform-mellanox-bootctl > > diff --git a/Documentation/ABI/testing/sysfs-platform-mellanox-bootctl b/Documentation/ABI/testing/sysfs-platform-mellanox-bootctl > new file mode 100644 > index 0000000..19a14db > --- /dev/null > +++ b/Documentation/ABI/testing/sysfs-platform-mellanox-bootctl > @@ -0,0 +1,58 @@ > +What: /sys/bus/platform/drivers/mlxbf-bootctl/lifecycle_state > +Date: May 2019 > +KernelVersion: 5.3 > +Contact: "Liming Sun " > +Description: > + The Life-cycle state of the SoC, which could be one of the > + following values. > + Production - Production state and can be updated to secure > + GA Secured - Secure chip and not able to change state > + GA Non-Secured - Non-Secure chip and not able to change state > + RMA - Return Merchandise Authorization A "driver" does not have a lifecycle state, a "device" does. You are putting all of these attributes in the wrong place. Put them on your device please, not the driver. driver-specific attributes are _VERY_ rare, and only for things that can modify/show for all devices attached to that driver. thanks, greg k-h