Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2355973yba; Fri, 17 May 2019 15:37:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqzQMciCFg7gEK9v/44MiZbE6+7xLLp/hHMlH2JaMBYu7vy+NWeBsKk4cmzbd45HQ5JIJMDq X-Received: by 2002:a62:640e:: with SMTP id y14mr44158089pfb.109.1558132627925; Fri, 17 May 2019 15:37:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558132627; cv=none; d=google.com; s=arc-20160816; b=Pqw7UYJGQ/Jvj570O5G+HHvTvg4nYZCzUU7RsxlNmYwC0AjNpEFCdyPchKGPymaRr/ oSGTgSTSWxizKC2ddG0zhZafnkx75CZttc4tY03uVrr+yvZWct/MvlIW/yvk98bNICyh tgcIUGgDKqn1yVd/RgQ2qw1uEPoXWxy2EESXU7T0xNS8i40NIzExHiQhoV8G0N7F3E13 HQDl4yhKuYtC/JeXUzWhOFz1sg2iWL1nBksBrs1ykgVxYQyTHlXEZZyZTgg9dDedACT5 30Drmf7m+EDQcEHhZVIsOztc7xhaKL28pfQnw4CRmdnYdoUnzDPJjhChr3ggKuE/KkF1 itfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from:dkim-signature; bh=bBJPlMULgaPfSx0QG6cmj+LGIWa+kkKU6hEWAnHgwSQ=; b=ybLvt9B3N1lasEXr3PlUKJGOlRvjSxxWGei0BL1kiqRy/x/fgphzf+8XJpqD1G/495 uu2QZKJuzhk/PrJ0ofj5q8/rvUWzn9CEiYoLkZkS17emoH2ZwUQU09kL6yX3gxYGMPVB wcmjDy4xXUi/VLXlxUEMfMVx+voC/lRfDBf4+9x8AhJrqn0226DKzPrQv8IKywQN4Qar 6ENPwppNkoBLmC2lO1sND/Uu9VAwyl2Jbk4cLsuTXfGDQEssLIyIhXk+Eb2HpoVFuLl/ O5VDmqGEtoy23rDCokctC8YV6FRUPm4mP4rsiTJCiI0JymF/JIdKpydMBNozK7sBQaGH zg3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@Mellanox.com header.s=selector2 header.b=rGQ9z+bd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mellanox.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u128si9241980pgc.152.2019.05.17.15.36.51; Fri, 17 May 2019 15:37:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@Mellanox.com header.s=selector2 header.b=rGQ9z+bd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=mellanox.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728637AbfEQUg6 (ORCPT + 99 others); Fri, 17 May 2019 16:36:58 -0400 Received: from mail-eopbgr80052.outbound.protection.outlook.com ([40.107.8.52]:35726 "EHLO EUR04-VI1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726293AbfEQUg6 (ORCPT ); Fri, 17 May 2019 16:36:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bBJPlMULgaPfSx0QG6cmj+LGIWa+kkKU6hEWAnHgwSQ=; b=rGQ9z+bdp2itYV2mVz9Dpzha1Oycbo+GmNCjxEds9M/4SlQd/7DxLvnccB3ffZoJTLgKYDla6Voxs4F5V9P4RAw3SacPuXSzpdvg8A6xxCATZAaOLsyeihDbI69QD++T81OqqmejC1jNcc295s30nkBNHvF/k/zuLxIKgiUYMuQ= Received: from DB6PR05MB3223.eurprd05.prod.outlook.com (10.175.232.149) by DB6PR05MB3208.eurprd05.prod.outlook.com (10.170.221.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1900.17; Fri, 17 May 2019 20:36:53 +0000 Received: from DB6PR05MB3223.eurprd05.prod.outlook.com ([fe80::244a:2b0:6510:9864]) by DB6PR05MB3223.eurprd05.prod.outlook.com ([fe80::244a:2b0:6510:9864%7]) with mapi id 15.20.1900.010; Fri, 17 May 2019 20:36:53 +0000 From: Liming Sun To: Greg Kroah-Hartman CC: Andy Shevchenko , Darren Hart , Vadim Pasternak , David Woods , "platform-driver-x86@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "David S. Miller" , Mauro Carvalho Chehab , Jonathan Cameron , Nicolas Ferre , "Paul E. McKenney" Subject: RE: [PATCH v5 2/2] platform/mellanox/mlxbf-bootctl: Add the ABI definitions Thread-Topic: [PATCH v5 2/2] platform/mellanox/mlxbf-bootctl: Add the ABI definitions Thread-Index: AQHVDNjmA7J6ytTaRUCpqARej1sfCqZvmtYAgAAkXdA= Date: Fri, 17 May 2019 20:36:53 +0000 Message-ID: References: <0b74e9ad12360b56bc0a3c2ca972798c424f2610.1548790896.git.lsun@mellanox.com> <1558115345-32476-2-git-send-email-lsun@mellanox.com> <20190517175926.GA24535@kroah.com> In-Reply-To: <20190517175926.GA24535@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=lsun@mellanox.com; x-originating-ip: [216.156.69.42] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 35e12a8b-a2d5-4486-ad43-08d6db07659b x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020);SRVR:DB6PR05MB3208; x-ms-traffictypediagnostic: DB6PR05MB3208: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0040126723 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(366004)(396003)(376002)(346002)(136003)(39860400002)(199004)(189003)(13464003)(6506007)(76176011)(52536014)(476003)(53546011)(305945005)(316002)(71190400001)(71200400001)(486006)(446003)(6436002)(102836004)(11346002)(33656002)(7736002)(7696005)(186003)(8936002)(54906003)(7416002)(81156014)(4326008)(25786009)(26005)(81166006)(9686003)(8676002)(99286004)(55016002)(6916009)(3846002)(6116002)(76116006)(73956011)(68736007)(229853002)(66066001)(64756008)(66446008)(66476007)(66556008)(66946007)(256004)(5660300002)(6246003)(14454004)(5024004)(86362001)(74316002)(2906002)(53936002)(478600001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR05MB3208;H:DB6PR05MB3223.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: eehj/6mjHxkwe2csO141joYjTOVeEPe07ugttp0iwSsKMoTPYTf0+Gn11T65xBqv2BljX0KQUvMyEWdwU8Y2RYMRJWawyL6CmvwUJA0whFHGYpVrUkqa/bHXwAwx0E0u499Nm5kCHbL+8I/lpK+X+lNXJziGFZpQg0SW/rh8bK5JWkCy56P1EKcxShfwEQZV+kGTM77vFYHWSLJ/rnE6oVODEm8vz5u+jlGTSRdtGhfOkJGcPZCqaO6svGUMtKvki91NdrULNUwqksWKE7L3B6HXySFt00PgJXVy//aHFZt5uHU1mx3ZubqSeF2ll7qnH+VyQYCrLlYde1w2eXsiI0Rsw0CXiRncv/alEMHLYsb5+8AvGaXupSLrJ2aPx/nkR1FVLF90WfCYc6przuVHyK5i4mIj4Wef0GqRB9ZG+Vc= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 35e12a8b-a2d5-4486-ad43-08d6db07659b X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2019 20:36:53.3800 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR05MB3208 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks Greg for the comments! Please see my response inline. Regards, - Liming > -----Original Message----- > From: Greg Kroah-Hartman > Sent: Friday, May 17, 2019 1:59 PM > To: Liming Sun > Cc: Andy Shevchenko ; Darren Hart ; Vadim Pasternak ; David > Woods ; platform-driver-x86@vger.kernel.org; linux-k= ernel@vger.kernel.org; David S. Miller > ; Mauro Carvalho Chehab = ; Jonathan Cameron > ; Nicolas Ferre ; Paul E. McKenney > Subject: Re: [PATCH v5 2/2] platform/mellanox/mlxbf-bootctl: Add the ABI = definitions >=20 > On Fri, May 17, 2019 at 01:49:05PM -0400, Liming Sun wrote: > > This commit adds the ABI definitions exposed to userspace for > > the platform/mellanox/mlxbf-bootctl driver. > > > > Reviewed-by: Vadim Pasternak > > Signed-off-by: Liming Sun > > --- > > .../ABI/testing/sysfs-platform-mellanox-bootctl | 58 ++++++++++++++= ++++++++ > > MAINTAINERS | 1 + > > 2 files changed, 59 insertions(+) > > create mode 100644 Documentation/ABI/testing/sysfs-platform-mellanox-b= ootctl > > > > diff --git a/Documentation/ABI/testing/sysfs-platform-mellanox-bootctl = b/Documentation/ABI/testing/sysfs-platform-mellanox- > bootctl > > new file mode 100644 > > index 0000000..19a14db > > --- /dev/null > > +++ b/Documentation/ABI/testing/sysfs-platform-mellanox-bootctl > > @@ -0,0 +1,58 @@ > > +What: /sys/bus/platform/drivers/mlxbf-bootctl/lifecycle_state > > +Date: May 2019 > > +KernelVersion: 5.3 > > +Contact: "Liming Sun " > > +Description: > > + The Life-cycle state of the SoC, which could be one of the > > + following values. > > + Production - Production state and can be updated to secure > > + GA Secured - Secure chip and not able to change state > > + GA Non-Secured - Non-Secure chip and not able to change state > > + RMA - Return Merchandise Authorization >=20 > A "driver" does not have a lifecycle state, a "device" does. >=20 > You are putting all of these attributes in the wrong place. Put them on > your device please, not the driver. driver-specific attributes are > _VERY_ rare, and only for things that can modify/show for all devices > attached to that driver. This driver is running on the ARM processor of the SoC. The 'device' is the SoC itself. That's to say, there is only one device here attached to the driver and the driver state will also be the device state. This interface has been used by user-space applications for a couple of releases. It'll be great if it could stay in such way for compatibility. Pl= ease advise if this is strongly preferred to move them under devices. >=20 > thanks, >=20 > greg k-h