Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2512681yba; Fri, 17 May 2019 19:32:32 -0700 (PDT) X-Google-Smtp-Source: APXvYqyHO9YSgCYVcGp13Qi/LPufE/1NYV7s0AnjofhprPr40xyvsAV3f2DNANj5tGE55BiAuGan X-Received: by 2002:a63:5659:: with SMTP id g25mr60876515pgm.59.1558146752482; Fri, 17 May 2019 19:32:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558146752; cv=none; d=google.com; s=arc-20160816; b=xp/kta3w2+miO+kqeSAW96dTkWSZy3tpfjZbpNTVL2GcWsoCPL4lvp58pNrmGFDKAL xShg7PFztTngCBdSGQzojZRtxEwPeejymAH0VsDBX9pTOFNcB/xqny6xNZWaRB1MOIsq Werpj9idSXM4MvRYFKoUBSt5xbQtq2F2LDPJkBSItAfS2jDZCq9rp3+iWh58kt12By5h MDd/Jzm8Ouwpn+N/yQu0c0Z7dvnniiLroNAl1/03oNhEx0YfvXMEYV5tJ0h1Fks4LlJn sRHHuorv2DQuSHROxvoBfA0rtgh9D1H50iCdczd2W5VjtV5fZgAX3hrzHOI51kTVCAxC qtWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:to :from:date:dkim-signature; bh=6dZilZOrKD/+f4wxtqkk21JzGk5u5RhKsFPFxYt0T2U=; b=Hk+c0LupaZ7pfYwMRVQjXpaVUwdpF57Ry9sbGiLGSyw/C0EkCvi2e/bk91bb/cS3sZ sNrXgy+yxyytGuZIxd0aoKZLJFh0G52QnXduzZkCGFFAYuAshKJwAa1NgYxVsTDs/e0h KUk/D4N4ULwBeB8IOCAbg08QCLXpC0Ndt59jxno44HEqn8L73QnBe+VD907k/J71yxsy g0L/QSNeUtaKFc7OxnIprqAV/yM2+ZUiiQ7EgG2icjoF0inK+WOw5ix4XrDjjpyHXMIM GmVwnFa2fOpxfxRYyu5KiFh5COBU4+PA2ID9ruTKwKlTa54IgII9IEvkUFt3dk/Mf4sL pmTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=oX8Jm3WI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d21si8859230pgl.591.2019.05.17.19.32.15; Fri, 17 May 2019 19:32:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=oX8Jm3WI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728775AbfERCMI (ORCPT + 99 others); Fri, 17 May 2019 22:12:08 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:44306 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726519AbfERCMI (ORCPT ); Fri, 17 May 2019 22:12:08 -0400 Received: by mail-pl1-f193.google.com with SMTP id c5so4120426pll.11 for ; Fri, 17 May 2019 19:12:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=6dZilZOrKD/+f4wxtqkk21JzGk5u5RhKsFPFxYt0T2U=; b=oX8Jm3WIfeGs/qVsZiRuWjgxZ/76rfWmJ/omU87ATD4OJ1kbpTezQAhoWHQyqKBAQz 8us0/wKPxGGSiRrvIPabw6/9xjAfVjr2U3t59wazZA1JSVzC7R6fwvFVvEhtupoMoeEl 5zg0z4EqN1Qi0traay24AxZ2SdcRZbqxBlnhtyUKoPcjc+OGHR/0Cccs6dP/1cNtwtdc 5jDC50RpUi9IgHJZ8QPrjFNGD/o4Jh/B8jvneUWeldaQwbYy7OXnyG1XOiCoJhTCA63/ DyRK8QHkmyQjPYf09CMEEh09DSsz7RoHyTMwQpOLYYguGY1ShYmjI9VxqG/6h3/PVX73 NAHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=6dZilZOrKD/+f4wxtqkk21JzGk5u5RhKsFPFxYt0T2U=; b=cCgHZ7ORVTj52zPPPpnvp8HNZ8vlGaxZZ2/yIVhlXDQaf2n9IHTXMY67QBVE6AJQKC oi7km2CCc2/dpVdA5VCI4/myjRnnLdZVDMZNL1TG2k2Df2rtUMhKK9QT+elyE4+Z7s0J bYwuOk1lDXe+VtxM8SmVfuP94tTW+rGXO86+DPDuclUL8TZdN2gnLqtNpg3M3STxB+hv yFmVtPkjAbOShxVQ3XgdkejO6iKdUPj0zZA9HUGgWG/12ojKfrZgzbNxnHy1atPzxOr5 hcPuoITQPIceHtRpJmBdBacFBGllPTy6Y625P7Tzp2/qttBIH73FJ/UQGgzWHJlXbS2Z 11Gw== X-Gm-Message-State: APjAAAUYe7/Qc5vauxHr8RTqhaez7YW8x8aH096/Rg/Os/4Ipc9m6eH0 tg+9RFA9cRbfaYAb/mLYJwXuKGys1/o= X-Received: by 2002:a17:902:63:: with SMTP id 90mr7240296pla.342.1558145526909; Fri, 17 May 2019 19:12:06 -0700 (PDT) Received: from localhost ([123.213.206.190]) by smtp.gmail.com with ESMTPSA id k7sm11847661pfk.93.2019.05.17.19.12.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 17 May 2019 19:12:06 -0700 (PDT) Date: Sat, 18 May 2019 11:12:03 +0900 From: Minwoo Im To: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH V3 0/5] nvme-trace: Add support for fabrics command Message-ID: <20190518021202.GB31204@minwooim-desktop> References: <20190512073413.32050-1-minwoo.im.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190512073413.32050-1-minwoo.im.dev@gmail.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19-05-12 16:34:08, Minwoo Im wrote: > Hi, > > Here's a third patchset to support fabrics command tracing. The first > patch updated host/trace module to a outside of it to provide common > interfaces for host and target both. The second one adds support for > tracing fabrics command from host-side. The third is a trivial clean-up > for providing a helper function to figure out given command structure is > for fabrics or not. > > The fourth and fifth are the major change points of this patchset. 4th > patch adds request tracing from the target-side. 5th updated, of course, > completion of given request. > > Please review. > Thanks, > > Changes to V2: > - Provide a common code for both host and target. (Chaitanya) > - Add support for tracing requests in target-side (Chaitanya) > - Make it simple in trace.h without branch out from nvme core module > (Christoph) > > Changes to V1: > - fabrics commands should also be decoded, not just showing that it's > a fabrics command. (Christoph) > - do not make it within nvme admin commands (Chaitanya) > > Minwoo Im (5): > nvme: Make trace common for host and target both > nvme-trace: Support tracing fabrics commands from host-side > nvme: Introduce nvme_is_fabrics to check fabrics cmd > nvme-trace: Add tracing for req_init in trarget > nvme-trace: Add tracing for req_comp in target Ping :)