Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4098752yba; Sun, 19 May 2019 10:37:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqyoJ7rS6r83gwS2+vK7to8wPqsZFfLtc7IuELFCkZ/OR93/fLWmXfhRCwfmAFvHsmfGlFgV X-Received: by 2002:a17:902:82ca:: with SMTP id u10mr58239366plz.231.1558287443323; Sun, 19 May 2019 10:37:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558287443; cv=none; d=google.com; s=arc-20160816; b=Ci8imQ5ikpeG4DoT0taq4UHWffZekgSCaHw3ssNA0qI/q11qtlNivRHN3O8XOAAVht cGHAMrBQMx8+ejAU8oE24naRSuipZhNt46vHz7EeIIoQiIt+6m/DeL34Xk0I/24jAP71 kQYHwwwzb952W9E0A4Ol82pSObtdoN04JVHjNKU/qkcDgiMPkHPz+GGwJhL/FsKBRMtQ 7vpH8DdIPDgEpg/K3fr23u0csvEFnghiI27o1eCs55d05TeiPf52uVOz2ckE6CCBnnMV ZeW2ZBq/3DhknejN7BNsF8cziIoxQ3FFLxlzTqsmGXr1MkDALSfLGaR/tzZN7Dj8wfXR JEQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=7YoYOYP/Wmb6naNUctNBiWxyvLNnviyV/estUgBMuBI=; b=GTpPMT5Uto8KjKIxAwHdoPmgg7yiPf5waT3xPOdlVxndZyf6ZMuxALbbuNU3PLY4F0 yYUOCllfjYzaWa9lrsgGBN8Qoiyle7gk5UkyZIruOAx+17zbtejt1398Iteq/cSJ0DaG zpKsjRK4R93wLmDK6LxXz3SOxou0W+LPTbL1zyTlOIEFyOsU28/Z0Mjz/cd7x7CSfVpe 2nEgyhqX8jfI5ILBdaagkD7fl43fH39bhZeDAKC7hPfmitCLTgm2MGbXN4SyN7VWnZg5 de7sdy3ZBjJNfwrEKqzB3EoUI1oJX+gWXxY8DpUQIPR9bcehul2AFyn2Nf/NsYMxdVEc GwYw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a17si15110871pgb.25.2019.05.19.10.37.08; Sun, 19 May 2019 10:37:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728337AbfESRff convert rfc822-to-8bit (ORCPT + 99 others); Sun, 19 May 2019 13:35:35 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:41188 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727130AbfESRfe (ORCPT ); Sun, 19 May 2019 13:35:34 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d8]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id B546C13F0734F; Sun, 19 May 2019 10:35:33 -0700 (PDT) Date: Sun, 19 May 2019 10:35:33 -0700 (PDT) Message-Id: <20190519.103533.1752298588551711978.davem@davemloft.net> To: ynezz@true.cz Cc: robh+dt@kernel.org, frowand.list@gmail.com, andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com, mlindner@marvell.com, stephen@networkplumber.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] of_net: fix of_get_mac_address retval if compiled without CONFIG_OF From: David Miller In-Reply-To: <1558268324-5596-1-git-send-email-ynezz@true.cz> References: <1558268324-5596-1-git-send-email-ynezz@true.cz> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-15 Content-Transfer-Encoding: 8BIT X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 19 May 2019 10:35:34 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Petr ?tetiar Date: Sun, 19 May 2019 14:18:44 +0200 > of_get_mac_address prior to commit d01f449c008a ("of_net: add NVMEM > support to of_get_mac_address") could return only valid pointer or NULL, > after this change it could return only valid pointer or ERR_PTR encoded > error value, but I've forget to change the return value of > of_get_mac_address in case where the kernel is compiled without > CONFIG_OF, so I'm doing so now. > > Cc: Mirko Lindner > Cc: Stephen Hemminger > Fixes: d01f449c008a ("of_net: add NVMEM support to of_get_mac_address") > Reported-by: Octavio Alvarez > Signed-off-by: Petr ?tetiar Applied, thanks.