Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 18 May 2019 21:43:02 -0700 (PDT)
From:   David Rientjes <rientjes@google.com>
To:     Gen Zhang <blackgod016574@gmail.com>
cc:     iamjoonsoo.kim@lge.com, linux-kernel@vger.kernel.org
Subject: Re: [Patch] slub: Fix a missing-check bug in mm/slub.c file of Linux
 5.1.1
In-Reply-To: <20190515064457.GA29939@zhanggen-UX430UQ>
Message-ID: <alpine.DEB.2.21.1905182141280.180590@chino.kir.corp.google.com>
References: <20190515064457.GA29939@zhanggen-UX430UQ>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 15 May 2019, Gen Zhang wrote:

> Pointer s is allocated with kmem_cache_zalloc(). And s is used in the 
> follwoing codes. However, when kmem_cache_zalloc fails, using s will
> cause null pointer dereference and the kernel will go wrong. Thus we 
> check whether the kmem_cache_zalloc fails.
> 
> Signed-off-by: Gen Zhang <blackgod016574@gmail.com>
> 

It's ok if we encounter a NULL pointer dereference here, if we are ENOMEM 
then there is no way to initialize the slub allocator to be able to 
perform any future memory allocation.  Returning an error code won't help.

> ---
> --- mm/slub.c
> +++ mm/slub.c
> @@ -4201,6 +4201,8 @@ static struct kmem_cache * __init bootst
>  {
>  	int node;
>  	struct kmem_cache *s = kmem_cache_zalloc(kmem_cache, GFP_NOWAIT);
> +	if (!s)
> +		return ERR_PTR(-ENOMEM);
>  	struct kmem_cache_node *n;
>  
>  	memcpy(s, static_cache, kmem_cache->object_size);

It's not legal to mix declarations within the C code here.