Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4360321yba; Sun, 19 May 2019 17:31:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqzvshUuWCoKpkO747DnwiFvrSHV8WEnOPyCqrsbRTT3nyE1z3S3hkeWZsX/x8dELBdIPxTP X-Received: by 2002:a17:902:304:: with SMTP id 4mr34577471pld.120.1558312315790; Sun, 19 May 2019 17:31:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558312315; cv=none; d=google.com; s=arc-20160816; b=eFWdUdsuKanQNa6jCTHDlaBoxIxjntLgk2CsJLJVhNZFIiZVdC7Z/ykR3B3cCRsrpM p8Q3q7ScrQrCztSgsCLVDCpQSk3OL2qoonqi1JXymBxBX/Y83D2KJjgfARgedDRmFOah ul27neXBXLwklsFI+nzI3cLyFirFe4mscFZeUgrkvdzOemXG00GOa7jw0qYtBjlHGY2/ BAD3qY6KbY1dlA5+mM+hGNDz4XmG+tTGArqBa8uk5+R+v3KGyifltFmQH0pNQxDqqzUC YrCQx4C8SEZ7tDYGVwlQgDyeLItsZ3Aowu59XuNNOc8o8VNewe8eMNAv16pBO71ylitx pMgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:to:from; bh=aDYFbdQhXIfDS+l7P3IBaB59Yk1WKkL7Ur/KW18ZSRY=; b=h35eDxBKzWC3VnRk6ntvorkXlsDcc+6gMT2zhtGy6i3JRYNu2voO6fgUDKAjS5Yaic fYm12xUU162vdoSs3UFashSu2Jr2X118AWpGwbhCJ/auHP3okmM9PW6vaAp+P86Kn3fM pZH+G5qbGtDqW10QYTc6uFtSfDHpBVwMvPWFwwZivvROwy778lJlx3+5ywTbD93krNrM 5nDQ7nZJdovXOUro4hTs6/U1eZrZDLTM46N4XTF7em5CvSNNe2sE0AmAqsXN/VUKhGJ2 SEoNUJAqeEIp0iC3xWskeg3/ntfYB5jElvok6+EiqhDWPnP4baytWAfs54AAxj84RALn hLRg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h1si16091637pgp.232.2019.05.19.17.31.28; Sun, 19 May 2019 17:31:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730078AbfESTYG (ORCPT + 99 others); Sun, 19 May 2019 15:24:06 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:53819 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726066AbfESTYG (ORCPT ); Sun, 19 May 2019 15:24:06 -0400 Received: from [61.149.195.63] (helo=localhost.localdomain) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1hSGEC-0004LW-CO; Sun, 19 May 2019 07:27:29 +0000 From: Aaron Ma To: aaron.ma@canonical.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com, benjamin.tissoires@redhat.com Subject: [PATCH 2/2] Input: synaptics - remove X240 from the topbuttonpad list Date: Sun, 19 May 2019 15:27:11 +0800 Message-Id: <20190519072711.2592-2-aaron.ma@canonical.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190519072711.2592-1-aaron.ma@canonical.com> References: <20190519072711.2592-1-aaron.ma@canonical.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Lenovo ThinkPad X240 does not have the top software button. When this wrong ID in top button list, smbus mode will fail to probe, so keep it working at PS2 mode. Cc: stable@vger.kernel.org Signed-off-by: Aaron Ma --- drivers/input/mouse/synaptics.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c index b6da0c1267e3..6ae7bc92476b 100644 --- a/drivers/input/mouse/synaptics.c +++ b/drivers/input/mouse/synaptics.c @@ -140,7 +140,6 @@ static const char * const topbuttonpad_pnp_ids[] = { "LEN002E", "LEN0033", /* Helix */ "LEN0034", /* T431s, L440, L540, T540, W540, X1 Carbon 2nd */ - "LEN0035", /* X240 */ "LEN0036", /* T440 */ "LEN0037", /* X1 Carbon 2nd */ "LEN0038", -- 2.17.1