Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "james qian wang (Arm Technology China)" <james.qian.wang@arm.com>
To:     "Lowry Li (Arm Technology China)" <Lowry.Li@arm.com>
CC:     Liviu Dudau <Liviu.Dudau@arm.com>,
        "maarten.lankhorst@linux.intel.com" 
        <maarten.lankhorst@linux.intel.com>,
        "seanpaul@chromium.org" <seanpaul@chromium.org>,
        "airlied@linux.ie" <airlied@linux.ie>,
        Brian Starkey <Brian.Starkey@arm.com>,
        Ayan Halder <Ayan.Halder@arm.com>,
        "Jonathan Chai (Arm Technology China)" <Jonathan.Chai@arm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "Julien Yin (Arm Technology China)" <Julien.Yin@arm.com>,
        nd <nd@arm.com>
Subject: Re: [v2] drm/komeda: Creates plane alpha and blend mode properties
Thread-Topic: [v2] drm/komeda: Creates plane alpha and blend mode properties
Thread-Index: AQHVDtHFUO59T3T3VkWZqubG8mkPOA==
Date:   Mon, 20 May 2019 06:03:40 +0000
Message-ID: <20190520060334.GA2690@james-ThinkStation-P300>
References: <1554971844-22101-1-git-send-email-lowry.li@arm.com>
In-Reply-To: <1554971844-22101-1-git-send-email-lowry.li@arm.com>
Accept-Language: en-US
Content-Language: en-US
user-agent: Mutt/1.9.4 (2018-02-28)
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 7068d6b7-f7be-4ac4-2d18-08d6dce8e844
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020);SRVR:VE1PR08MB4832;
x-ms-traffictypediagnostic: VE1PR08MB4832:
x-ms-exchange-purlcount: 3
nodisclaimer: True
x-microsoft-antispam-prvs: <VE1PR08MB48327FF72C4B9192DDDC1865B3060@VE1PR08MB4832.eurprd08.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:655;
x-forefront-prvs: 004395A01C
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(7916004)(39860400002)(366004)(396003)(136003)(346002)(376002)(199004)(189003)(8936002)(6862004)(6506007)(52116002)(99286004)(4326008)(68736007)(316002)(966005)(54906003)(53936002)(86362001)(58126008)(478600001)(386003)(6436002)(6306002)(55236004)(9686003)(305945005)(486006)(7736002)(5660300002)(11346002)(6246003)(14454004)(476003)(66066001)(102836004)(446003)(76176011)(6512007)(66476007)(66556008)(73956011)(64756008)(66446008)(25786009)(81156014)(81166006)(2906002)(256004)(66946007)(33656002)(3846002)(6116002)(186003)(6486002)(71190400001)(6636002)(26005)(229853002)(8676002)(33716001)(71200400001)(1076003)(5024004);DIR:OUT;SFP:1101;SCL:1;SRVR:VE1PR08MB4832;H:VE1PR08MB5006.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: arm.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: qIGSsB0OKNsvp1XCbKtVvYOsCUZKr5HuLKVqS+oP/81f6PsOFz1I1nsDnEozeMDMYNbWdwSnHVAlXwFSCHE8YEsvx5gzSy7sim0GD8CiYAv+FjxV7TpzaO6dZTYCZXRR1vsdbRMyGpeg/gTqZLCkg7b5mciiA38KAC/baGJeFe1NSzL6jDn2uaF55pCnkguozkmsX6I07scPjqCm8N5cEzhP9Q36ouYI2zLRfgVChI2lgAoH2yM0ZokwRhD+uMv4564vdI3tzRoWm41gLDcF8d1Y9Jx0jlK0YOHCsdk/F0bwwoKy1oIStB+syW7WAnM8VcTeHIJCHGRQC1lRBoOanFa1VV8IQME5HEdDePQb7CMn8zMGURGv9H+TsB/I4eM3ZWBmX0jbSimtVszt5sg21/B1WHtFMJiON7UH6gBbpsk=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <0431D2006ACF2543B05189EAD3AC6BCB@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7068d6b7-f7be-4ac4-2d18-08d6dce8e844
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2019 06:03:40.9917
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4832
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Apr 11, 2019 at 08:37:43AM +0000, Lowry Li (Arm Technology China) w=
rote:
> Creates plane alpha and blend mode properties attached to plane.
>=20
> This patch depends on:
> - https://patchwork.freedesktop.org/series/54448/
> - https://patchwork.freedesktop.org/series/54449/
> - https://patchwork.freedesktop.org/series/54450/
>=20
> Changes since v1:
> - Adds patch denpendency in the comment
>=20
> Signed-off-by: Lowry Li (Arm Technology China) <lowry.li@arm.com>
> ---
>  drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>=20
> --=20
> 1.9.1
>=20
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c b/drivers/=
gpu/drm/arm/display/komeda/komeda_plane.c
> index 68cd2c9e..aae5e80 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c
> @@ -220,6 +220,17 @@ static int komeda_plane_add(struct komeda_kms_dev *k=
ms,
> =20
>  	drm_plane_helper_add(plane, &komeda_plane_helper_funcs);
> =20
> +	err =3D drm_plane_create_alpha_property(plane);
> +	if (err)
> +		goto cleanup;
> +
> +	err =3D drm_plane_create_blend_mode_property(plane,
> +			BIT(DRM_MODE_BLEND_PIXEL_NONE) |
> +			BIT(DRM_MODE_BLEND_PREMULTI)   |
> +			BIT(DRM_MODE_BLEND_COVERAGE));
> +	if (err)
> +		goto cleanup;
> +
>  	return 0;
>  cleanup:
>  	komeda_plane_destroy(plane);

Looks good to me.

Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.co=
m>