Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 20 May 2019 09:24:47 +0200
From:   Maxime Ripard <maxime.ripard@bootlin.com>
To:     Jernej =?utf-8?Q?=C5=A0krabec?= <jernej.skrabec@siol.net>
Cc:     wens@csie.org, robh+dt@kernel.org, mark.rutland@arm.com,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: sun8i-h3: Fix wifi in Beelink X2 DT
Message-ID: <20190520072447.snt4phx57b5rfjv4@flea>
References: <20190516161039.18534-1-jernej.skrabec@siol.net>
 <20190517073048.y6mzgbhhryfmuckl@flea>
 <36237813.UWQAqNRFN9@jernej-laptop>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="ctmlzvhrt42rr7y5"
Content-Disposition: inline
In-Reply-To: <36237813.UWQAqNRFN9@jernej-laptop>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--ctmlzvhrt42rr7y5
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, May 18, 2019 at 05:07:11PM +0200, Jernej =C5=A0krabec wrote:
> Dne petek, 17. maj 2019 ob 09:30:48 CEST je Maxime Ripard napisal(a):
> > Hi,
> >
> > On Thu, May 16, 2019 at 06:10:39PM +0200, Jernej Skrabec wrote:
> > > mmc1 node where wifi module is connected doesn't have properly defined
> > > power supplies so wifi module is never powered up. Fix that by
> > > specifying additional power supplies.
> > >
> > > Additionally, this STB may have either Realtek or Broadcom based wifi
> > > module. One based on Broadcom module also needs external clock to work
> > > properly. Fix that by adding clock property to wifi_pwrseq node.
> > >
> > > Fixes: e582b47a9252 ("ARM: dts: sun8i-h3: Add dts for the Beelink X2 =
STB")
> > > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> > > ---
> > >
> > >  arch/arm/boot/dts/sun8i-h3-beelink-x2.dts | 5 +++++
> > >  1 file changed, 5 insertions(+)
> > >
> > > diff --git a/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts
> > > b/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts index
> > > 6277f13f3eb3..6a0ac85b4616 100644
> > > --- a/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts
> > > +++ b/arch/arm/boot/dts/sun8i-h3-beelink-x2.dts
> > > @@ -89,7 +89,10 @@
> > >
> > >  	wifi_pwrseq: wifi_pwrseq {
> > >
> > >  		compatible =3D "mmc-pwrseq-simple";
> > >
> > > +		pinctrl-names =3D "default";
> >
> > pinctrl-names only make sense with another pinctrl-[0-255]
> > property. Did you forgot something here?
>
> No, I just took BananaPi M2+ as a example, which has pinctrl-names proper=
ty
> too and no "pinctrl-*". But digging through history of this DT, it seems =
that
> this is just leftover which somebody forgot to remove.
>
> I'll send v2.

This should be fixed in 5.2 thanks to the commit 75f9a058838b

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

--ctmlzvhrt42rr7y5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXOJWPwAKCRDj7w1vZxhR
xYE+AP9QhFtjiygFXgICwzp6Lq1kpc5kHMNcjkJ+93Xus3Y9QwD+Kfwc+m/R0CkH
brzk6h/WxMESpp9HioHOUA0ql3LAWAk=
=go8o
-----END PGP SIGNATURE-----

--ctmlzvhrt42rr7y5--