Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4632318yba; Mon, 20 May 2019 00:33:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqzrPGE6/xxV/wwJOntLiiuC0/j6X7YQMSLEtOhdmG12vtrp0UnVk5i4+5BnKAzzd4tMKOmp X-Received: by 2002:a17:902:a611:: with SMTP id u17mr39510537plq.38.1558337611753; Mon, 20 May 2019 00:33:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558337611; cv=none; d=google.com; s=arc-20160816; b=Kv36wCg1dWX19X2rBfy/WljhsnkYPnC3vlutibr0/ufYY5fXJ7sKU72jpAGGunfeIg XE/i+NZHzEInMi5uzc8gAbil4D+KYhIoyVqTc+PVf3rNPJU409+DCy4cJEtBOL14KfvJ rdnFeiJyJ/g92nEUziMijX+gNWrutdCnQGIV3jXgsJJWf9Wny381eDH21xrgU2amH9JI SJm+rH5CLULdqGNmt/ZPFfFJhYljISlqjkbah2enqiwulvnrVnOiDU4BIYsz0QuACQQc Q5U1GaI4Xo4s9/mcGn+uMH7bjkFi8WESx/oYC7pFwFFwoVjREEs37BX3vZk2mh74/R3M ti5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=0MUoZeolyju0ppH/Ou6THzBWxw9cfiAMzAM8wvQHZow=; b=lO8eb36MJz7RrBMymNI31fZtj54lzoq/gNFZYg7XHl+GP1jmHhb34v64ZlSgfuufls rzXX/ZFRQMLgLtk8TqkLL56fRXR2Zx0w6GBwMY968Qo0GtbxPmlnN6en5KMDgHGVWUi3 JRmUaG5GI74gRKrJ4Pg+bfqB/XBv89SaNKWfutzC+3faZxpvkamwyvvJGAw9LCm4qdB0 dGoQtNYpryDyAS+3itMiW/Vj9CIel595JFfNdVE4xBqOMqqd9mXDtk345WfWEkez8rOC QW//CapZaICwH/eltmscNcK095yPjHs6S10cqjg4+XmdV+ce20J3BUwv+VTIysNckGKl r0FA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=B1YJ06nh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f17si18363747pgn.99.2019.05.20.00.33.17; Mon, 20 May 2019 00:33:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=B1YJ06nh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730699AbfETHau (ORCPT + 99 others); Mon, 20 May 2019 03:30:50 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:41624 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725983AbfETHat (ORCPT ); Mon, 20 May 2019 03:30:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=0MUoZeolyju0ppH/Ou6THzBWxw9cfiAMzAM8wvQHZow=; b=B1YJ06nhbwQxMVr57VUJOD/Fr9 sPMXGmELhdiVQ902kBilip0rAaZll0T7e78vfLHp3pPy3CwzKzCISId9tN3AyLEsgEVq8CtmtX4og 9/pIfw75//y08p15DkeebnXr9q+Zk4sy3gAiLNvHNinuapkhr4apiHxVRoltZ6iH2CwgObp8l+P8d pLXEbhnWxSYt9/QsVGT9IPYNbdFDD9aIiSWdBJ51wuREk2axQA84UDSOFn+D+x/fdzcuY9mqZg+s4 FuHk4xfFAk/QTOtj9SkzlWg1QXu5lDTUjiw5M5X8UHT81wF+s3VfAY1jp06Dt79pMk0XZ8wLihQIX n5qIT9Kw==; Received: from 089144206147.atnat0015.highway.bob.at ([89.144.206.147] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1hScks-0003k0-KD; Mon, 20 May 2019 07:30:43 +0000 From: Christoph Hellwig To: Robin Murphy Cc: Joerg Roedel , Catalin Marinas , Will Deacon , Tom Murphy , iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 01/24] arm64/iommu: handle non-remapped addresses in ->mmap and ->get_sgtable Date: Mon, 20 May 2019 09:29:25 +0200 Message-Id: <20190520072948.11412-2-hch@lst.de> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190520072948.11412-1-hch@lst.de> References: <20190520072948.11412-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org DMA allocations that can't sleep may return non-remapped addresses, but we do not properly handle them in the mmap and get_sgtable methods. Resolve non-vmalloc addresses using virt_to_page to handle this corner case. Signed-off-by: Christoph Hellwig Reviewed-by: Robin Murphy Acked-by: Catalin Marinas --- arch/arm64/mm/dma-mapping.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/arch/arm64/mm/dma-mapping.c b/arch/arm64/mm/dma-mapping.c index 78c0a72f822c..674860e3e478 100644 --- a/arch/arm64/mm/dma-mapping.c +++ b/arch/arm64/mm/dma-mapping.c @@ -249,6 +249,11 @@ static int __iommu_mmap_attrs(struct device *dev, struct vm_area_struct *vma, if (dma_mmap_from_dev_coherent(dev, vma, cpu_addr, size, &ret)) return ret; + if (!is_vmalloc_addr(cpu_addr)) { + unsigned long pfn = page_to_pfn(virt_to_page(cpu_addr)); + return __swiotlb_mmap_pfn(vma, pfn, size); + } + if (attrs & DMA_ATTR_FORCE_CONTIGUOUS) { /* * DMA_ATTR_FORCE_CONTIGUOUS allocations are always remapped, @@ -272,6 +277,11 @@ static int __iommu_get_sgtable(struct device *dev, struct sg_table *sgt, unsigned int count = PAGE_ALIGN(size) >> PAGE_SHIFT; struct vm_struct *area = find_vm_area(cpu_addr); + if (!is_vmalloc_addr(cpu_addr)) { + struct page *page = virt_to_page(cpu_addr); + return __swiotlb_get_sgtable_page(sgt, page, size); + } + if (attrs & DMA_ATTR_FORCE_CONTIGUOUS) { /* * DMA_ATTR_FORCE_CONTIGUOUS allocations are always remapped, -- 2.20.1