Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4677318yba; Mon, 20 May 2019 01:36:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqw8QLIDPqkyKLLwKFCcXske3ww+VNltFacdKljgdwuROup8kz/vhXRdNXalB9RRQlWltO9p X-Received: by 2002:a63:e24:: with SMTP id d36mr74385404pgl.80.1558341396839; Mon, 20 May 2019 01:36:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558341396; cv=none; d=google.com; s=arc-20160816; b=pLqAvm9kTMRasW4SeAsoIxWjhE1WmKUixHOgHZ/yOU3gJyzLD95vpyfaIpSHzOsnUP 1HWirtSAYwnrEhEAk6s9h43cRA/YbVLqx/T4G63y5NSefCKUZUXTpxATYFiZUUnwMnnC ia96wtBDZ2FNtM5Pjxkr+xPs9MHclJo99pD5jr4yQLuRHFM5GPFcFgEO5r89QzLzpDKy 7uLFC2nBuAni3XOcDLm5a4gAduluMBj4aRqdXFhEFuWOHQwKEkCiw432c73x02S5ilSX ZPk0DB6MJosVSrwTjXnQ4RA1YyNXx96WkhTiN1EQj5gMtyhFBYOa/G7PczoHE7k0/yYH J1KA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=n/yIzKd81+TM+3UvGV1Qf2W8qzlZxmI5yFYDnHihTSo=; b=nrVVndoaGY2s13ZF/Omaa4WMRclgEMU83/oZqfBYBJQtnQ+zYHh5uQbE73RrmeBn2B GfRMPYvscA6uzSFlVrcBobDLRglhFkm6WTU1oHYtLwbzatvakp9cYclUAiWjIgK8c6by TOFc3RgbMFoj2hF2vS9tb9prQXbh8CT0RJ4jOZ1aykrUuEc1kUzJc2Kck2LVj0BVkSp7 w2acFMDmBzBWQDZ/XkQ09fFmFvOYZKe7zK8gytwhppp8I3zyz/z239IbAbTlZ/i00urP lcMHhlTsldZzHkcJ4HGQvw5HpUIamonQjP893DJGTbVbz7qnEl+DSmO0UtRDszuQ7VF1 DyXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=urnzw8Vm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s8si17627081pga.251.2019.05.20.01.36.20; Mon, 20 May 2019 01:36:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=urnzw8Vm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730470AbfETF5D (ORCPT + 99 others); Mon, 20 May 2019 01:57:03 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:33834 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725829AbfETF5C (ORCPT ); Mon, 20 May 2019 01:57:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=n/yIzKd81+TM+3UvGV1Qf2W8qzlZxmI5yFYDnHihTSo=; b=urnzw8VmiMP9TugzAfLgp6yc7 dfmBhTiVp1UyVNGQyqHS1Nnn4tFxpWfNDOjlhG3NMqQ3E4wFTCes/z0TWLH1SfqsWpD5/akz+DBX/ oHbWkpIrbZP24i2cUziddSM5kBml+LER0VrkrORsAxP71POf02NXO+DhU5vbIZJFNG9kbJ5aV7TEL YCG9fYcgSfdhXvp1Wj2JL25KemMRrINp4Rmms//Dv1Iw5ebeBX5Tsc/k2CzUtT0G+iCSf9LYn1qfl jXOt5kQpf7Iwn84rir0nFGULr6aU1NNTbqKi+ZA0YY3lh0okwoFeQ6Ngq+VbJVUoWRVYvs0RWtiut g1CGMTSvQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1hSbI9-0005Xy-GO; Mon, 20 May 2019 05:56:57 +0000 Date: Sun, 19 May 2019 22:56:57 -0700 From: Christoph Hellwig To: Jaewon Kim Cc: gregkh@linuxfoundation.org, m.szyprowski@samsung.com, linux-mm@kvack.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Jaewon Kim , ytk.lee@samsung.com Subject: Re: [RFC PATCH] usb: host: xhci: allow __GFP_FS in dma allocation Message-ID: <20190520055657.GA31866@infradead.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Folks, you can't just pass arbitary GFP_ flags to dma allocation routines, beause very often they are not just wrappers around the page allocator. So no, you can't just fine grained control the flags, but the existing code is just as buggy. Please switch to use memalloc_noio_save() instead.