Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4754083yba; Mon, 20 May 2019 03:13:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqxyvkvIMl9TmTHLHkJJE4caWTvHvXHLFCFM1cB4xV93Skz8kQg/gYKjAwscnyXDIfYeC5yT X-Received: by 2002:a63:1061:: with SMTP id 33mr48251333pgq.328.1558347228474; Mon, 20 May 2019 03:13:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558347228; cv=none; d=google.com; s=arc-20160816; b=fgDXTkru1ZG8rYw3BDD3jWloiLX8cxKQkmSXNnDzVjSw3ySBhMmzMWhqY+djyUJHoI V4EuzSOHbE+iEMYIM2Ws01SfHlE+2I7AaD3SewtHn4a4i5xeSihxbVGvAkPMZK2Fl53t C4zYAqel2NI5sKj1IB11ZPRc4bG8o+UQozc/kIiGbYmPZuTc1W1Gr1djL7n30I9j9ra5 0bbhH/mLcnhiaWfYQ8lzH0vcAwFjz6e8ncot6zAVp91WKgUN6U74CbJrerbTLHA0CQOu mOPzn5pnBlIhE5jgAZ+a33NrfYXp3TUXOBOXEzNR0WM1RooemEEcF0A1HiMLBXeSyPAx QDsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=ktchpIaf6Qn4t/lbS5YwI1umrEsw+iYk4oGTYPAn0Z4=; b=S2sEzQo20xDqdkJdxt6GCHVbtyoIlUSAfe620FI6elP8fsuUIKJklKGmyStFFoOm7I o70JbYQ4K+jQ5u20ha/f7wveRwBX2vcR+qUXIxvN+0phBWMWY+xUTj5400tutaJp7PWP APquxBgjUnmvQxM3UeI8MpyycV3go1Ea82vsnIIdjRZ7bdKuvo2V4Pn0FzPitg564rh2 0ghHvKEWvGcWeK/6L/8Y4bdhNHic9gh7RiMJT5x/AsS0MAyjj9/Tc487JSlwdEeYalWg QNGX+Tc0c+jJVSAdl0erOi7XaSz+Arkkai34eA8nDe+2zcXCYnIXN3AJ0v4Ure6iq6PM 7OLQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=f9ChIGUv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q6si4640215pll.226.2019.05.20.03.13.32; Mon, 20 May 2019 03:13:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=f9ChIGUv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730856AbfETIqY (ORCPT + 99 others); Mon, 20 May 2019 04:46:24 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:43233 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730433AbfETIqY (ORCPT ); Mon, 20 May 2019 04:46:24 -0400 Received: by mail-ed1-f65.google.com with SMTP id w33so22607769edb.10 for ; Mon, 20 May 2019 01:46:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ktchpIaf6Qn4t/lbS5YwI1umrEsw+iYk4oGTYPAn0Z4=; b=f9ChIGUvlt3CGWSwsg5qPs2S81uHmGSPPzHRp7MzBDCGH8RrjqSrA1LMroNIKQn9zR dtEqrgctZXB0wz9jZbJGT4o7k1tdN8qO9Jo1lBRwBLbu0zBh8DgmjeeuuKkYFhR6SBWL XuC6TNn9EfTIz6CsUjL484mAsQk5dTlGIV0wI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ktchpIaf6Qn4t/lbS5YwI1umrEsw+iYk4oGTYPAn0Z4=; b=X76oQ470UEEaRQ2ZOfvq7Q58PEAecDzUsiGnkOf6b3KLfrOGAW1YgFmn62QnsqwQNy ulcSIeebFSPNN3MNU8DDqd0KRKjNSLKRJP3K29Ouy8QVNGr6cip3h5p+MVs9qtn1HDvG Y3/IIXW2s3DOSzTOatUrBmCEprWWZHWM2X8u7h9RBxCEQjwIjD+9i9kjgnlJ4zxALTi8 Ltf5r31fZLoObqIrbihhNHAtsuQGOY9cfDbC9BLfLej/sqOcJ67UgPYyao82C3vwqNVc xiOv4jz+owvAcjnbm6C06Gj1iAIvr7eVkQu9Bd3VAOwJ3h+32NrN6PAlz7qXtA4VM/Th wvuw== X-Gm-Message-State: APjAAAXSoWKvWOzWMr8UpFLXZJcObbK3dz1rcStzMXUi8BJMlJMQ2tse /bCaXQDeWdImvFu4CtvEBR7UEg== X-Received: by 2002:aa7:c0d3:: with SMTP id j19mr43042628edp.179.1558341982511; Mon, 20 May 2019 01:46:22 -0700 (PDT) Received: from [10.176.68.125] ([192.19.248.250]) by smtp.gmail.com with ESMTPSA id s57sm5294935edd.54.2019.05.20.01.46.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 May 2019 01:46:21 -0700 (PDT) Subject: Re: [PATCH 2/3] mmc: core: API for temporarily disabling auto-retuning due to errors To: Wolfram Sang , Douglas Anderson Cc: Ulf Hansson , Kalle Valo , Adrian Hunter , linux-rockchip@lists.infradead.org, Double Lo , briannorris@chromium.org, Madhan Mohan R , mka@chromium.org, Wright Feng , Chi-Hsien Lin , Jiong Wu , Ritesh Harjani , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Shawn Lin , Wolfram Sang , Avri Altman , Martin Hicks References: <20190517225420.176893-1-dianders@chromium.org> <20190517225420.176893-3-dianders@chromium.org> <20190519090642.GA2279@kunai> From: Arend Van Spriel Message-ID: <36cae1d3-f11c-3c71-3f04-23fdc74f8866@broadcom.com> Date: Mon, 20 May 2019 10:46:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190519090642.GA2279@kunai> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/19/2019 11:06 AM, Wolfram Sang wrote: > >> Let's add an API that the SDIO card drivers can call that will >> temporarily disable the auto-tuning functionality. Then we can add a >> call to this in the Broadcom WiFi driver and any other driver that >> might have similar needs. > > Can't you fix the WiFi driver to return something else than -EILSEQ > before calling mmc_request_done() to skip the retuning? Not really. mmc_request_done() is for the host controller driver so the wifi driver is not involved. Regards, Arend