Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp28148yba; Mon, 20 May 2019 04:24:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqyQ5i8RHhqaPovdd4ICVyQRvxCwd5CHBYapWmmi5pqSGE53R5+nqlDt27S6JsE5/U6ey7+P X-Received: by 2002:a63:682:: with SMTP id 124mr75608567pgg.243.1558351442697; Mon, 20 May 2019 04:24:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558351442; cv=none; d=google.com; s=arc-20160816; b=VheOxEjTnUVePrFfCMjLwp07faTMuDgN9NDBn8WAtvZDc5663+8bRyN0bFIb0bGaUy 4Voiok7MGbDcJdTNVlZE/YoGGryY5Djs8c+aVWElnaP9e9WRvFmBAdUsSoxHn9RQQvKZ Bx8zqVwzIpVnUccQPVttpfXM+9uKoY1tORt4bLOiL38Zj8uSkJJOg+w2dvOeH6CtZkFQ izLY/mTj6vk4zoYw8r/+x9G5biR0nNIVNEczoHof6ZXY3nA/HEND8eIUQg43f7wkhehO Cbho3Bse9hAFAZdSzmHohdhDlGYMgM2oky/iiPENCxtBRWLRiuZ2M59gDZve0QAx2OF0 pDoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=9rxc58tQZmjhoW6WoZbADnQeTzcPcJkRMeK2lc849iw=; b=pNP1oS/d40b3LGM5JbHNABBp1fX54Fys1Lwv2NNxxZv3sZVYFKOc3BD7VLOk4jVD5o 2WtLoPRu4FPPOOsbgB7A4DKKAR92BMOF6LVImB1duWBtrvnbCK8cKT92B17KpRdWDTNs 5KQ51dKT0fN43s/K8TvjbqU+kEDL4Hn5pvZVFZZTKGPeVjGadDc+YIHhdnGnOp2xx/ot YOWfY4kMsyPG5OjQU4KYYTkVa6FnBgf/657gq1G1qmfS1ss6/1lWwXpTbvQK8zC+9bVW 1GJnKU04ChWbnERkyDDmnYAqUeTxCtE4B2kvCqF+DyOPeQ3zwfVfRaIAXS6yYkW5mH3q UQGw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a23si17306016plm.385.2019.05.20.04.23.47; Mon, 20 May 2019 04:24:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731240AbfETIh0 (ORCPT + 99 others); Mon, 20 May 2019 04:37:26 -0400 Received: from bmailout2.hostsharing.net ([83.223.90.240]:54071 "EHLO bmailout2.hostsharing.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728889AbfETIh0 (ORCPT ); Mon, 20 May 2019 04:37:26 -0400 Received: from h08.hostsharing.net (h08.hostsharing.net [83.223.95.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.hostsharing.net", Issuer "COMODO RSA Domain Validation Secure Server CA" (not verified)) by bmailout2.hostsharing.net (Postfix) with ESMTPS id 1FCF52800BC20; Mon, 20 May 2019 10:37:24 +0200 (CEST) Received: by h08.hostsharing.net (Postfix, from userid 100393) id BE197AEB34; Mon, 20 May 2019 10:37:23 +0200 (CEST) Date: Mon, 20 May 2019 10:37:23 +0200 From: Lukas Wunner To: Daniel Vetter Cc: DRI Development , Intel Graphics Development , LKML , Daniel Vetter , David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Sean Paul , Bartlomiej Zolnierkiewicz , Hans de Goede , Yisheng Xie , linux-fbdev@vger.kernel.org Subject: Re: [PATCH 30/33] vgaswitcheroo: call fbcon_remap_all directly Message-ID: <20190520083723.xgjrocuuhwq4mcms@wunner.de> References: <20190520082216.26273-1-daniel.vetter@ffwll.ch> <20190520082216.26273-31-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190520082216.26273-31-daniel.vetter@ffwll.ch> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 20, 2019 at 10:22:13AM +0200, Daniel Vetter wrote: > --- a/drivers/video/fbdev/core/fbcon.c > +++ b/drivers/video/fbdev/core/fbcon.c > @@ -3146,16 +3146,16 @@ void fbcon_fb_unregistered(struct fb_info *info) > } > > /* called with console_lock held */ > -static void fbcon_remap_all(int idx) That comment needs to be removed as well. Not an expert on fbcon code but this looks sane to me, so in case it helps: Acked-by: Lukas Wunner Thanks, Lukas