Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp103880yba; Mon, 20 May 2019 05:46:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqw//p6VHFRqdRHjcMZRhlGmLWUDaeQjvAyvZb9mFrNisC9Wfct0PHi/bd4PuzltOA+VFIzV X-Received: by 2002:a63:2248:: with SMTP id t8mr31690028pgm.358.1558356404927; Mon, 20 May 2019 05:46:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558356404; cv=none; d=google.com; s=arc-20160816; b=nD4FZKJCPBeD3dFBliYWYjXfv2L6WTNl4x+v+KWXeYpp6rS/mYi15YKemixkuEo0P4 CA79salaJh0/cuiGYeatxh7s84F4OOwMWTjHMbF5g1Qwd/og3t/Q0Su24cJZFRDRpinf JrqaznGzclQa7BPCBFy9cC4TtYaFrXjylcPUXK5vRNbkU55hOYVaPY7xykL1dPK5t/Uy gL8kXw8qX0hFXnehvEXAkNN1xruFFVuXnCyqv2M6Xj45zAagPVXfRHiFcl6KsfZZror8 yRC2Lc7VZwgRmkI1vh3wjkdTgfrgOnqURdA+S6LyHWyidDW1CwXDZvzR8eAcJUOUcjA8 vMYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=SDm94Zz75kKs6dDJTYnOYjQHxEqHV/eyqQCc7y4brAs=; b=PDJk4uPehVjOkWFPtQvWnJgotYZF3X0gfdQGO7IE0RfZefSG8mR7MOnHVVeYLeuSMT PV+nNhpjGdxiCeZZQxdNk4CHs6LYc2sHXhdJ8yJ5T4BOp80OQwPn85O96WyaSv/y8GSf LYaEVb+vTdvHtLLiU2G+L2/psNO5AtRy81ns9lKUeS9Fb2mzd1k2NdbU/vZ5B4c7W/Ig YTXW+yLcfdQinAKuYOQFRB0gVGkddHtOUaBE1YoGc7drKiwBBD5qXpkBTKDGlBA117fV ct5co/3lqSroihc+tzqXBuLVWxix7hOYGYOisg4BVJ487TBaBY99/p3YNVrRXxy80xnY 9Isw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=z48OTGoI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cp6si18956282plb.273.2019.05.20.05.46.30; Mon, 20 May 2019 05:46:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=z48OTGoI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389511AbfETMox (ORCPT + 99 others); Mon, 20 May 2019 08:44:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:43040 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389465AbfETM11 (ORCPT ); Mon, 20 May 2019 08:27:27 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BE80521019; Mon, 20 May 2019 12:27:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558355247; bh=QKkgWnxCvEUleqodsfOqFcETT19LNPLxow/QSmRYFwM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=z48OTGoI3vbJ/upBdNeZWO12W+2c1ATWjUkmxAn1vSt/0De4lHLZvBiQrSHvZPoMB k3H9+e2InZZTKz9lhMF/rPieiPCk9tYnNcL0w6uw30s9t7/KNjhVxvqCCaURvShw9H gKpNUoieNN0+0L6uaXoNZhmAFSxVJ2V11zSu1uNU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Raul E Rangel , Jens Axboe , Adrian Hunter , Ulf Hansson Subject: [PATCH 5.0 045/123] mmc: core: Fix tag set memory leak Date: Mon, 20 May 2019 14:13:45 +0200 Message-Id: <20190520115247.735630174@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190520115245.439864225@linuxfoundation.org> References: <20190520115245.439864225@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Raul E Rangel commit 43d8dabb4074cf7f3b1404bfbaeba5aa6f3e5cfc upstream. The tag set is allocated in mmc_init_queue but never freed. This results in a memory leak. This change makes sure we free the tag set when the queue is also freed. Signed-off-by: Raul E Rangel Reviewed-by: Jens Axboe Acked-by: Adrian Hunter Fixes: 81196976ed94 ("mmc: block: Add blk-mq support") Cc: stable@vger.kernel.org Signed-off-by: Ulf Hansson Signed-off-by: Greg Kroah-Hartman --- drivers/mmc/core/queue.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/mmc/core/queue.c +++ b/drivers/mmc/core/queue.c @@ -473,6 +473,7 @@ void mmc_cleanup_queue(struct mmc_queue blk_mq_unquiesce_queue(q); blk_cleanup_queue(q); + blk_mq_free_tag_set(&mq->tag_set); /* * A request can be completed before the next request, potentially