Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp103908yba; Mon, 20 May 2019 05:46:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqzxGZv0YFC0zwPat2jNQYyVYx/G7OrhXgInuAnI5LwIpl+eRev7XHG3RJD5BO9m0YUPnGKm X-Received: by 2002:a62:ed09:: with SMTP id u9mr81616469pfh.23.1558356406595; Mon, 20 May 2019 05:46:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558356406; cv=none; d=google.com; s=arc-20160816; b=rKf6vfJ2i76Q2hO2++NTOf1ousUWjcMWfpcuO9KuQwTx460QEMXHHYbpshkdPlrYQf MtWgN+95p+Ij/oltKA0VkoxVzeLh+iLWxGQ3rtUaUrf68fjXIKiP8NK4P0mI7X5qao4h 2AMU48s4kOrYbVasHpSSd4I6RhSrK+6JvKO8Zxi8u8C/pN2CJD/dx91h+epzyjATbfcN fjGg/4OTRvgw98hrKwbkYBptrIYUkXqncm95jmc4grf4FZoFX9jwVzYejkN7sFFm6mUB puY+eeTkwjD0XREjYG7cF0zx75Egm9xg5DD+lcLDDzKq4wRS7RF45+0Yq7+Qr9UVZHDp qxqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=7CwNKZp0AyKS6zWUBM158jjBeG1bf/l446SJDZZkEYM=; b=cDQtLHHhZd00WUeyYGbnnd71iZauq2RCtPdhS/ROyJJGjfawVxoSbO8aUr39qNWOfh RrxheoQW5KIoh1WiHBHS5tYxe6CEsqTV9VQZ/PmLCPcuv1QQixmQBoqLZMgxo3yubBnI 1UwFkGtO5/CDro/sGBBS61pWi4IRPiO1oJZTbRBJ3gzIQI1biJSHUVk6ATuVnbmL2yyc aESKtOeOQcoY0wMdaCqKOWWrca5AAyra2BQEQRneXldTK+cYWtT8o2m6il/aHxuXgiSB DRV0GT67puhxr+/k7HeHp8CXPHN42YypAce9zkkiFOR7vjT/+VvE2moxk34hYWi/XGOw DBkg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vEcUgFSA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l7si16845437plt.244.2019.05.20.05.46.31; Mon, 20 May 2019 05:46:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vEcUgFSA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390539AbfETMnj (ORCPT + 99 others); Mon, 20 May 2019 08:43:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:44710 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389754AbfETM2s (ORCPT ); Mon, 20 May 2019 08:28:48 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8F97C21479; Mon, 20 May 2019 12:28:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558355328; bh=+ahlxkje3y2jyBIvC2s6nmMIj2CEAeJyiNprwZ7zUu8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vEcUgFSAjmNcqzCDiSFP3tOJqU5fJHG3UjF+DU5fK2PG4uSC8Mhn6qwshc9VhPKl2 v2d0VgSe9jqOwURkv4a74gX8Ty3xZ05BKAL8oWlv0BtiAIBvCw/q0ePKN9Z1ZcRsEG T4mKM8ZH4DCnxu9RBqwbKdyEP7cUDqnMoALNV9SQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chris Packham , Boris Brezillon , Richard Weinberger Subject: [PATCH 5.0 077/123] mtd: maps: physmap: Store gpio_values correctly Date: Mon, 20 May 2019 14:14:17 +0200 Message-Id: <20190520115249.972923357@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190520115245.439864225@linuxfoundation.org> References: <20190520115245.439864225@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chris Packham commit 64d14c6fe040361ff6aecb825e392cf97837cd9e upstream. When the gpio-addr-flash.c driver was merged with physmap-core.c the code to store the current gpio_values was lost. This meant that once a gpio was asserted it was never de-asserted. Fix this by storing the current offset in gpio_values like the old driver used to. Fixes: commit ba32ce95cbd9 ("mtd: maps: Merge gpio-addr-flash.c into physmap-core.c") Cc: Signed-off-by: Chris Packham Reviewed-by: Boris Brezillon Signed-off-by: Richard Weinberger Signed-off-by: Greg Kroah-Hartman --- drivers/mtd/maps/physmap-core.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/mtd/maps/physmap-core.c +++ b/drivers/mtd/maps/physmap-core.c @@ -132,6 +132,8 @@ static void physmap_set_addr_gpios(struc gpiod_set_value(info->gpios->desc[i], !!(BIT(i) & ofs)); } + + info->gpio_values = ofs; } #define win_mask(order) (BIT(order) - 1)