Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [RESEND PATCH] intel_th: msu: Fix unused variable warning on
 arm64 platform
To:     Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        <linux-kernel@vger.kernel.org>
References: <1558333597-63774-1-git-send-email-zhangshaokun@hisilicon.com>
 <87woilwjli.fsf@ashishki-desk.ger.corp.intel.com>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
From:   Zhangshaokun <zhangshaokun@hisilicon.com>
Message-ID: <46480fe3-8639-c6a3-4acf-e7db2a6157b5@hisilicon.com>
Date:   Mon, 20 May 2019 18:53:15 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.1.1
MIME-Version: 1.0
In-Reply-To: <87woilwjli.fsf@ashishki-desk.ger.corp.intel.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Alex,

On 2019/5/20 17:39, Alexander Shishkin wrote:
> Shaokun Zhang <zhangshaokun@hisilicon.com> writes:
> 
>> drivers/hwtracing/intel_th/msu.c: In function ‘msc_buffer_win_alloc’:
>> drivers/hwtracing/intel_th/msu.c:783:21: warning: unused variable ‘i’ [-Wunused-variable]
>>   int ret = -ENOMEM, i;
>>                      ^
>> drivers/hwtracing/intel_th/msu.c: In function ‘msc_buffer_win_free’:
>> drivers/hwtracing/intel_th/msu.c:863:6: warning: unused variable ‘i’ [-Wunused-variable]
>>   int i;
>>       ^
>> Fix this compiler warning on arm64 platform.
> 
> Thank you for taking care of this.
> 
>> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
>> ---
>>  drivers/hwtracing/intel_th/msu.c | 7 ++++++-
>>  1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/hwtracing/intel_th/msu.c b/drivers/hwtracing/intel_th/msu.c
>> index 81bb54fa3ce8..833a5a8f13ad 100644
>> --- a/drivers/hwtracing/intel_th/msu.c
>> +++ b/drivers/hwtracing/intel_th/msu.c
>> @@ -780,7 +780,10 @@ static int __msc_buffer_win_alloc(struct msc_window *win,
>>  static int msc_buffer_win_alloc(struct msc *msc, unsigned int nr_blocks)
>>  {
>>  	struct msc_window *win;
>> -	int ret = -ENOMEM, i;
>> +	int ret = -ENOMEM;
>> +#ifdef CONFIG_X86
>> +	int i;
>> +#endif
> 
> Can you factor it out into its own function? And one for the other
> memory type? So we can maybe keep it to just one #ifdef like
> 

Got it, I will update it in next version soon.

Thanks,
Shaokun

> #ifdef CONFIG_X86
> void msc_buffer_set_uc()
> { ... }
> void msc_buffer_set_wb()
> { ... }
> #else /* !X86 */
> static void msc_buffer_set_uc() {}
> static void msc_buffer_set_wb() {}
> #endif
> 
> Thanks,
> --
> Alex
> 
> .
>