Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp230310yba; Mon, 20 May 2019 07:48:16 -0700 (PDT) X-Google-Smtp-Source: APXvYqyfi9zqix30l2J3csXYApB6F+WUQ41Lfk2d9dYswyzg8M/RqvyWWD0UZAjZLSyKjYANcTNY X-Received: by 2002:a63:9548:: with SMTP id t8mr76681168pgn.256.1558363696253; Mon, 20 May 2019 07:48:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558363696; cv=none; d=google.com; s=arc-20160816; b=KzSI/Rtt22LyNThZWu6P5VjQb6LY0nAB+zC5kC4FUCeSIConkwqHnsjrkSWp0+cU6w 3+wbI3bXKGCWTh4xhIP3JuB5lK/nL2vUj4Q92UzjQNVXVNNkpNLy6C7aq1kTfMun07Vg gtjNW6a3F6t/3OCdw2G2wno8mzjB6XcjgHqABk1NUz2TAdY7PIUqYsvjZL/XSXvz55g9 I5EhUkmlACMJ8LlJKaOX2z6O9+xNkQNWyMcn51vwbI/sId2Uv1Ms8Ft2I4Wi8iG2CdPy Y80suwok2FhOnBkeOz5P26eHZsPGyHeSrTd9det0PvwTFdP2UYrDvlr5WW1vL0uAGNMt xGLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=G1u4ZppYbcoEuueSwRN5YCnorqFZq5YrL/+Ds+I8To0=; b=eoKJEmkBGmd0E0d6Es/2l09+g4XncrV4w2mLzaxuzjMno+XhLtCoQizu/lmNkRt0G8 lJAvP6o265bw41Okqw7oIDHhJC2YJMhn4WDLTikR3pznwhn4ryA2FTVE+XOSB0YsZa4W OCV7IpO5Cus6lvfGSNjRLQISPwsZQMeq9nTrLaNzoD3dFD7r3/VHRbyeMTfdeiNLIiVT u9XY8FtYu63TPRQ0NyWw8GtSxUmGL/mL/4+X+j83/NE0YMvqMFinJT6ayx4ZnoCgw9NT /QmaWQYxDCJ2lHcVxkuspsgdiVjNxG+/Kebifshp4wUgzCddM6sw3V/H3oWlTZRP6rFh MnJA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h18si17626594plr.16.2019.05.20.07.48.01; Mon, 20 May 2019 07:48:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731511AbfETLnM (ORCPT + 99 others); Mon, 20 May 2019 07:43:12 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:40720 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731432AbfETLnK (ORCPT ); Mon, 20 May 2019 07:43:10 -0400 Received: by mail-wm1-f65.google.com with SMTP id 15so8638385wmg.5 for ; Mon, 20 May 2019 04:43:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=G1u4ZppYbcoEuueSwRN5YCnorqFZq5YrL/+Ds+I8To0=; b=XccQ/PvXx0XXo0NDsU9wfqimZKU9YTas1TlpKyu+SvcbxnRQFI7+4QAQ9cFhC+qJw+ Wof2REjETIi95xve0iBqmnz1rbImyYjwxWHFWYT925aQUA6nOhgzNihO0Ioq3SgGjFFU /+E1wtI82DCG4WxtBVNkwOgGTy1nnigw/4txyrMruVhmPF3GYumxbTAdbDnD4W53DBs4 yryy5rpwjO4H4Kqo0/uECpfj/F7VQq81lxgKJmL+h8GoV5w4RcRPHHQgc7k4mPDGX74t 0hsSzyUp5Bzqo+R5DqNMbyw8xR7z6valuFTFyVIqNVxXtdC2tYU3nbmOAWaCV5XCBPp3 i6kA== X-Gm-Message-State: APjAAAU2bN70XjbjpzT5vDiAHVx40b0ZLF4mzT16p3mWOIZlE8Ot2orL toJKEfNJyqT/KDvVVL0tMHNqLA== X-Received: by 2002:a05:600c:2289:: with SMTP id 9mr27711966wmf.106.1558352588686; Mon, 20 May 2019 04:43:08 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:ac04:eef9:b257:b844? ([2001:b07:6468:f312:ac04:eef9:b257:b844]) by smtp.gmail.com with ESMTPSA id w13sm19021118wmk.0.2019.05.20.04.43.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 May 2019 04:43:08 -0700 (PDT) Subject: Re: [RFC PATCH 0/4] KVM selftests for s390x To: Thomas Huth , Christian Borntraeger , Janosch Frank , kvm@vger.kernel.org, Andrew Jones Cc: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Shuah Khan , David Hildenbrand , Cornelia Huck , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-s390@vger.kernel.org, Andrew Jones References: <20190516111253.4494-1-thuth@redhat.com> <9423ba89-b10e-5e6e-3cc8-8088f3088233@redhat.com> From: Paolo Bonzini Message-ID: <4d94124e-00f6-aa65-3a4a-bd8910480329@redhat.com> Date: Mon, 20 May 2019 13:43:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <9423ba89-b10e-5e6e-3cc8-8088f3088233@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/05/19 13:30, Thomas Huth wrote: >> No objections at all, though it would be like to have ucall plumbed in >> from the beginning. > I'm still looking at the ucall interface ... what I don't quite get yet > is the question why the ucall_type there is selectable during runtime? > > Are there plans to have test that could either use UCALL_PIO or > UCALL_MMIO? If not, what about moving ucall_init() and ucall() to > architecture specific code in tools/testing/selftests/kvm/lib/aarch64/ > and tools/testing/selftests/kvm/lib/x86_64 instead, and to remove the > ucall_type stuff again (so that x86 is hard-wired to PIO and aarch64 > is hard-wired to MMIO)? ... then I could add a DIAG-based ucall > on s390x more easily, I think. Yes, that would work. I think Andrew wanted the flexibility to use MMIO on x86, but it's not really necessary to have it. Paolo