Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp238243yba; Mon, 20 May 2019 07:57:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqzArFXvZNL2yhIyYYy6lf6pJoBvsfdnTVMSbCV1iThzWogyEqMlHa2teprDjsn9OwlemymB X-Received: by 2002:a62:68c4:: with SMTP id d187mr63407487pfc.245.1558364228228; Mon, 20 May 2019 07:57:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558364228; cv=none; d=google.com; s=arc-20160816; b=sOzqgl9vzA1lclGwzV5Mc9z4j1H5V+Lj2d1flIBnMcUwv8YB5V7Z3S5wnDjZH9XPx+ Ou1u1gyrbMBv6hwEBhmgYgdgc4Ts9qy+mjDvebLCqnHzjBQW6E5dP1VaqLt7VCVLXY3t lCfWE1E2eMHxOmd3H34U+X9mv5np65tRmabHA2YSIgEbANdchk1G4v2tAt62pH/pLcqm fIpugKsr9bok4Da4BS9p4HhAeAVUrV1ofOr+J5rRr+V7I6Ef3qcam2cUSwGsvyCcTmr2 kiar2nwEp4CbTJ8orz/8CRt4zWMWjtu+E3pIdj9SJbpGhowYF+Si8vdx0W63u0RuC1Zy pnCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Rn+qimpD8Empr/n7TT+QaGANvCarT5W26KJkGIss3f4=; b=XkHay9dBN9re62ag7ceWzbyXlA+Z5FugI0Hco1IFAVStKq3cLRMw/h1K37YY7B4aD9 QcPusbdmvIZyNtvaE1Tr6EtFxmaQWsgTBDIh5xktJ5x+DP0hqpnDWlBDt3xmDfwFSaAT HiAZHcMB9hqma2W2hVdL09KZTdERmJTxUZT0Yf6rgSCaTUcKc+PF9FDMDiApN7EKeEV3 8k9OFPqXMyzR2/EJzc6V6vwsVrOpPpwxYTLI8bdP7yNd2zHp+YZaG7Ljov4P2t1RGhHu AAj34BrAYxLckzPgVbb7SXNr/rbDOuhw00hp0x4GRhE+UByY5GNgradiGqCBCHSIlESL iX9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=gzaLH8Pb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 5si18198564pgz.231.2019.05.20.07.56.53; Mon, 20 May 2019 07:57:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=gzaLH8Pb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733136AbfETMSL (ORCPT + 99 others); Mon, 20 May 2019 08:18:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:59198 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730955AbfETMSF (ORCPT ); Mon, 20 May 2019 08:18:05 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2893C20815; Mon, 20 May 2019 12:18:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558354684; bh=yuXrqsW5AOykBoY7rVb2cfSEQJ4ZmmgCa2bNnbmJi1A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gzaLH8PbRqyMf+W2KmnQTctE54kkgOgoWtJyJvIS3qMdVpjaIAjNFTjBFCWVD1iwA WskRNbJJAZwDALqNb2yFEMCOF8kU4LLWOCCAdyNZNY1lPOV70yAa/3iP+3EKGqEjr4 zxp8+lcGMG+rddA6IsdaHMTo51zlLrcEkrbid/jM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kirill Tkhai , Theodore Tso , Jan Kara , stable@kernel.org Subject: [PATCH 4.9 28/44] ext4: actually request zeroing of inode table after grow Date: Mon, 20 May 2019 14:14:17 +0200 Message-Id: <20190520115234.494011668@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190520115230.720347034@linuxfoundation.org> References: <20190520115230.720347034@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kirill Tkhai commit 310a997fd74de778b9a4848a64be9cda9f18764a upstream. It is never possible, that number of block groups decreases, since only online grow is supported. But after a growing occured, we have to zero inode tables for just created new block groups. Fixes: 19c5246d2516 ("ext4: add new online resize interface") Signed-off-by: Kirill Tkhai Signed-off-by: Theodore Ts'o Reviewed-by: Jan Kara Cc: stable@kernel.org Signed-off-by: Greg Kroah-Hartman --- fs/ext4/ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/ext4/ioctl.c +++ b/fs/ext4/ioctl.c @@ -727,7 +727,7 @@ group_add_out: if (err == 0) err = err2; mnt_drop_write_file(filp); - if (!err && (o_group > EXT4_SB(sb)->s_groups_count) && + if (!err && (o_group < EXT4_SB(sb)->s_groups_count) && ext4_has_group_desc_csum(sb) && test_opt(sb, INIT_INODE_TABLE)) err = ext4_register_li_request(sb, o_group);