Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp363014yba; Mon, 20 May 2019 10:01:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqzCFgqLLEq7wlsbyl6IS/2/P6rvicYpXU0p2gwu/G9xEhHmj4Od8I739IdOGL6D6dsgJ+Do X-Received: by 2002:a62:36c1:: with SMTP id d184mr60266899pfa.49.1558371710456; Mon, 20 May 2019 10:01:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558371710; cv=none; d=google.com; s=arc-20160816; b=ynsvkij1g+vQ6+FUr5sB7KEF2SopIEAFYcJKCc6ckuSb3h41Xq089ncZpAixVlme0f WqWt9x/wd85BwRr01B6+3P31bOjDr16f1+5q4HlPE3RB2bmSeTll+Fs6ViTUdzYV6HsK y1KyOy34PFrecGR0lyuGIE/ZOKxwN5rH8a0fjnWSK8J6whyj6OlAyrpSLbuVWBR9ITYv e8kGcueErPvYbQlXZ9B645YwAlt1R9B1X4mzV7DvyRURv9yFtTvwRTvv6NvwGXMr9wP/ +j53ZyIMbFRZfnASho8EukA3OjMk7ENczLe5uFhv8Th3ecJaUdwpjpHHignpeYqLE6d4 x+Nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=1EHPLv5xXeZBXLCymN2sj3YPx8SVeqvd3U2cKd0fNwI=; b=A/oriUsDFVWG0sGBpjvG/p+az2KT526K21Cdm06pvGOcxPYL1a0rUHxMnKY8YCg57b IOxfhLfRPjojkgou1Ha+SgISxsRx9X13dXPpB7SBCawLmoiXaTRjaV2Bf5VzuSbD+HWZ MRze24yPJMKdfD7snepTIn9g8kSLOyMToOYNewDM1X2tnFeAvBkM99sxlGUKf2P3FV+L vcJZeBEXo3c395jZ0GCj1ukqCzVUD/3fPJ9y7qdrEdY5v7vWxdFiouSVjKEXhRSLAuX6 33yit7AjqKY6rHSzTO+nWmaETtwibcgW7f8FE3OJAMmyPu2nzhc7bhNSvL8jA2l8viAf LLUg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=XfxUl7zB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a17si20661147pfa.108.2019.05.20.10.01.34; Mon, 20 May 2019 10:01:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=XfxUl7zB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390273AbfETMbL (ORCPT + 99 others); Mon, 20 May 2019 08:31:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:47604 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389607AbfETMbJ (ORCPT ); Mon, 20 May 2019 08:31:09 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 92F7E20675; Mon, 20 May 2019 12:31:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558355469; bh=OEMSFr3H+6JQcGa5ItokfuXRFJqlplNirzzud/kCOMk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XfxUl7zB6MDtan+lB5oc267NLHjZNKz/9MOTDxkNpYhImcwI6oV1QbwaY2hqRVVCy Y1I/OrtkasDnEnEOlAblTyKgQicKREJwGYaCpEhl3dtYB3mdAsW4KRYnxqdGefsXou JGEH9CmoEtIduKD8ZDg2y/TFia3fF9OErddF7dQI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Peter Xu , Paolo Bonzini Subject: [PATCH 5.0 110/123] KVM: Fix the bitmap range to copy during clear dirty Date: Mon, 20 May 2019 14:14:50 +0200 Message-Id: <20190520115252.409038239@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190520115245.439864225@linuxfoundation.org> References: <20190520115245.439864225@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peter Xu commit 4ddc9204572c33f2eb91fbdb1d99d8078388b67d upstream. kvm_dirty_bitmap_bytes() will return the size of the dirty bitmap of the memslot rather than the size of bitmap passed over from the ioctl. Here for KVM_CLEAR_DIRTY_LOG we should only copy exactly the size of bitmap that covers kvm_clear_dirty_log.num_pages. Signed-off-by: Peter Xu Cc: stable@vger.kernel.org Fixes: 2a31b9db153530df4aa02dac8c32837bf5f47019 Signed-off-by: Paolo Bonzini Signed-off-by: Greg Kroah-Hartman --- virt/kvm/kvm_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -1251,7 +1251,7 @@ int kvm_clear_dirty_log_protect(struct k if (!dirty_bitmap) return -ENOENT; - n = kvm_dirty_bitmap_bytes(memslot); + n = ALIGN(log->num_pages, BITS_PER_LONG) / 8; if (log->first_page > memslot->npages || log->num_pages > memslot->npages - log->first_page)