Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp16052ybm; Mon, 20 May 2019 11:03:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqzurBbfrDNfKO/HWOVaoXEzgt/FEOYw/PLvYO3ZQ+GbiXaA+Tu1GvFuRwqYaGrtJr9GK2XE X-Received: by 2002:a17:902:e7:: with SMTP id a94mr52431780pla.182.1558375399504; Mon, 20 May 2019 11:03:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558375399; cv=none; d=google.com; s=arc-20160816; b=GXlQH4s9TRqG2Lz0hGf1JpEKDyDNA9b2STzxnxUWtqwjs7JPI3P9n4k8ffqRlScLSC y4IyqkK2eke/JKDpjZa8Gi0OX2kdK9npNpjL8IdUAyJ3bCnYJm5e+RuUtkEKSMP3V7sG otVl32LhqeguGDO66elNnWuO7TERR6K9wyyobEGzBN5UX+nNBGtNm7pgarPbwxV8Z/GW p0HKo82NmIgD87PT6M8wwd26gNVEHu6t8/LUeK3HqXtJ/OqeLq6bq5HHpKzEJXpxtz/Y qpTf7yjcFx5EqK8iuOqA1LuFXnz4cptZd7is9GyQiPVX+pOKzSd2b7FmJF5XZJ02dlQe b5VA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=0fhnvlvsDB95m+qFVLhQ7W8WIIsB7x3V4ptYaDVm07U=; b=aga+OYIbk08tfWQcvO+s9ISIrDqiR+YsW9j2FBoFwwuLtwWYiFCqbJx0/g3al33odR ho2ydRhEzEX1Ygm9J1nzvxnvWY9XRm+dgRrRrbt8551ZpLGfe68ui+SjzZNZKbXmT6fq eRR09DofukCQeFl4kA4RE8kBIfX+AGfkCTXWM+Yzje2tuaryT9on/qlylpFyr4gTiKPY JpW91MGp2Bjgadg32Jp/ff9sqrTIXSmoRl8P4QmC6qaOxWwpKejee0+8hNO8KdGOymhs 3LgH4VPJiH2+TP3W0T11GU7YcZnr/YgcrS4MQeCSgWvKfxwco+pmlJggqwBBuPy9ZqP+ Vu/A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r69si11873536pgr.120.2019.05.20.11.03.04; Mon, 20 May 2019 11:03:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732172AbfETNex (ORCPT + 99 others); Mon, 20 May 2019 09:34:53 -0400 Received: from smtprelay0046.hostedemail.com ([216.40.44.46]:55539 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728634AbfETNex (ORCPT ); Mon, 20 May 2019 09:34:53 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 0D1D818224BBB; Mon, 20 May 2019 13:34:52 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:69:355:379:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2551:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3868:3871:3874:4250:4321:5007:7576:9545:10004:10400:10848:11232:11658:11914:12043:12050:12683:12740:12760:12895:13069:13141:13230:13311:13357:13436:13439:14096:14097:14110:14181:14659:14721:14777:21080:21433:21451:21627:21819:30022:30054:30070:30090:30091,0,RBL:23.242.196.136:@perches.com:.lbl8.mailshell.net-62.8.0.180 64.201.201.201,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:27,LUA_SUMMARY:none X-HE-Tag: tooth67_2a5456d1fb301 X-Filterd-Recvd-Size: 2098 Received: from XPS-9350 (cpe-23-242-196-136.socal.res.rr.com [23.242.196.136]) (Authenticated sender: joe@perches.com) by omf11.hostedemail.com (Postfix) with ESMTPA; Mon, 20 May 2019 13:34:50 +0000 (UTC) Message-ID: <60717bc4cdf327ffe671c328d47c315eefd385c8.camel@perches.com> Subject: Re: [EXT] Re: [PATCH] checkpatch: add test for empty line after Fixes statement From: Joe Perches To: Michal Kalderon , "leon@kernel.org" , "apw@canonical.com" Cc: "linux-kernel@vger.kernel.org" , David Miller Date: Mon, 20 May 2019 06:34:49 -0700 In-Reply-To: References: <20190520124238.10298-1-michal.kalderon@marvell.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.1-1build1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2019-05-20 at 13:16 +0000, Michal Kalderon wrote: > > From: Joe Perches > > Sent: Monday, May 20, 2019 3:57 PM > > Subject: [EXT] Re: [PATCH] checkpatch: add test for empty line after Fixes > > statement > > > > External Email > > > > ---------------------------------------------------------------------- > > On Mon, 2019-05-20 at 15:42 +0300, Michal Kalderon wrote: > > > Check that there is no empty line after a fixes statement > > > > why? > > > This comment is given a lot on the netdev and rdma mailing lists when patches are submitted with > an empty line between Fixes: tag and SOB tags. Since "Fixes:" is just another tag and should be kept > together with the other ones. So test that all signature blocks and Fixes do not have blank lines between them instead of just the "Fixes:" line. And if there is some specific ordering required, perhaps a test for that ordering should be added as well.