Received: by 2002:a17:90a:2044:0:0:0:0 with SMTP id n62csp531938pjc; Mon, 20 May 2019 11:21:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqxUIFoKiHE1KpeFhWLGnqWx+voliceBjaGwR0R3IyhXFddcYbOpRBfKHoxgk4rihNMg+cmj X-Received: by 2002:a17:902:5e1:: with SMTP id f88mr30026389plf.226.1558376483279; Mon, 20 May 2019 11:21:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558376483; cv=none; d=google.com; s=arc-20160816; b=yLZi6nmNSnT37Fbh8cLHaObFd3u7NRTSdzTWbZWcyzYQbhf7JcwiM0er77uOP/C5wG +pM6PIeTCBhHrkC5Png09RjdJzfcGazLtNzXzAXTYrqYJxK8DRF3j7yVN/O43OgRCrJF nKUxs56zWSmEgiav2/ktgNTQ48MVOcMiu6eRoWFAsz/pbI/HmU87uUlHJDyb2sUe5XMV 9hXalpNvbESqcsXiARZoqwzoazXjaJ1ZSdiyW2hJ/BcgsfoYmCPP54kbtP6XlXDOjwVI 9D+O8ALmPomYmm8RS42gXrBNsWWUCGz4UVOWfb5DxgFucUxguLwaOFIISpUb2Usr4tcG I3Zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date:dkim-signature; bh=PX3SK8wlBrqBu7wO9d/mgUry+iQ7KlUhXOd5Ab/YVwQ=; b=Nx+go7ePGscXUiUgajuY2hDBYsxvcj+IWtLWBfIJkTsfJjdeyWVGPUnFWUW3/XHIWB q7eVaXqINQW6boYovDet9ZGEoUWAbqqDrvfrZ1wLuziFItlCyCucedR7w9hwowVmMOh9 WREU9jsuKw+tKo+CwG+4pqYd64EiASBb9Y4UNGrkQ7rrKrf0Zfng5QJqS9m3Qjc1aUpU nrL1YHQ+euOqlF5Q4iUPHAtjTy+YkUhg2hbGjC1z/w2ju657lMpA2z8ApFhZwDxVmLIa tMLw+B0WeBiO0LJ+nMoiHsIRqWIsVEGhBCuBSSbvq3F13FhEPrk83blFrCAl6013iOwG lv2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=m6r2swPC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n6si13620289pgg.213.2019.05.20.11.21.08; Mon, 20 May 2019 11:21:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=m6r2swPC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390649AbfETRSI (ORCPT + 99 others); Mon, 20 May 2019 13:18:08 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:45660 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389885AbfETRSI (ORCPT ); Mon, 20 May 2019 13:18:08 -0400 Received: by mail-pg1-f193.google.com with SMTP id i21so7073434pgi.12 for ; Mon, 20 May 2019 10:18:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=PX3SK8wlBrqBu7wO9d/mgUry+iQ7KlUhXOd5Ab/YVwQ=; b=m6r2swPC5kWUMMSAtMK4/783ntjwFjvDijgj6mgQt/YUrZSGOuM/YgVgSFWibmljXv RXfsjZnHPT3yHeamwmF0aUZwHhV0SaAOxMo1hY10visSNA8P31lITP+EKpQ/wAOI4pQY dJwKT+XBEkcG0TQmUjrzBt9O3gI4QVhWBXsiYWqg8y6onNfcvhTKN3iTdAtqj/OZ6HJO 6/wJrAlR+dg1irA6W8KYlzGHFpTl3aH08bTjYdgyLUSbmoz7vEFbdawl+n+Ou0UlTEdF db3iFpcXEAKx/iiMwpWPf5JQx5EfIbdyWWwWzeWI8KyKw/8Z0VuJlc2UWs+K7wH6p0kH Rypg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=PX3SK8wlBrqBu7wO9d/mgUry+iQ7KlUhXOd5Ab/YVwQ=; b=lSdKMX8r74SptafdNgm8+EiQG42FPL01IipdOOow+oVgHhMH4Q8tpMBUYUAm/BsCFG pVh1g6h3pI+GGYRu8KK4b3P8J9S5nzmBPG58p5AFr5/fyJ560RBeRxir8RaGEUdtSbhc pWMHMgVyMVyWfIv1oXyeyvTg/lqYNOY22pM/tpdgpltwb+vVqP56nqqYgd4GK0Crn4vu 4mdh0NjzmYpskVY85IgxHC/vr+4T5MxtcJqe+mc/jgl40Cfz/yyf5S+Hj1MtJrDqgiVT bL2IhsVpcL7u7TeimZjImDzcVhjRtTFtXVhyWvrNmizkM1ptceefjn449YTD+ArG4OU6 gFXA== X-Gm-Message-State: APjAAAUZtB5pmgQbArNY6/mYY6+XJ9Z99Ma/WjY2mKk+Rs93kGYxxKNy pYZNE+Q+FZh1EjaEazU5X3BUbQ== X-Received: by 2002:a65:5886:: with SMTP id d6mr76297081pgu.295.1558372687639; Mon, 20 May 2019 10:18:07 -0700 (PDT) Received: from [2620:15c:17:3:3a5:23a7:5e32:4598] ([2620:15c:17:3:3a5:23a7:5e32:4598]) by smtp.gmail.com with ESMTPSA id s134sm28571578pfc.110.2019.05.20.10.18.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 20 May 2019 10:18:06 -0700 (PDT) Date: Mon, 20 May 2019 10:18:05 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Qian Cai cc: akpm@linux-foundation.org, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, catalin.marinas@arm.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH] slab: skip kmemleak_object in leaks_show() In-Reply-To: <20190514144741.39460-1-cai@lca.pw> Message-ID: References: <20190514144741.39460-1-cai@lca.pw> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 14 May 2019, Qian Cai wrote: > Running tests on a debug kernel will usually generate a large number of > kmemleak objects. > > # grep kmemleak /proc/slabinfo > kmemleak_object 2243606 3436210 ... > > As the result, reading /proc/slab_allocators could easily loop forever > while processing the kmemleak_object cache and any additional freeing or > allocating objects will trigger a reprocessing. To make a situation > worse, soft-lockups could easily happen in this sitatuion which will > call printk() to allocate more kmemleak objects to guarantee a livelock. > > Since kmemleak_object has a single call site (create_object()), there > isn't much new information compared with slabinfo. Just skip it. > > Signed-off-by: Qian Cai I assume this is now obsolete since commit 7878c231dae0 ("slab: remove /proc/slab_allocators").