Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Jon Maloy <jon.maloy@ericsson.com>
To:     David Miller <davem@davemloft.net>,
        "hujunwei4@huawei.com" <hujunwei4@huawei.com>
CC:     "ying.xue@windriver.com" <ying.xue@windriver.com>,
        "willemdebruijn.kernel@gmail.com" <willemdebruijn.kernel@gmail.com>,
        "sfr@canb.auug.org.au" <sfr@canb.auug.org.au>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "tipc-discussion@lists.sourceforge.net" 
        <tipc-discussion@lists.sourceforge.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "mingfangsen@huawei.com" <mingfangsen@huawei.com>
Subject: RE: [PATCH v4] tipc: fix modprobe tipc failed after switch order of
 device registration
Thread-Topic: [PATCH v4] tipc: fix modprobe tipc failed after switch order of
 device registration
Thread-Index: AQHVDtd4uLOxtiXJT0+923RTkrVFi6Z0Sg8AgAAAktA=
Date:   Mon, 20 May 2019 17:49:50 +0000
Message-ID: <BL0PR1501MB20037513418B10ECC341834E9A060@BL0PR1501MB2003.namprd15.prod.outlook.com>
References: <624f5be3-12b4-cbd4-39e2-5419b976624b@huawei.com>
 <20190520.104554.602275142720021716.davem@davemloft.net>
In-Reply-To: <20190520.104554.602275142720021716.davem@davemloft.net>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: ericsson.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 74c5a4ea-82a0-4fba-4f44-08d6dd4b8ec5
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2019 17:49:50.4866
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR1501MB2147
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Reviewed and tested. I found no problems with this.

Reviewed-by: Jon Maloy <jon.maloy@ericsson.com>


> -----Original Message-----
> From: netdev-owner@vger.kernel.org <netdev-owner@vger.kernel.org>
> On Behalf Of David Miller
> Sent: 20-May-19 13:46
> To: hujunwei4@huawei.com
> Cc: Jon Maloy <jon.maloy@ericsson.com>; ying.xue@windriver.com;
> willemdebruijn.kernel@gmail.com; sfr@canb.auug.org.au;
> netdev@vger.kernel.org; tipc-discussion@lists.sourceforge.net; linux-
> kernel@vger.kernel.org; mingfangsen@huawei.com
> Subject: Re: [PATCH v4] tipc: fix modprobe tipc failed after switch order=
 of
> device registration
>=20
> From: hujunwei <hujunwei4@huawei.com>
> Date: Mon, 20 May 2019 14:43:59 +0800
>=20
> > From: Junwei Hu <hujunwei4@huawei.com>
> >
> > Error message printed:
> > modprobe: ERROR: could not insert 'tipc': Address family not supported
> > by protocol.
> > when modprobe tipc after the following patch: switch order of device
> > registration, commit 7e27e8d6130c
> > ("tipc: switch order of device registration to fix a crash")
> >
> > Because sock_create_kern(net, AF_TIPC, ...) called by
> > tipc_topsrv_create_listener() in the initialization process of
> > tipc_init_net(), so tipc_socket_init() must be execute before that.
> > Meanwhile, tipc_net_id need to be initialized when sock_create()
> > called, and tipc_socket_init() is no need to be called for each namespa=
ce.
> >
> > I add a variable tipc_topsrv_net_ops, and split the
> > register_pernet_subsys() of tipc into two parts, and split
> > tipc_socket_init() with initialization of pernet params.
> >
> > By the way, I fixed resources rollback error when tipc_bcast_init()
> > failed in tipc_init_net().
> >
> > Fixes: 7e27e8d6130c ("tipc: switch order of device registration to fix
> > a crash")
> > Signed-off-by: Junwei Hu <hujunwei4@huawei.com>
> > Reported-by: Wang Wang <wangwang2@huawei.com>
> > Reported-by: syzbot+1e8114b61079bfe9cbc5@syzkaller.appspotmail.com
> > Reviewed-by: Kang Zhou <zhoukang7@huawei.com>
> > Reviewed-by: Suanming Mou <mousuanming@huawei.com>
>=20
> Applied.