Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp80230ybm; Mon, 20 May 2019 12:14:44 -0700 (PDT) X-Google-Smtp-Source: APXvYqxx2ST1eEYmGhR9c+gPp+AGrllpyKXAsVW5uh7XHeHfNbPMV4DBMl6m97GsI72EzzTEC5xe X-Received: by 2002:a17:902:322:: with SMTP id 31mr64755666pld.204.1558379684691; Mon, 20 May 2019 12:14:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558379684; cv=none; d=google.com; s=arc-20160816; b=qD90ym176fMfR5449UX9rRUtoqWqSYYZgZhNevzcrD24g4PDtDeNniGup4Oi2ZVrm2 w8dITVSUIqhzVXUCdJlLdPa/kh85C3XqMqb7zTHCbTtNXG3TLJ2kP66a4EKd9HAAiwNM B+b8vX9vpDe9EoiXfuM8XAh91gs5x1y2EVSskjwjZ/JyZfINH9ge3FPSYkkqwtuT0DnK V420zuZGaVukPhF2lKxlBbFkWJ23Zn9DGKAoSGvLaZCTJ3+kyq3oB1biit3tLE9OcHJQ J7cLLUMXUBlVIHtDekl5MXiT5x3i4nQEBQNuXeJiY0oGhQAUGruwV5SSdwai/dhlYbwW 8Obw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=V9IWUpC+03NIxUX0v9oOnzOeHSiPA06+IwGMfjihDKU=; b=Y3xO6mPaJoZLE1hYxLryAs4U2M+VbhJB0XWM84XTY1ODj6kdcbks8Zpg0sgycGT2PA VQg8BvPUQpP030lPbD6xH6IJPb0hkEVKD2FXoBtsgxj+JHUO8d9burUVCnC6iRYyLfnD jqZjjhBg/Su46lr+hDo7HcW94x5bXKK6B6bZ57dJgWWFC5GAsJM7iLF9TqfIAA4UlNOg 7m77KVJw1A3QU2ybNRfp2QHizVosQCs3OxAVTCnlQV9YOHF6n+Gg7r6UzHPL7aPe9HiZ CvXI2Z8CftKVRN7VsCfnDoofkgrjqgRStImhggV/j15V12lxEUqq7FVLj7FitQ6vY8v0 vzIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=RdCTxd1K; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v21si17634200pgb.560.2019.05.20.12.14.29; Mon, 20 May 2019 12:14:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=RdCTxd1K; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726394AbfETTMM (ORCPT + 99 others); Mon, 20 May 2019 15:12:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:47712 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725536AbfETTMM (ORCPT ); Mon, 20 May 2019 15:12:12 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2F23D20656; Mon, 20 May 2019 19:12:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558379531; bh=E8pMuiwfZgjxTLRmJMgwxsXlsA2mXiO98wkkgNNvwlg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RdCTxd1KM+wLYnt0A36WyDCg/zX+DJMto7nraVMOHwFmahuKoaVnwTaFRNM+R8Xnc 6R2SC41yVXOR7hxCmpe0/8aSXiW+hY9Ui6F8o5xUWjR01XPtxQpXQ5x2wii9FW3DBx zZ4Z8ZTqdPNu46Dy6+eKdgy6d1iI+ctg7Qpi7NaM= Date: Mon, 20 May 2019 21:12:09 +0200 From: Greg KH To: Liming Sun Cc: Andy Shevchenko , Darren Hart , Vadim Pasternak , David Woods , "platform-driver-x86@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v5 1/2] platform/mellanox: Add bootctl driver for Mellanox BlueField Soc Message-ID: <20190520191209.GA29776@kroah.com> References: <0b74e9ad12360b56bc0a3c2ca972798c424f2610.1548790896.git.lsun@mellanox.com> <1558115345-32476-1-git-send-email-lsun@mellanox.com> <20190520155658.GA14165@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 20, 2019 at 06:07:44PM +0000, Liming Sun wrote: > > > +static struct platform_driver mlxbf_bootctl_driver = { > > > + .probe = mlxbf_bootctl_probe, > > > + .driver = { > > > + .name = "mlxbf-bootctl", > > > + .groups = mlxbf_bootctl_groups, > > > + .acpi_match_table = mlxbf_bootctl_acpi_ids, > > > > Why is an acpi driver a platform driver? Isn't there a "real" acpi > > driver interface you should be tieing into instead? > > > > Only use a platform driver as an absolute last resort. I don't think > > that is the case here. > > The driver is trying to configure boot-swapping and display secure state, > and is defined/initiated in ACPI table in UEFI. It seems a little hard to > categorize this driver to any existing subsystem. Any suggestion > where it might be a better fit (like drivers/misc, drivers/firmware, etc)? > Please correct me if I misunderstand the comments. Thanks!. The comment was asking why an acpi driver is a platform driver, but then I went and looked now at a bunch of acpi drivers, and they all are platform drivers :( Anyway, drivers/acpi/ seems like the best place for this file, right? thanks, greg k-h