Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 21 May 2019 00:14:28 -0400 (EDT)
From:   Pankaj Gupta <pagupta@redhat.com>
To:     Jane Chu <jane.chu@oracle.com>
Cc:     n-horiguchi@ah.jp.nec.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org
Message-ID: <255137178.29997735.1558412068338.JavaMail.zimbra@redhat.com>
In-Reply-To: <1558403523-22079-1-git-send-email-jane.chu@oracle.com>
References: <1558403523-22079-1-git-send-email-jane.chu@oracle.com>
Subject: Re: [PATCH v2] mm, memory-failure: clarify error message
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Thread-Topic: mm, memory-failure: clarify error message
Thread-Index: 1DbEf0kdw7K8egROywjW6H/tEghkdQ==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> Some user who install SIGBUS handler that does longjmp out
> therefore keeping the process alive is confused by the error
> message
>   "[188988.765862] Memory failure: 0x1840200: Killing
>    cellsrv:33395 due to hardware memory corruption"
> Slightly modify the error message to improve clarity.
> 
> Signed-off-by: Jane Chu <jane.chu@oracle.com>
> ---
>  mm/memory-failure.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> index fc8b517..c4f4bcd 100644
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -216,7 +216,7 @@ static int kill_proc(struct to_kill *tk, unsigned long
> pfn, int flags)
>          short addr_lsb = tk->size_shift;
>          int ret;
>  
> -        pr_err("Memory failure: %#lx: Killing %s:%d due to hardware memory
> corruption\n",
> +        pr_err("Memory failure: %#lx: Sending SIGBUS to %s:%d due to hardware
> memory corruption\n",
>                  pfn, t->comm, t->pid);
>  
>          if ((flags & MF_ACTION_REQUIRED) && t->mm == current->mm) {
> --
> 1.8.3.1

This error message is helpful.

Acked-by: Pankaj Gupta <pagupta@redhat.com>

> 
> _______________________________________________
> Linux-nvdimm mailing list
> Linux-nvdimm@lists.01.org
> https://lists.01.org/mailman/listinfo/linux-nvdimm
>