Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp519166ybm; Mon, 20 May 2019 21:55:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqy0o6q1xlH87ru4ds8iRGBU4PjhQ1V8BXhGMYr0TffDVZdtav/XnLTOeYb+nwLOrHsIlcCR X-Received: by 2002:a65:418d:: with SMTP id a13mr39382111pgq.332.1558414533926; Mon, 20 May 2019 21:55:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558414533; cv=none; d=google.com; s=arc-20160816; b=GGfHBoaOLYQTxMPgtW/oOymyiXFlG9Iyh/KXLEQoOxEQ4y5lbODWPbr584qaQemuD0 SzziHN9EfSbQUouWvqpQOAJyKX7jFZPxMTMOUPi8KDXRr5uCdgwsuwqYCWaKzyNU2w5P Re3Ly7aqoAmtJm45I2wBPVnQqprkCy16hX4XQEpj1sRTD0EyuYUEmRWHSs3CQM+Xc/1d farG6KrTwopSFAe9S8+uAaN0Fo0KD0ppwFbiN5lS98YvuMELVjuPW6fzHtqdsTA0gT6f 7n321SjmKX86P4FhvEfHsegQOnOt11nngJIAojTzoTqS+JEbylk/wzbVDZub9YLa9TP+ 45cQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=AKmR5B5S0qq8tGuHHmSOEPObaYYJM0kSBVRLE/9QL+Q=; b=yJkSKVOmAFHOG/jPN5E1X+R51ApP6IXoNQ3D8atWbObBafl+Xw2TYVyI9A2+AhQtE0 MG8liymgnJC6jbY2yXVuWStTOo2q2q9USQ69cBVXAGKYTCnWEdsWTFU4ApkpDeRncPgZ +LJ5ZFldLbcB0HBAiuJwhsfJsJ6p7y+uZRZsq1EKy+c5kRRMyWf1np4IjTPqys3pSl2+ IbiYWNWEVDnnveflKE9KDYRkXDR9/jgba+oT9oMJmBM3GsnN/MhoxhIJ40wr11nocDLg uznGiH1R1vu9M5tl2oFWsdpWCJ9OyxT/KIIB2f7tXJxGgZkwFIUBaln1rQw9TYRb1uio Takw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a17si22412516pfa.108.2019.05.20.21.55.19; Mon, 20 May 2019 21:55:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727925AbfEUExv (ORCPT + 99 others); Tue, 21 May 2019 00:53:51 -0400 Received: from smtp.nue.novell.com ([195.135.221.5]:45435 "EHLO smtp.nue.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727882AbfEUExt (ORCPT ); Tue, 21 May 2019 00:53:49 -0400 Received: from emea4-mta.ukb.novell.com ([10.120.13.87]) by smtp.nue.novell.com with ESMTP (TLS encrypted); Tue, 21 May 2019 06:53:48 +0200 Received: from linux-r8p5.suse.de (nwb-a10-snat.microfocus.com [10.120.13.201]) by emea4-mta.ukb.novell.com with ESMTP (TLS encrypted); Tue, 21 May 2019 05:53:19 +0100 From: Davidlohr Bueso To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, willy@infradead.org, mhocko@kernel.org, mgorman@techsingularity.net, jglisse@redhat.com, ldufour@linux.vnet.ibm.com, dave@stgolabs.net, Davidlohr Bueso Subject: [PATCH 11/14] ipc: teach the mm about range locking Date: Mon, 20 May 2019 21:52:39 -0700 Message-Id: <20190521045242.24378-12-dave@stgolabs.net> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20190521045242.24378-1-dave@stgolabs.net> References: <20190521045242.24378-1-dave@stgolabs.net> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Conversion is straightforward, mmap_sem is used within the the same function context most of the time. No change in semantics. Signed-off-by: Davidlohr Bueso --- ipc/shm.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/ipc/shm.c b/ipc/shm.c index ce1ca9f7c6e9..3666fa71bfc2 100644 --- a/ipc/shm.c +++ b/ipc/shm.c @@ -1418,6 +1418,7 @@ COMPAT_SYSCALL_DEFINE3(old_shmctl, int, shmid, int, cmd, void __user *, uptr) long do_shmat(int shmid, char __user *shmaddr, int shmflg, ulong *raddr, unsigned long shmlba) { + DEFINE_RANGE_LOCK_FULL(mmrange); struct shmid_kernel *shp; unsigned long addr = (unsigned long)shmaddr; unsigned long size; @@ -1544,7 +1545,7 @@ long do_shmat(int shmid, char __user *shmaddr, int shmflg, if (err) goto out_fput; - if (down_write_killable(¤t->mm->mmap_sem)) { + if (mm_write_lock_killable(current->mm, &mmrange)) { err = -EINTR; goto out_fput; } @@ -1564,7 +1565,7 @@ long do_shmat(int shmid, char __user *shmaddr, int shmflg, if (IS_ERR_VALUE(addr)) err = (long)addr; invalid: - up_write(¤t->mm->mmap_sem); + mm_write_unlock(current->mm, &mmrange); if (populate) mm_populate(addr, populate); @@ -1625,6 +1626,7 @@ COMPAT_SYSCALL_DEFINE3(shmat, int, shmid, compat_uptr_t, shmaddr, int, shmflg) */ long ksys_shmdt(char __user *shmaddr) { + DEFINE_RANGE_LOCK_FULL(mmrange); struct mm_struct *mm = current->mm; struct vm_area_struct *vma; unsigned long addr = (unsigned long)shmaddr; @@ -1638,7 +1640,7 @@ long ksys_shmdt(char __user *shmaddr) if (addr & ~PAGE_MASK) return retval; - if (down_write_killable(&mm->mmap_sem)) + if (mm_write_lock_killable(mm, &mmrange)) return -EINTR; /* @@ -1726,7 +1728,7 @@ long ksys_shmdt(char __user *shmaddr) #endif - up_write(&mm->mmap_sem); + mm_write_unlock(mm, &mmrange); return retval; } -- 2.16.4