Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp594504ybm; Mon, 20 May 2019 23:37:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqynXy8YXyvgayl8KeUkS4d6F46iE1JNS1bjobDq8jlhOW014tAQ3NN721TeyANIsizkR8zx X-Received: by 2002:a65:4907:: with SMTP id p7mr79309638pgs.288.1558420662947; Mon, 20 May 2019 23:37:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558420662; cv=none; d=google.com; s=arc-20160816; b=lhevMFTOyUdXgwh/6Nfr5A6bTHoThBua1WqBdKml9lGFlA7PndSGuahcf/ROnO/q5R F7Ou1YapRi/GpDpgCbsb/VOhvf50HKzmbMksBgWThetd4XPqI0Na9sWQ9eoGGdnz4R2u RXdwsSrjfL7Z1coVkORVmiHV5SfBIB69Vs0kCALgTz92H/lf4U3ju5gaDbZ8zEe9J8R9 EH1hX2CLaB/8ltMxonvsFB2BVl0ElxvNYrTVfSlZvptOS4v0rdu7uvMG2A+VY5aCxgyx HuIEONYwwy5dh9pa/RoQHqaoMlDM9JOnt4BIBOCRUVzOmEyYZQpUFAOlnrwOWlYrO8Fz SKkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=y2HthqbKJ5tpIQEWIxiqJg+rxHqmp9am5kD1f26lsGM=; b=NTM99mVbWuZlT3kPtXVAIkXrZRVT4ZlFbhPBf2G/FSG5gs3OhtP6ZqPDho742SsDFZ 2kVmXyGi98v3b57+QHYlbtIpIy97m1MbudAi4NBVa51H52Ajkz1tTQtRmCChyabJNx8M UnIvoLwlH2KOxBP/uEl3vbIdIvqkIZlZduCxbNKizlDfK2DIGronoGRDTHLn/qTPgWiF 23udZeT8eO5E6KTFIRq/gdjDjx5NWgd3eWAyiTP837E4KwsdNsZa78dXD8AdmEG4liuP dbvnZuSYGblIB/BUhPIKB6a5R+O+8DO/NT4b8/4Vdb8Ba6dJpYC5oNF+F92Hm9cJnpF2 cjzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=r+RQQXmP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l4si20326248plb.305.2019.05.20.23.37.28; Mon, 20 May 2019 23:37:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=r+RQQXmP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728028AbfEUGfw (ORCPT + 99 others); Tue, 21 May 2019 02:35:52 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:43994 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725835AbfEUGfw (ORCPT ); Tue, 21 May 2019 02:35:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=y2HthqbKJ5tpIQEWIxiqJg+rxHqmp9am5kD1f26lsGM=; b=r+RQQXmPtMb9GvZG+TsBzrBlz N0EIkBZvrgxm+kw+U8wNUgd7iL9+WhQ14Qwf/evHOLeYF3ogmE39f5blqOI+LuTTyhsxWO1/rCKKv /UB5XtWSjObMUM60A4jsZDRyi0TVSzzrluMlCWFZ7nyWa1AGoA5FMehOkZr7b8QttqMOSTvjGQkaY 2zFCntwYULG4h9cZIWhjqUnLmLkg5yXtmmSYJmNI3dTYdcrgUOQPnp9eqQ6TRpz4zl6vNTCyhIHDZ vStEx8BOOTR5uzOC/VL8MW1uwtbCQ9+qRe52n3rW3ecr9iOq2vLidiTQUamwoys16XsO6NIxFU8UP 3jmK4qX6A==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1hSyNL-00052s-Kj; Tue, 21 May 2019 06:35:51 +0000 Date: Mon, 20 May 2019 23:35:51 -0700 From: Christoph Hellwig To: Paul Walmsley Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Paul Walmsley , Wesley Terpstra Subject: Re: [PATCH] riscv: include generic support for MSI irqdomains Message-ID: <20190521063551.GA5959@infradead.org> References: <20190520182528.10627-1-paul.walmsley@sifive.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190520182528.10627-1-paul.walmsley@sifive.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 20, 2019 at 11:25:28AM -0700, Paul Walmsley wrote: > Some RISC-V systems include PCIe host controllers that support PCIe > message-signaled interrupts. For this to work on Linux, we need to > enable PCI_MSI_IRQ_DOMAIN and define struct msi_alloc_info. Support > for the latter is enabled by including the architecture-generic msi.h > include. > > Based on a patch from Wesley Terpstra : > > https://github.com/riscv/riscv-linux/commit/7d55f38fb79f459d2e88bcee7e147796400cafa8 > > Signed-off-by: Paul Walmsley > Signed-off-by: Paul Walmsley > Cc: Wesley Terpstra Well, this is very much Wes' patch as-is. It should probably be attributed to him and you should ask for his signoff. Otherwise this looks fine: Reviewed-by: Christoph Hellwig