Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp607205ybm;
        Mon, 20 May 2019 23:55:29 -0700 (PDT)
X-Google-Smtp-Source: APXvYqyFPa3ustq9taHDdJE0hgAg8AitJ/4kotVV27CBgXEg+YjnQt3Jl2mpxBiC740ThhikcoQm
X-Received: by 2002:a65:41c6:: with SMTP id b6mr15676982pgq.399.1558421729758;
        Mon, 20 May 2019 23:55:29 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1558421729; cv=none;
        d=google.com; s=arc-20160816;
        b=jFSOeM8GpKjupUNo1gM8qipLN/rH5kJKuy0LTgldMUbwlmlbUl2+PYs19ENPmqzj5H
         xVCXrmn3c3IyVexoxGNMS4diHTs4VY+Od3Ao9DcZU8T0QymnRvlJfSkFbA8N58JH79Bl
         fdbaSxx4XtABJ5k0PWuxC9l3L+lCqkQnd1fRKuTpm9YUwpKWdTT4JsT/zM2xbPNyTxjP
         svLbXg2tIdbEN8doxfb7NKVEBnsFHwT6uN6hztS2sQYofv1GUDQK/Z8FEWXprzaOHa3j
         gaqwh5SxJNTxARYQD0szuaU2cbLg4hE3fR+MIjlCsuSAQgnP98SPF2ULA/HXQ7pEKsY8
         N8Dg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date;
        bh=VYMtcr0LiZIn2ch5d+97ok8AzUXmR836hf6319sddjk=;
        b=LNz6Ntr0k3yFM7TPSKKdxhQ1lVeFOnFLIF+KseuRvtam/+92/XGba3TE1yZ/zIK90N
         hPRJtybGYicYgc9oIHiTWSUNTBtdbyRDVv1rwHCOSeGUne+xAX4BUhwPmwWHWXWr0uqM
         VpqFFuuz2yAZzsco9CoxiHozoLUew2xexCuG+qIb3OeXcP9jQfE7eaB0KeS8B/q2B5Cp
         EOOm/QxFWSVSJct5f5Duya4MSkK5B0G20Dkx2Nr/9v9PU11HmDlL906JxGXpBgfgIIh7
         plnBYTbp4W8b3TPNajej2UmSQhBIc48MdHMwjiU1W9AWOpznVw1nsGTDM1sOG5yCv0xW
         DMYg==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id s207si12539899pfs.119.2019.05.20.23.55.15;
        Mon, 20 May 2019 23:55:29 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726841AbfEUGyJ (ORCPT <rfc822;uzarths@gmail.com> + 99 others);
        Tue, 21 May 2019 02:54:09 -0400
Received: from verein.lst.de ([213.95.11.211]:57794 "EHLO newverein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1725920AbfEUGyI (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 21 May 2019 02:54:08 -0400
Received: by newverein.lst.de (Postfix, from userid 2407)
        id 2BBDE68B05; Tue, 21 May 2019 08:53:47 +0200 (CEST)
Date:   Tue, 21 May 2019 08:53:46 +0200
From:   Christoph Hellwig <hch@lst.de>
To:     xiaolinkui <xiaolinkui@kylinos.cn>
Cc:     hch@lst.de, sagi@grimberg.me, linux-nvme@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme: target: use struct_size() in kmalloc()
Message-ID: <20190521065346.GG30402@lst.de>
References: <1558076615-8576-1-git-send-email-xiaolinkui@kylinos.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1558076615-8576-1-git-send-email-xiaolinkui@kylinos.cn>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Looks ok to me, although for a fixed size argument the whole overflow
detection thing in struct_size() is rather pointless..