Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp633139ybm; Tue, 21 May 2019 00:28:29 -0700 (PDT) X-Google-Smtp-Source: APXvYqybW0onFjq5fKrgXJ46cm+VLB+qceePg8LmhsbRm8BO8SnpcUxvlQOmDMeuXisOdr2v7mbz X-Received: by 2002:aa7:8c48:: with SMTP id e8mr86083803pfd.80.1558423709169; Tue, 21 May 2019 00:28:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558423709; cv=none; d=google.com; s=arc-20160816; b=eZffonMPqBcTzbaWMO/l7iwMoe5tCQ/qDqNkj5PXJ2qGcb0DcSvSHXPLX1YFuB1ia2 v+qepX6WHWdyT5JSwD6tJNTY+qiKzgYg9/GmyK/xs++fVcgtTZ2rlZa77TymG1nvG83T le1vbEh72kKlfmQ9z2F+5k1tchfcAkn90zOdLsxd4Eg4tqare6go7pzdv7cF4DONyfiv TaSCOu5hzZbaApFLCyqvY6RLgoFwzvj9FIHiDP8du7cTNgXTRl2PjsYLy626+GZ6L57B dQL7OyNizUPmOfdKkm+riLcF/vIlTbcVSr6jxHgqqa/4OaojU68U5SAlOhB6oo4e1+Bn BfwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=kL1Jet1FaWbUGjHWDOG9QXmPfv3DEYQ7j5yeQ1NwIrk=; b=L7YM/vAo8LT0j3XHtcEnUW9keiEhSTA3xmpt2xuSlcfySqj+mf+bqjhsnyIlFPmfnN VSha03+leUm1Swo3NsOUyRBkMOAH96T7w4h+KuNEdJV+0cLMb444mZ8ZHZvGDiejJdGL WZHb/Jo6gWt05b9v3UWyDt8/Zn7kbkJruMaX084G+dXfYudcDQw9eVbySPzD2MGs15zn CuR5/u+TL6DgdoIX7kibovPnro7s5wdCmpLWmMtjnWo3K7FqHHIR7zBmCZnK13p5uFXo 4rr0DeiFieMLeB1YID8aWCbI4ssg11yaOmH8/BM1zqzE6QZ+VqgxuWEA6vZmbi16aKED 9DlA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q11si20181298pgf.519.2019.05.21.00.28.14; Tue, 21 May 2019 00:28:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726898AbfEUH0y (ORCPT + 99 others); Tue, 21 May 2019 03:26:54 -0400 Received: from lhrrgout.huawei.com ([185.176.76.210]:32959 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725997AbfEUH0y (ORCPT ); Tue, 21 May 2019 03:26:54 -0400 Received: from LHREML714-CAH.china.huawei.com (unknown [172.18.7.107]) by Forcepoint Email with ESMTP id A6F2ABF97D3015593510; Tue, 21 May 2019 08:26:52 +0100 (IST) Received: from [10.220.96.108] (10.220.96.108) by smtpsuk.huawei.com (10.201.108.37) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 21 May 2019 08:26:45 +0100 Subject: Re: [PATCH 3/4] ima: don't ignore INTEGRITY_UNKNOWN EVM status To: Mimi Zohar , , CC: , , , , , References: <20190516161257.6640-1-roberto.sassu@huawei.com> <20190516161257.6640-3-roberto.sassu@huawei.com> <1558387212.4039.77.camel@linux.ibm.com> From: Roberto Sassu Message-ID: Date: Tue, 21 May 2019 09:26:53 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <1558387212.4039.77.camel@linux.ibm.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.220.96.108] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/20/2019 11:20 PM, Mimi Zohar wrote: > On Thu, 2019-05-16 at 18:12 +0200, Roberto Sassu wrote: >> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt >> index 52e6fbb042cc..80e1c233656b 100644 >> --- a/Documentation/admin-guide/kernel-parameters.txt >> +++ b/Documentation/admin-guide/kernel-parameters.txt >> @@ -1588,6 +1588,9 @@ >> Format: { "off" | "enforce" | "fix" | "log" } >> default: "enforce" >> >> + ima_appraise_req_evm >> + [IMA] require EVM for appraisal with file digests. > > As much as possible we want to limit the number of new boot command > line options as possible.  Is there a reason for not extending > "ima_appraise=" with "require-evm" or "enforce-evm"? ima-appraise= can be disabled with CONFIG_IMA_APPRAISE_BOOTPARAM, which probably is done when the system is in production. Should I allow to use ima-appraise=require-evm even if CONFIG_IMA_APPRAISE_BOOTPARAM=n? Thanks Roberto -- HUAWEI TECHNOLOGIES Duesseldorf GmbH, HRB 56063 Managing Director: Bo PENG, Jian LI, Yanli SHI