Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 21 May 2019 10:47:34 +0300
From:   Pekka Paalanen <ppaalanen@gmail.com>
To:     Daniel Vetter <daniel@ffwll.ch>
Cc:     Eric Anholt <eric@anholt.net>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/doc: Document expectation that userspace review
 looks at kernel uAPI.
Message-ID: <20190521104734.2d8853ac@eldfell.localdomain>
In-Reply-To: <20190424193636.GU9857@phenom.ffwll.local>
References: <20190424185617.16865-1-eric@anholt.net>
        <20190424185617.16865-2-eric@anholt.net>
        <20190424193636.GU9857@phenom.ffwll.local>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 boundary="Sig_/OliU07hw75zzQ=tC8_AG_Hi"; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--Sig_/OliU07hw75zzQ=tC8_AG_Hi
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

On Wed, 24 Apr 2019 21:36:36 +0200
Daniel Vetter <daniel@ffwll.ch> wrote:

> On Wed, Apr 24, 2019 at 11:56:17AM -0700, Eric Anholt wrote:
> > The point of this review process is that userspace using the new uAPI
> > can actually live with the uAPI being provided, and it's hard to know
> > that without having actually looked into a kernel patch yourself.
> >=20
> > Signed-off-by: Eric Anholt <eric@anholt.net>
> > Suggested-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > ---
> >  Documentation/gpu/drm-uapi.rst | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >=20
> > diff --git a/Documentation/gpu/drm-uapi.rst b/Documentation/gpu/drm-uap=
i.rst
> > index 8e5545dfbf82..298424b98d99 100644
> > --- a/Documentation/gpu/drm-uapi.rst
> > +++ b/Documentation/gpu/drm-uapi.rst
> > @@ -85,7 +85,9 @@ leads to a few additional requirements:
> >  - The userspace side must be fully reviewed and tested to the standard=
s of that
> >    userspace project. For e.g. mesa this means piglit testcases and rev=
iew on the
> >    mailing list. This is again to ensure that the new interface actuall=
y gets the
> > -  job done.
> > +  job done.  The userspace-side reviewer should also provide at least =
an
> > +  Acked-by on the kernel uAPI patch indicating that they've looked at =
how the
> > +  kernel side is implementing the new feature being used. =20
>=20
> Answers a question that just recently came up on merging new kms
> properties.
>=20
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Hi,

for the record, I personally will not be able to provide such Acked-by
tag according to kernel review rules, because I am completely unfamiliar
with kernel DRM internals and cannot review kernel code at all. This
might make people expecting Weston to prove their uAPI disappointed,
since there are very few Weston reviewers available.

If you meant something else, please word it to that you actually meant.


Thanks,
pq

--Sig_/OliU07hw75zzQ=tC8_AG_Hi
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEJQjwWQChkWOYOIONI1/ltBGqqqcFAlzjrRYACgkQI1/ltBGq
qqcAjA//e30nrMgcjuYTZipx7Pb25l9/mASh6SM6RkiQ/qsh3YZV9LTfG+EPXvoJ
xx3wpdCqTnrCgV4h4jo91a1C7TaKAfaSNwmN9cw1N1A2qi/bMNA5B84mT6Mgc+hD
LQF1qkEecc6czCOnrqubvH1xY+ApZTmYwktjGPLinpJA/TFa9QYggoRvJE76XuHi
Vs99hYkCHHQQVPzKMnOkFhIRsuvGOy14K/L3UAWyCT41qfTIMN43O6eBXMr6e31Q
RLo3051KHVq4+Rsdszyg870435Anf+efve1ihs1DEMB9I1olxZLbiAtvjGIh+V21
XMbeRfSYeVQg4ANfB+aIPRwwOIc5a6uJzto5UmVVJw3TFLPVS9BUWfsRBCG9q2m8
h6y5L+9f5XDlmxXELBAg5kpOkk/BQYUBmvhFH7kiMNDusv7sVeMYHXETlk7p5+FL
r3KpX74f4UiyzwjvxqHsN4GLW9rXjywTnPxzKXHnhtb4AYIxwQPb5BTiWoWxc+Nn
wK4oQI3Jucxwrk9vidHNfB5lz4uyVGqs9cUN810ZoW3JzGJOsvdoYtu7UlF423yX
SWIMZWA9AgiNUYGzQRbep+YjSCRPIMKXK7KOQopOK+WBxmp2/0cmxB1GeMbT2DLv
urtj+KzuU6p2hNVc1MDfM1W6Q6rCBk/z77dZQ3S2GJ3dZ4TMQI8=
=IAUN
-----END PGP SIGNATURE-----

--Sig_/OliU07hw75zzQ=tC8_AG_Hi--