Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Anson Huang <anson.huang@nxp.com>
To:     "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        Leonard Crestez <leonard.crestez@nxp.com>,
        Abel Vesa <abel.vesa@nxp.com>,
        "viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     dl-linux-imx <linux-imx@nxp.com>
Subject: [PATCH 2/2] soc: imx: soc-imx8: Correct return value of error handle
Thread-Topic: [PATCH 2/2] soc: imx: soc-imx8: Correct return value of error
 handle
Thread-Index: AQHVD7YxLwkXfUp5nUSx1qNWKadvJQ==
Date:   Tue, 21 May 2019 09:18:46 +0000
Message-ID: <1558430013-18346-2-git-send-email-Anson.Huang@nxp.com>
References: <1558430013-18346-1-git-send-email-Anson.Huang@nxp.com>
In-Reply-To: <1558430013-18346-1-git-send-email-Anson.Huang@nxp.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [119.31.174.66]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 0b6409a7-796d-4d19-ba5d-08d6ddcd53ec
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020);SRVR:DB3PR0402MB3836;
x-ms-traffictypediagnostic: DB3PR0402MB3836:
x-microsoft-antispam-prvs: <DB3PR0402MB3836D7AFA6732262BD0F9A37F5070@DB3PR0402MB3836.eurprd04.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:826;
x-forefront-prvs: 0044C17179
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39860400002)(366004)(376002)(136003)(346002)(396003)(199004)(189003)(4326008)(486006)(256004)(14454004)(26005)(81156014)(8676002)(81166006)(8936002)(6486002)(2201001)(2501003)(6436002)(6512007)(7736002)(86362001)(53936002)(3846002)(36756003)(25786009)(6116002)(71200400001)(71190400001)(5660300002)(66066001)(64756008)(66446008)(102836004)(50226002)(52116002)(76176011)(99286004)(2616005)(66556008)(66476007)(73956011)(66946007)(186003)(476003)(386003)(6506007)(478600001)(2906002)(305945005)(316002)(68736007)(446003)(110136005)(11346002);DIR:OUT;SFP:1101;SCL:1;SRVR:DB3PR0402MB3836;H:DB3PR0402MB3916.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: Z9jKLa+tBdDHKIBB8k6M/mKoU2nwYeLtEBMk7oaxflRAOyhSODIYHDqjnfCvjDnH/EwFcuVzWuU7fUv6/Te4/8xFAJz8hTP9Lda2VS1QcZu/Q9DjnQ5HWfuHeXekWyVXal9i5vdl+ECbuENypGnlR4SfQBfyn8MBadLHLh0zUQG/xfzE33Au5jerrMx9x4jbB9kd8O8e/xo6Enq0kH/Ij+SnISCp/pFcomH016tm/hmUlbTOZOB8VNHb1mrwVxC7T7WFTtX7cJq5qpqY4BKloqmm+I12e1LCFKXEDgKdrr9ZjIkb2Ho3GvE9T5C78iV6Ga+SfVZ11xPZ4z89xCYXIbOqVWkIZlS4uUm6tvbbNL3BJP9qwjT1HPlvSHclDwc625f8OL65Fgr4T7Rnp4xVnNqHszwBXp7cCNAfjAlYxPw=
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <4B919C90F1B2E04AA40C3C8EF9061E36@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0b6409a7-796d-4d19-ba5d-08d6ddcd53ec
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 May 2019 09:18:46.8369
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0402MB3836
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Current implementation of i.MX8 SoC driver returns -ENODEV
for all cases of error during initialization, this is incorrect.
This patch fixes them using correct return value according
to different errors.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
 drivers/soc/imx/soc-imx8.c | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/drivers/soc/imx/soc-imx8.c b/drivers/soc/imx/soc-imx8.c
index 944add2..9dd088f 100644
--- a/drivers/soc/imx/soc-imx8.c
+++ b/drivers/soc/imx/soc-imx8.c
@@ -73,7 +73,7 @@ static int __init imx8_soc_init(void)
=20
 	soc_dev_attr =3D kzalloc(sizeof(*soc_dev_attr), GFP_KERNEL);
 	if (!soc_dev_attr)
-		return -ENODEV;
+		return -ENOMEM;
=20
 	soc_dev_attr->family =3D "Freescale i.MX";
=20
@@ -83,8 +83,10 @@ static int __init imx8_soc_init(void)
 		goto free_soc;
=20
 	id =3D of_match_node(imx8_soc_match, root);
-	if (!id)
+	if (!id) {
+		ret =3D -ENODEV;
 		goto free_soc;
+	}
=20
 	data =3D id->data;
 	if (data) {
@@ -94,12 +96,16 @@ static int __init imx8_soc_init(void)
 	}
=20
 	soc_dev_attr->revision =3D imx8_revision(soc_rev);
-	if (!soc_dev_attr->revision)
+	if (!soc_dev_attr->revision) {
+		ret =3D -ENOMEM;
 		goto free_soc;
+	}
=20
 	soc_dev =3D soc_device_register(soc_dev_attr);
-	if (IS_ERR(soc_dev))
+	if (IS_ERR(soc_dev)) {
+		ret =3D PTR_ERR(soc_dev);
 		goto free_rev;
+	}
=20
 	if (IS_ENABLED(CONFIG_ARM_IMX_CPUFREQ_DT))
 		platform_device_register_simple("imx-cpufreq-dt", -1, NULL, 0);
@@ -113,6 +119,6 @@ static int __init imx8_soc_init(void)
 free_soc:
 	kfree(soc_dev_attr);
 	of_node_put(root);
-	return -ENODEV;
+	return ret;
 }
 device_initcall(imx8_soc_init);
--=20
2.7.4