Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp783432ybm; Tue, 21 May 2019 03:32:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqyMX8bQeTaN3kdPTeZfC/VoS3NK7Iw/mxWyk0lGIu2unLenDFGHpnBT+tXpfjFDTmBMjFGj X-Received: by 2002:a62:5cc6:: with SMTP id q189mr55469592pfb.114.1558434770005; Tue, 21 May 2019 03:32:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558434769; cv=none; d=google.com; s=arc-20160816; b=PzrUu6LjfyQz/xvAnnAA3JpAY1J2Z3lpUsmPxjRMm3/4tu8Aq+/KjPK8keE1GDsN80 mSi9aiAN+KGCroRr5hJBC1b4DABogmUfUr/xEBVL/hDlB1ZaVF/hsu3MEUxgMRt1ckBZ dXWvngp9V1NxPHl729mpkzeFFwe71Y9scixsg3pOrJYvSgnvNVTOtuxOiaFXAENWfug8 334ZALJNtfW5Wm80A8TqsAEiTYy94llHgn2VPr//N9KbzO2y25tbdikrb3cGtCahUIHp n4nxG6fG5UYt6zEBcoFfV/kZkda6gJckJ4C7yGf5KRqB3bv7IGikdgg+/6f0GNhDSt9O OAYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=rTaanXi/wafbOkDEfxKYIXTHeXCeX6MHg+zozD6mk2o=; b=O0uHL3IX9I2786bO42t4bRamPnSVhtofmniKMMXfgtKAalYUgQsbS16yB+OIPaoec4 rnso2PmLDLX0EhTWh45xXzmAL/LReqeIaSoKfyTKtV51uYWLfv6DvPunI+dTQwqXdBED NRTeQvKaHAiw9WYpGTNq7pNbNKAbPkE32b+qZmBkCYZJVa6XGkp49W1SfEH5tzubcFLE ja7oavqO+6lsZArIs9yvGFAzOnsf1l1ySYUyIc55ukrAmbsK4XcN1s3Ao/DZs9+hil8b UCJsJdtTiKUbLAcy8N39+GM6V97WqukkjoJVGkij18asa6CoDRAXS5Rd8uRjUt/B3grc 665g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=1T3azC+0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q4si19834140pll.127.2019.05.21.03.32.34; Tue, 21 May 2019 03:32:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=1T3azC+0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727551AbfEUKbW (ORCPT + 99 others); Tue, 21 May 2019 06:31:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:47430 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726344AbfEUKbW (ORCPT ); Tue, 21 May 2019 06:31:22 -0400 Received: from localhost (unknown [49.207.56.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C20FE21743; Tue, 21 May 2019 10:31:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558434681; bh=mb4gcRCdlc4t1BxrH1KDO67uUQe97itsvMsgFVRR+oI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1T3azC+0XgH3xEp8zysLMOSu8S++YutNokP4axowBzBYutjJuCkzQ7/lP7XAaYOlW Snz0V6hyebzOKq70E2UHDr5QECQvx96Tszf1olmuzgFudaQ7kHEldkcMOj8WN96mF8 MlGCXvuGWzq8EJexNscqQiGDglTT3tQZ38Y/WuxQ= Date: Tue, 21 May 2019 16:01:17 +0530 From: Vinod Koul To: Jorge Ramirez-Ortiz Cc: agross@kernel.org, david.brown@linaro.org, gregkh@linuxfoundation.org, sboyd@kernel.org, bjorn.andersson@linaro.org, jslaby@suse.com, keescook@chromium.org, anton@enomsg.org, ccross@android.com, tony.luck@intel.com, linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] tty: serial: msm_serial: Fix XON/XOFF Message-ID: <20190521103117.GD15118@vkoul-mobl> References: <20190520183848.27719-1-jorge.ramirez-ortiz@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190520183848.27719-1-jorge.ramirez-ortiz@linaro.org> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20-05-19, 20:38, Jorge Ramirez-Ortiz wrote: > When the tty layer requests the uart to throttle, the current code > executing in msm_serial will trigger "Bad mode in Error Handler" and > generate an invalid stack frame in pstore before rebooting (that is if > pstore is indeed configured: otherwise the user shall just notice a > reboot with no further information dumped to the console). > > This patch replaces the PIO byte accessor with the word accessor > already used in PIO mode. > > Fixes: 68252424a7c7 ("tty: serial: msm: Support big-endian CPUs") > Cc: stable@vger.kernel.org > Signed-off-by: Jorge Ramirez-Ortiz > Reviewed-by: Bjorn Andersson Reviewed-by: Vinod Koul -- ~Vinod