Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751136AbVKNOzS (ORCPT ); Mon, 14 Nov 2005 09:55:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751140AbVKNOzS (ORCPT ); Mon, 14 Nov 2005 09:55:18 -0500 Received: from [194.90.237.34] ([194.90.237.34]:614 "EHLO mtlex01.yok.mtl.com") by vger.kernel.org with ESMTP id S1751136AbVKNOzQ (ORCPT ); Mon, 14 Nov 2005 09:55:16 -0500 Date: Mon, 14 Nov 2005 16:57:08 +0200 From: "Michael S. Tsirkin" To: Hugh Dickins Cc: Gleb Natapov , Benjamin Herrenschmidt , Petr Vandrovec , Nick Piggin , Badari Pulavarty , Linux Kernel Mailing List Subject: Re: Nick's core remove PageReserved broke vmware... Message-ID: <20051114145708.GU20871@mellanox.co.il> Reply-To: "Michael S. Tsirkin" References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1025 Lines: 30 Quoting r. Hugh Dickins : > Subject: Re: Nick's core remove PageReserved broke vmware... > > On Mon, 14 Nov 2005, Michael S. Tsirkin wrote: > > Quoting Gleb Natapov : > > > On Mon, Nov 14, 2005 at 02:25:35PM +0200, Michael S. Tsirkin wrote: > > > > > > > > There's one thing that I have thought about: what happens > > > > if I set DONTFORK on a page which already has COW set > > > > (e.g. after fork)? > > > > > > > > It seems that the right thing would be to force a page copy - > > > > otherwise the page can get copied on write. > > > Should we worry about this? > > About what? For pages which hardware will only read, not write, hardware driver does get_user_pages with write cleared. This means that COW may remain set. -- MST - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/