Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp972298ybm; Tue, 21 May 2019 06:47:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqwfxEbcgmeV0CIxgVZlbFXpWGxYg5OsWe3jogLktRT7GsZdeoe22TYqTRUeh57gt9ba5eJS X-Received: by 2002:a62:38d8:: with SMTP id f207mr27028111pfa.131.1558446428315; Tue, 21 May 2019 06:47:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558446428; cv=none; d=google.com; s=arc-20160816; b=lM4qsjlujDFFSGWbzK8Oz72zYU9WhqLcx4xcJxgzEuJMmKeF1dvX4kqPS8EZPIzKmL mhhzB/VGrqgkFAVs54mIRBDveYCQUh7dTS1ZVqnf/YMDq68hTdfZKUWc9rW62/tb4tRP Gbt+Uew1kW2IVxMtleX8bgU3mVZ+mF89x/cJbOc6XDyqLDhS8Fqk7yab4eYvumULW4gX DkYsKkQ6V/dn44Cn4/ORtVlKL+ZvsjOjZva2jvQhZ+yRG36iA7OToOUCNIUK1GJYCd4/ 8usAOhVKNbFrubiT0UjALMouXip1PWg2tkfKjYSer2tt2y+jiRwIKfImMCkLMisHrEBb WAqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=/QKFZ6Z/hhEXCEhSQ/gqwOFmi3s8JNdRmXl24kpgFqE=; b=Eq9Xh2KQYAVqtunRzEXYdTxs/4JbKMLatxlAZwaup4P/sQKWwtWLm91Nt3A5aaFWuY IstXGX+jimvOyK3hYKW/7KdEE4ecj13k4CObkLPp8zdZEaIaAlVqxI8JDO2/BnzBT6hf 1F4zHR0BQvlqgex+s2cuCLyHGnVtOVMEUfQpmnfN3rUE+iq9afQijNc0GeN2w6uSqdzI 5oz2MnWWItMXIOebOb0lUYB9aRMC7BEqt6X3wY0wTf2/hefHmWy1XjunDua6Hd/iGakK Jo6IqK72+mXM8IBWzmHr+TAB0C3mBwNgY2krcmtJj4WbcDkpyg4MfpLaZjw2/n8+FQRx 1aMw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o8si20783653pgc.137.2019.05.21.06.46.52; Tue, 21 May 2019 06:47:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728334AbfEUNpr (ORCPT + 99 others); Tue, 21 May 2019 09:45:47 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:47526 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727044AbfEUNpq (ORCPT ); Tue, 21 May 2019 09:45:46 -0400 Received: from laptop-1.home (unknown [IPv6:2a01:cb19:8ad6:900:42dd:dd1c:19ee:7c60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: aragua) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id DB0DE263B01; Tue, 21 May 2019 14:45:43 +0100 (BST) Message-ID: <2741579da03893d2d4e7ad7f5fc42a506a82f380.camel@collabora.com> Subject: Re: [alsa-devel] [PATCH v3 00/30] Update cros_ec_commands.h From: Fabien Lahoudere To: Gwendal Grignou , enric.balletbo@collabora.com, bleung@chromium.org, groeck@chromium.org, lee.jones@linaro.org, jic23@kernel.org, broonie@kernel.org, cychiang@chromium.org, tiwai@suse.com Cc: linux-iio@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Date: Tue, 21 May 2019 15:45:41 +0200 In-Reply-To: <20190509211353.213194-1-gwendal@chromium.org> References: <20190509211353.213194-1-gwendal@chromium.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.2 (3.30.2-2.fc29) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le jeudi 09 mai 2019 à 14:13 -0700, Gwendal Grignou a écrit : > The interface between CrosEC embedded controller and the host, > described by cros_ec_commands.h, as diverged from what the embedded > controller really support. > > The source of thruth is at > https://chromium.googlesource.com/chromiumos/platform/ec/+/master/include/ec_commands.h > > That include file is converted to remove ACPI and Embedded only code. Hi, I reviewed patches of the series and they looks good to me. Reviewed-by: Fabien Lahoudere