Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp990996ybm; Tue, 21 May 2019 07:04:39 -0700 (PDT) X-Google-Smtp-Source: APXvYqxsb49gP5TnQ+5Flk1X0+A5p0cSpl+RxLyXOUPxedOpuIB7iiRmdXdIAQhkruBft5LQosEr X-Received: by 2002:a17:902:704c:: with SMTP id h12mr27664619plt.65.1558447479230; Tue, 21 May 2019 07:04:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558447479; cv=none; d=google.com; s=arc-20160816; b=amGKcw846bp8ByzSQ2XTuEu/K8DYGUJCTTTVk6cFsU5Wdo3HnNEP67iiso0qqth6/0 Nsi1VaE+xjri+1kY5LKS/TpIJav0OUWpeq0xAcKrx8Q5oPlEOp2pIVCwpkwYlRisuFG4 aIh9X66CurBE27PBkZ5iyYoo4ZD16RQMkd295+FtdVLhVrKNOjy/h7jSzL9/vM74iYTS aGTmrBdDiyWBhauq477rdkLHMcOId+iOTjpppUKQwl+6w9Y6KThrowkJSOaRevIA4Hz9 i2+cUuCJmKT8qc/UxnL7mLSZd9FPohdk7MaOaXqFt4rmf6vdpdShb7kxxf29LmFVj2eB WKlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=MXUN613/zay3Y23TMe6PbNDpZpDcMQfr183j0LPhKBg=; b=tahiDdKjzx/yYG8RIZFcgfrogNc0I7JNO9Oe3IqpEoT6Fi/9wKA5UdBMykDQW8OH8a TIzXhq3iMhkT+Ft6xy2V0nudOVDG7sJX7nEMSp2zCPx7yX0km4pXCeQcPBVJlh66gePU III0FBEz5OcVlBAffshHIYdLxTX+/StDW16iIQvwhX4UfeY9+4IJtH19qsNxswSGVrOa oTzoH8A/9adH/D1XgaI8+5vfxsCuX5ntUixVEyrB/Q5zA9ExB5T9IQMZyltUGSh3xceI 9r6CkpzFumEouP+mx8X2g5864LxaYsD71yoOIw+U9766bASWo+4UKJtFKuw7Aknzc2/w gi1g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s8si21340056pgn.430.2019.05.21.07.04.22; Tue, 21 May 2019 07:04:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728523AbfEUOCK (ORCPT + 99 others); Tue, 21 May 2019 10:02:10 -0400 Received: from mail.us.es ([193.147.175.20]:53364 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727986AbfEUOCK (ORCPT ); Tue, 21 May 2019 10:02:10 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 89C1F103251 for ; Tue, 21 May 2019 16:02:06 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 78312DA71F for ; Tue, 21 May 2019 16:02:06 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 6C740DA713; Tue, 21 May 2019 16:02:06 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50, SMTPAUTH_US2,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 59D4CDA707; Tue, 21 May 2019 16:02:04 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Tue, 21 May 2019 16:02:04 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [31.4.195.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 208D24265A31; Tue, 21 May 2019 16:02:04 +0200 (CEST) Date: Tue, 21 May 2019 16:02:02 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Jagdish Motwani Cc: netdev@vger.kernel.org, Jagdish Motwani , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v3] netfilter: nf_queue:fix reinject verdict handling Message-ID: <20190521140202.yjqjygtw3l36pi6h@salvia> References: <20190513181740.5929-1-j.k.motwani@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190513181740.5929-1-j.k.motwani@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 13, 2019 at 11:47:40PM +0530, Jagdish Motwani wrote: > From: Jagdish Motwani > > This patch fixes netfilter hook traversal when there are more than 1 hooks > returning NF_QUEUE verdict. When the first queue reinjects the packet, > 'nf_reinject' starts traversing hooks with a proper hook_index. However, > if it again receives a NF_QUEUE verdict (by some other netfilter hook), it > queues the packet with a wrong hook_index. So, when the second queue > reinjects the packet, it re-executes hooks in between. Applied, thanks.