Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp1088339ybm; Tue, 21 May 2019 08:27:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqyb/kWeffND0lL0M0c48YzQgg3nx54zgVk6JrMTO+23SheG7Bqq3V4yRJ3h1O59cApWLlkL X-Received: by 2002:a17:902:8e8a:: with SMTP id bg10mr28813112plb.247.1558452457350; Tue, 21 May 2019 08:27:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558452457; cv=none; d=google.com; s=arc-20160816; b=ZgtroSSJKfpcsLLgy2XfRj8TyO3f7g9IwkcQTuaLxEMS32ui4dl424WfjAxZKOfIGW xHsCQD+A7A4rD18PHYyhknT/GcQTq6hfKIQjuMdRomc7nTKWXiFbZ7Z7VwVmUOVN29F5 cJz5mxhAsPZu8Z2/OM+YRojLvkg/YK7Hooqh6W7aCNv/B1ESk0CPhMm+mk77Yd/jHnqL hw1C1eoQ/jRMuCDZb97pYr/k07E8zI4o7KlHL+EVb1X5p3rFJMGc2omr7KHUprIr/0Tt g9w02Hm0aU0Eze5wPlj5pKLYKl8yfRmhzOVzvJrsMy7CqDc0cHDKSq/wjGcL/dE9B2Vc N+iQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=UMWfqlN2YiVoKAZO91st6BVGhLPMGLbKOwMtKk9gVW0=; b=svKuDlGmOT5RU37e29k3zqcc4VyzKL4gxmVRnbR6WQlHtkXHilQ4TjtVrGi3FHfNCX f/rcRfxjF8o73Fx61GQxVY3TxKJoS3eOLyGTGIHzc5G+ax9JGxEIJfuSECBhWE33+glG C66/nuuVWJjkLSLkp36Tkv63wltiKEsGdEtYIBvaiZtEA0gESxXoPum3By3rz7K9/R5e TnVsMHi/XJ1CiSHR/gcm0dCgRVKLynbS9r1S5twQMslPEvGtIITr+x3hMSRB7VpmJap5 bz3kGw4VDR3+Q+gesTOlhxDGswJmwwuWekSgEMEoC7LlPJ55hGkW+yrRcMfsrLb7yFmj yEyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=lkIWUKNO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b16si4638444pgk.387.2019.05.21.08.27.20; Tue, 21 May 2019 08:27:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=lkIWUKNO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728451AbfEUPYk (ORCPT + 99 others); Tue, 21 May 2019 11:24:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:38444 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727044AbfEUPYk (ORCPT ); Tue, 21 May 2019 11:24:40 -0400 Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1F43E217D7 for ; Tue, 21 May 2019 15:24:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558452279; bh=UMWfqlN2YiVoKAZO91st6BVGhLPMGLbKOwMtKk9gVW0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=lkIWUKNOOqae+PNKcqlj5A7XfX+R5WtRBHLluCTEAfb09PyNhuQ/Cv83PXE5KaJq5 lI/oLB59Z0OhiAI/Rj8Shsq/bETKDQKAKG71M50xbXDrAO9bWX30Zd+2m90x/NOfbb xffA37pE2DH3yAKZOsUa+sYMxAN+OTrH/gxttSk8= Received: by mail-qt1-f174.google.com with SMTP id i26so20898360qtr.10 for ; Tue, 21 May 2019 08:24:39 -0700 (PDT) X-Gm-Message-State: APjAAAX2I6IMw5/kmgMhzGYxliyz8YYRto1YxwQ6f4QCucI9oF9aM/sD TVcQg0m2O/hM5x/hL86KL/vf/9KrzJD0eXGpmg== X-Received: by 2002:ac8:2d48:: with SMTP id o8mr69172161qta.136.1558452278328; Tue, 21 May 2019 08:24:38 -0700 (PDT) MIME-Version: 1.0 References: <20190520092306.27633-1-steven.price@arm.com> <20190520092306.27633-3-steven.price@arm.com> In-Reply-To: <20190520092306.27633-3-steven.price@arm.com> From: Rob Herring Date: Tue, 21 May 2019 10:24:27 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 2/2] drm/panfrost: Use drm_gem_shmem_map_offset() To: Steven Price Cc: Daniel Vetter , Tomeu Vizoso , Alyssa Rosenzweig , Chris Wilson , David Airlie , Inki Dae , Joonyoung Shim , Krzysztof Kozlowski , Kukjin Kim , Kyungmin Park , Maarten Lankhorst , Maxime Ripard , Sean Paul , Seung-Woo Kim , dri-devel , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 20, 2019 at 4:23 AM Steven Price wrote: > You forgot to update the subject. I can fixup when applying, but I'd like an ack from Chris on patch 1. > panfrost_ioctl_mmap_bo() contains a reimplementation of > drm_gem_map_offset() but with a bug - it allows mapping imported objects > (without going through the exporter). Fix this by switching to use the > newly renamed drm_gem_map_offset() function instead which has the bonus > of simplifying the code. > > CC: Alyssa Rosenzweig > Signed-off-by: Steven Price > Reviewed-by: Alyssa Rosenzweig