Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp1269854ybm; Tue, 21 May 2019 11:14:19 -0700 (PDT) X-Google-Smtp-Source: APXvYqxVyFzBj6PRAiAq0GwAmcq4T9mf8y78PDcxkuKPXtprg8FDifktuCGWb43muoQArzz8BwVU X-Received: by 2002:a62:5306:: with SMTP id h6mr31581641pfb.29.1558462458928; Tue, 21 May 2019 11:14:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558462458; cv=none; d=google.com; s=arc-20160816; b=xSJhHSQSbgttIpplVHP1fxcgEws+LS7I2pcfDMGbaXJShbRsRdW1ZfTTSFPbRvciwS db1wmqtv5RlG11QT0arUpXN+YQu/IEuhXBEKFSbdZU4YZLwFw5l7G8U+Q7HXk9QWEjuI KrnTcgx2ajPgJdAH/P9K9Ows+Ew7cRi7E2AU2KL/G4tV7PkV8eDQPUAhjsdcqmyId24/ 4DV78gM0UoW1k54iPv605LrMT1mRUIpynL0bSHtXRbyLgm051ABRxyckq1HiBElRNHJD pM+O4dqzmyrXOUWVFw1TJakXOnOx/63B6tX6Q3Uj03QvQQQ7Eh/8kKyTsMqUXRgKAxok 8wUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=xYACohG+aL2YOEXiqpTf7UwGXqwtCxVW8xlbTuXDhzY=; b=KkIaq2dPQvwHTKOhIzZk2zBLjshOLa/TuSKu47eFjazipSviji/2sSjR4xqEiqKk0F 8oVCu1TXysZ0OZh9QJv90he8MnEFVcFV3BX/DzgrkL11DJ74YCW36IWoCajXWh/vdoq2 OgHwDAUwYrvNPx8YJsXoU09W3GmNBMGZN0WFx92/NcoT/iw+K8uTMUGzmwNQxKB6CQU+ N0K5N7zu16lXFwrXpNKXk8vHpTHJe9VHJjUVg4AbqrPN/1mRhDmGUSVkdYbhQsVLVEa3 y+MB2FyFzemui2tUFEkZ8ZVRalHcriIhg0ETanJ5JJh8Z6sVFVQvu7vsalMWezrkpIMV 5dPg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u6si16161109pgp.286.2019.05.21.11.14.03; Tue, 21 May 2019 11:14:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729216AbfEUSLa (ORCPT + 99 others); Tue, 21 May 2019 14:11:30 -0400 Received: from mail.us.es ([193.147.175.20]:49510 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728055AbfEUSLa (ORCPT ); Tue, 21 May 2019 14:11:30 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 03707EA460 for ; Tue, 21 May 2019 20:11:28 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id E4697DA709 for ; Tue, 21 May 2019 20:11:27 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id E3719DA703; Tue, 21 May 2019 20:11:27 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50, SMTPAUTH_US2,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id C9F37DA702; Tue, 21 May 2019 20:11:25 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Tue, 21 May 2019 20:11:25 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (sys.soleta.eu [212.170.55.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id A47C54265A32; Tue, 21 May 2019 20:11:25 +0200 (CEST) Date: Tue, 21 May 2019 20:11:25 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Jeffrin Jose T Cc: fw@strlen.de, shuah@kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org Subject: Re: [PATCH v2] selftests: netfilter: missing error check when setting up veth interface Message-ID: <20190521181125.anqj32v3gcwjxs3z@salvia> References: <20190515064405.3981-1-jeffrin@rajagiritech.edu.in> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190515064405.3981-1-jeffrin@rajagiritech.edu.in> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 15, 2019 at 12:14:04PM +0530, Jeffrin Jose T wrote: > A test for the basic NAT functionality uses ip command which > needs veth device.There is a condition where the kernel support > for veth is not compiled into the kernel and the test script > breaks.This patch contains code for reasonable error display > and correct code exit. Applied, thanks.