Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp1280393ybm; Tue, 21 May 2019 11:25:17 -0700 (PDT) X-Google-Smtp-Source: APXvYqwAANA9arzhrYKnc0MYfYma1dNRm3X+9q0zItxWlj7BMq1iz86KtpdQNoYVHHl59x4fIeF5 X-Received: by 2002:a63:f315:: with SMTP id l21mr84203039pgh.417.1558463117799; Tue, 21 May 2019 11:25:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558463117; cv=none; d=google.com; s=arc-20160816; b=S2v0G9qH2SWrTool1riRgyyT8rxG096RUWmPBebq64ntxIqlC6ZqDT7LmNrNyW8fqx xlSZ5Yn2LD5UszK2/1q9Gpt8dE6mHX0L+PZrKgH5zj9khVo3cRLlJ2OnErvHXaS8mTo7 ziEK4qDh8tMqsVWK5+gMk4BFDl9ONzWWae7TiDoKs7tfF55XFxgAiArk+7hDcsCMkfvJ PaaWmRzFZ+LMd6cYi7GN8I4LXLOkIel5EBbjppzLoDTtriNhkDiNjjTI4mSL+f5eu+7t /arpqESCq2Zdnujivku5TNDqYGZuKwW0GQvzD5Da21h8fdar6nyhS73oFxDSnecut6nS UDGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:subject:user-agent:message-id :references:cc:in-reply-to:from:to:content-transfer-encoding :mime-version; bh=zCV0u+SbeHsVpUprCrlENvslJFYkWAefFS8iaxdKwfg=; b=PxGt4reYfIM+nWgrqG7JzVd28tWd6quVOTGxskuPn3YiMwCKnWThodqjYBRrMk5Rfn Q2RstMmgUDLFjr9d5ZUOqmifquRd9Rl/siDmWaPL55fylOwHjAFFOGkBeRwL5xG2GRO8 8CxFuJzsXrMejbUE/HAfIR+cUe81Sx8UTWie0PiWUX1oEZwXoQJtbT82/FtNx6J5z0uL 8p3p11IOrFqDRJfZ/BQ9e2CHWWbA/1aJ1P9AzLrrgYe+a+Rq+CU9+GhIZ959zR893znG oiJFZO9hTWDWt6idqsM3ckwpn/A+8e+0NzfIL+c4PYLFE7Lk97BWK1NzpNDe2I3mqbXx Bs+g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q124si397932pgq.381.2019.05.21.11.25.01; Tue, 21 May 2019 11:25:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729269AbfEUSX5 convert rfc822-to-8bit (ORCPT + 99 others); Tue, 21 May 2019 14:23:57 -0400 Received: from mail.fireflyinternet.com ([109.228.58.192]:55916 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728457AbfEUSX5 (ORCPT ); Tue, 21 May 2019 14:23:57 -0400 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 16632229-1500050 for multiple; Tue, 21 May 2019 19:23:54 +0100 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: Rob Herring , Steven Price From: Chris Wilson In-Reply-To: Cc: Daniel Vetter , Tomeu Vizoso , Alyssa Rosenzweig , David Airlie , Inki Dae , Joonyoung Shim , Krzysztof Kozlowski , Kukjin Kim , Kyungmin Park , Maarten Lankhorst , Maxime Ripard , Sean Paul , Seung-Woo Kim , dri-devel , "linux-kernel@vger.kernel.org" References: <20190520092306.27633-1-steven.price@arm.com> <20190520092306.27633-3-steven.price@arm.com> Message-ID: <155846303227.23981.8007374203089408422@skylake-alporthouse-com> User-Agent: alot/0.6 Subject: Re: [PATCH v3 2/2] drm/panfrost: Use drm_gem_shmem_map_offset() Date: Tue, 21 May 2019 19:23:52 +0100 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Rob Herring (2019-05-21 16:24:27) > On Mon, May 20, 2019 at 4:23 AM Steven Price wrote: > > > > You forgot to update the subject. I can fixup when applying, but I'd > like an ack from Chris on patch 1. I still think it is incorrect as the limitation is purely an issue with the shmem backend and not a generic GEM limitation. It matters if you have a history of passing names and want a consistent api across objects when the apps themselves no longer can tell the difference, and certainly do not have access to the dmabuf fd. i915 provides an indirect mmap interface that uses the dma mapping regardless of source. -Chris