Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <CAMz4kuLjOjKGXn7QtOO5Gizo-FZ7CDf2SiczTNPwDgjAKzm2pw@mail.gmail.com>
References: <20190521060952.2949-1-zhang.chunyan@linaro.org> <20190521060952.2949-2-zhang.chunyan@linaro.org> <CAMz4kuLjOjKGXn7QtOO5Gizo-FZ7CDf2SiczTNPwDgjAKzm2pw@mail.gmail.com>
Subject: Re: [PATCH 1/2] clk: sprd: Switch from of_iomap() to devm_ioremap_resource()
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     linux-clk@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
        Orson Zhai <orsonzhai@gmail.com>,
        Chunyan Zhang <zhang.lyra@gmail.com>
To:     Baolin Wang <baolin.wang@linaro.org>,
        Chunyan Zhang <zhang.chunyan@linaro.org>
User-Agent: alot/0.8.1
Date:   Tue, 21 May 2019 11:57:13 -0700
Message-Id: <20190521185713.E24632173C@mail.kernel.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Baolin Wang (2019-05-20 23:38:03)
> On Tue, 21 May 2019 at 14:15, Chunyan Zhang <zhang.chunyan@linaro.org> wr=
ote:
> >                                                &sprdclk_regmap_config);
> > -               if (IS_ERR_OR_NULL(regmap)) {
> > +               if (IS_ERR(regmap)) {
>=20
> You did not mention this fix in your commit message, and it's better
> to move into one separate patch.
>=20

Please resend with it split out.