Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp172260ybm; Wed, 22 May 2019 00:58:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqyKDd0xzaaFwWWZYE2wM/HFPVZaCUdOS6FIrWqyFYLUOy5AerUyWjjvH39KQUZdkj6ZCPjG X-Received: by 2002:a63:d345:: with SMTP id u5mr83989039pgi.83.1558511881148; Wed, 22 May 2019 00:58:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558511881; cv=none; d=google.com; s=arc-20160816; b=u0og3wJPK/RFBYvJgak5Tq+5hbEs67BxgN18osGuzl+UKU+AtDipxUv60fd2etel8P HhT6LJLoGAuB3t5DddrZ5HsH7Siiyt7/xgccXxKdpmrODdoWiCe77E0fpsSxNrrDGqLx OoICy5FDzGztIIDjDGQPmYg7PoqSmh0P5sbU6pS4Xs5j+GWIRXQVa5YpcAnzAk6025NW qgQQIT9nw4Th1gtBXgr2MZRwxYOXRmNAIqpUiZ9T7u5BRopwD5wu3M0B72tvkJW64ggx 5eTG1NQ1G/+r1VkQqPv7fk94p53HyhYwjTTCbGEpOzlnC7G68Zvzd2r9YhRNHuKh7luR iyvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:ironport-sdr :dkim-signature; bh=cB9h70E216lfgUZds1+CtlQtJ9xh7ug1a2XfRijU1mk=; b=TUxeAU3vNSWQm6zJ4heGlpZd1tH+BjY/ALjrkz+1zId2q2Ma+qSC8f7MyTFCdxZCMG 8WSAEr0u1L6b/YIZ1U2qQ+0jb5ILU0ahzNHJL8GGuMQv+Lc2VhwqQ4/2EehMZ90qhXvg QfzNBybKChgHeofyc4wiF6Z4lfC9YUFRDr8fkseMQjs6swlpf8bOK43ld59pVCElb4k0 fzRmoE2e8cglcSI+xqjb2Ld/SKoWtEsXd3t80vGaerEzDv0V8StvHIKSHrl33uOfcR2k dAd3JwSSvZwHvXf9W1PvePMi5DIkz+koqLmIFZoX7oBPeJDkdC1w73FAhnw2pikGHDtw yEHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@skidata.com header.s=selector1 header.b=dhSvzPEN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r3si23336359plb.121.2019.05.22.00.57.45; Wed, 22 May 2019 00:58:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@skidata.com header.s=selector1 header.b=dhSvzPEN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728674AbfEVH4l (ORCPT + 99 others); Wed, 22 May 2019 03:56:41 -0400 Received: from mail2.skidata.com ([91.230.2.91]:60680 "EHLO mail2.skidata.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728159AbfEVH4k (ORCPT ); Wed, 22 May 2019 03:56:40 -0400 X-Greylist: delayed 429 seconds by postgrey-1.27 at vger.kernel.org; Wed, 22 May 2019 03:56:39 EDT DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=skidata.com; i=@skidata.com; q=dns/txt; s=selector1; t=1558511822; x=1590047822; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=LJnYEKn5WOXECQB3sJrCxae4KRfYfQTS/G+vasBSN0I=; b=dhSvzPENaIXPQ37kr5wOb5EcbT/sO8fSLvlTkzYG+s8gNEMhM6VfEVoi fsqe20QodQjryMPX/KVAk5+PgLfl4LQiYYhKwgR/RDnM0mUnQyhCwS3MA 7PaEL5Uy45uYwRZcLMQUNovVR7lqK6MJL4/+CK5kijP2UsMiSZWyCPmaQ f1Z+TSoLrOkqRbJqXBRpYAe/lXOIa8ojVx8q3U44/+fDISRnbxwoKJDSn L8L3fAOR4U6LWL3FSM9Wrg0LRiOy2nVXa9ow6/Zt8FiV12jdePdG8gTjf 26QV/T1gxOsRTCaq4lgoaTtzhn5sQph6f2Q36bu8UxEeH3ZTIcUzU57hi g==; IronPort-SDR: bHCkSqeNf+P5/1K1T9SeqcdO2jZ6RfDMFEkkWOvgFfGljXlAsK+mN7cPZD4UPrEWry9Y4CrCq7 3tHDsDTiMdjl+Z5GVlvF1QuaQPIxQtrePu4/DFbImMH9kOnaXY1lsM6lQKqGgmP7WjV+zbCvlQ oqim7Yp3D5rgQkHq+QwJfGyIX8PzPOs7lW1+LkA/ypuwEKe8WwyccERlirEDygjN73wm1Nacw5 yN17Dee6VRl5xOFVTagixJm998xZT8Qrp51Thvt6Q2LxB/plIa3THv3LCwDIGZZnfXUMKeVuUZ 4UE= X-IronPort-AV: E=Sophos;i="5.60,498,1549926000"; d="scan'208";a="2151447" Subject: Re: [PATCH 1/3] rtc: s35390a: clarify INT2 pin output modes To: Alexandre Belloni CC: , , References: <20190521142024.25894-1-richard.leitner@skidata.com> <20190521142024.25894-2-richard.leitner@skidata.com> <20190521155424.GH3274@piout.net> From: Richard Leitner Message-ID: <16bd943f-ccae-c3a5-59d3-b429c12c8155@skidata.com> Date: Wed, 22 May 2019 09:49:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190521155424.GH3274@piout.net> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.111.252] X-ClientProxiedBy: sdex4srv.skidata.net (192.168.111.82) To sdex5srv.skidata.net (192.168.111.83) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/05/2019 17:54, Alexandre Belloni wrote: > Hello, > > This seems good to me but... > > On 21/05/2019 16:20:22+0200, Richard Leitner wrote: >> --- a/drivers/rtc/rtc-s35390a.c >> +++ b/drivers/rtc/rtc-s35390a.c >> @@ -45,12 +45,13 @@ >> /* flag for STATUS2 */ >> #define S35390A_FLAG_TEST 0x01 >> >> -#define S35390A_INT2_MODE_MASK 0xF0 >> - >> +/* INT2 pin output mode */ >> +#define S35390A_INT2_MODE_MASK 0x0E >> #define S35390A_INT2_MODE_NOINTR 0x00 >> -#define S35390A_INT2_MODE_FREQ 0x10 >> -#define S35390A_INT2_MODE_ALARM 0x40 >> -#define S35390A_INT2_MODE_PMIN_EDG 0x20 >> +#define S35390A_INT2_MODE_ALARM 0x02 /* INT2AE */ >> +#define S35390A_INT2_MODE_PMIN_EDG 0x04 /* INT2ME */ >> +#define S35390A_INT2_MODE_FREQ 0x08 /* INT2FE */ >> +#define S35390A_INT2_MODE_PMIN 0x0C /* INT2ME | INT2FE */ >> > > While you are at it you may as well use BIT(). Sure, will change that for v2. regards;Richard.L