Received: by 2002:a25:86ce:0:0:0:0:0 with SMTP id y14csp195851ybm; Wed, 22 May 2019 01:24:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqxABYDUQrujbOaWjTOXjdw2LPzfnshKpcF6dKIi024P8M4aDUO+wP8Lu2dPMoe+MPa8fHQx X-Received: by 2002:a63:471d:: with SMTP id u29mr88021686pga.39.1558513455378; Wed, 22 May 2019 01:24:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558513455; cv=none; d=google.com; s=arc-20160816; b=li8U084v11M54XAE935So7p15PVYOJ7hl1EuubA3jqyWL21+CrtdktdkudwZiIlRmX T+Jjj0Gh+uB29HijcsID6ziIqHozkrBDjlyJU+45PnRsCBkV0FLWpDOnMifieffNYjrD cSbsDnS7cAZFKYmNEzEIx8c6v6Sh3wL04mmZeTbf6ppoXAJEbf6C585ruVPHM6DYj20o xNdncOFaZheCqhlIfyiL7ryoZIOdwTXbc2vH53uixPudLp1KaDmY8555cAr574cK3dmY yJdMaWd/cMahasxaWFNqdZC1+90eXBedWJb4EfAZURZ89FD0UzxmY+hrRbdiP7XfnfGa Bs/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=m4JEalCIglmSi8asd0GswElo01+07VAIE94yc//5CSY=; b=QScdFEU3vjjmT75hAVPfxdAiVAC9GAKP8yzPRi59VR5AHty39hUqDhIDGJH88V+9Bu Udktll7QRhS2OKrFw7tn7dicEXxpmL8suN/dBKIaq6EorBJXYXp2ikliYKPjowuM0GU4 1psrtexcAOuEsYxcNA0kHsnVyV857SYqXtQTBw2SelhdHFnEViuRYywxenCkWixdkQvi LIvltaSuCVxcDFJlU914eQJUUU8rOZXoDomw4DLPuM9NhGk8r/bDuXgFxW2/xFdTMnHb A+WnqTO0yDVq9adT5gWhAmYVUPaB7w8i6H42/4yvYqyGZ0XMZ8M686Klr4pGd7oQVUux 3HXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@brauner.io header.s=google header.b=KMEggWfK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r26si24485067pgb.32.2019.05.22.01.23.59; Wed, 22 May 2019 01:24:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@brauner.io header.s=google header.b=KMEggWfK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728602AbfEVIWx (ORCPT + 99 others); Wed, 22 May 2019 04:22:53 -0400 Received: from mail-lf1-f67.google.com ([209.85.167.67]:44121 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726514AbfEVIWx (ORCPT ); Wed, 22 May 2019 04:22:53 -0400 Received: by mail-lf1-f67.google.com with SMTP id n134so979000lfn.11 for ; Wed, 22 May 2019 01:22:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brauner.io; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=m4JEalCIglmSi8asd0GswElo01+07VAIE94yc//5CSY=; b=KMEggWfKkR3sBMob8FbBK3AkPY0Qn4wLBU1yAM0kOqN5gKbp7l4OR3rxcZCe1Ov1Ye uED7haoNqzLbV39Qaj2z/pOqC3lVob2FBEWPQyBmcQJX1WVPrnZqCGBi//2l7ms8rLXv +0+tBjPhna2s7pUUqEpZfT71jdxWJ8iPP3fJhloXDk+nX0Ufjanfb3bbxhnJW/jGf07H 3UWg0mYN+wHNOckgclt+Yj6aG3vssyp7F86XCh/IySq5+IYFBEJzZAQ6dVsQdei2r5EE mvEQPxdad4w3p93NQApykF9saCcvOzUKnpwqj3xC6v7ijNc3aJVs7zN9kuqnXuBzBxu1 y5yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=m4JEalCIglmSi8asd0GswElo01+07VAIE94yc//5CSY=; b=dQ+Sns7Mi6LdxSAfpIXHnV08WVBubYGYx1CXOBV4n9eCunewRw8WL4H/4SWlyniMW/ z6rgzFh8SFzICp4LIw2JlG/tx0YODdUjfcbJ9zIBuU5+FMoS7l1k+SArEXcLGa+H+4Og k9HJPMRPnlJM4vnPSuXqDKhvndk27hoiM0DfUBfI3Ir1iVs8VEVdVvYZ+XYGqaEd637e MsKWAEQ7w6qgkESL8oAGfRlKhrsxlJACoP0YF6B8KYZcyPbg9D1++iW6e+32OE3oa7gB 2i3BjNxlFk6SJZqLdy+F5l1KClslhZdDWUFe5zimeNmo5YhMqxYbNECcfbHjT8WBtPGE eEoA== X-Gm-Message-State: APjAAAWHt0P+4b+J7RicLecmp8OOwGJ8gmVAxuH9APO2XylGYHrC6T5f 5Ltw2R4VTxbPSQeKv15K4ZvB/owxafTzeWvPxR6XnA== X-Received: by 2002:ac2:5606:: with SMTP id v6mr5522539lfd.129.1558513370602; Wed, 22 May 2019 01:22:50 -0700 (PDT) MIME-Version: 1.0 References: <20190520035254.57579-1-minchan@kernel.org> <20190521084158.s5wwjgewexjzrsm6@brauner.io> <20190521110552.GG219653@google.com> <20190521113029.76iopljdicymghvq@brauner.io> <20190521113911.2rypoh7uniuri2bj@brauner.io> In-Reply-To: From: Christian Brauner Date: Wed, 22 May 2019 10:22:39 +0200 Message-ID: Subject: Re: [RFC 0/7] introduce memory hinting API for external process To: Daniel Colascione , Minchan Kim Cc: Andrew Morton , LKML , linux-mm , Michal Hocko , Johannes Weiner , Tim Murray , Joel Fernandes , Suren Baghdasaryan , Shakeel Butt , Sonny Rao , Brian Geffon , Jann Horn Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 22, 2019 at 7:12 AM Daniel Colascione wrote= : > > On Tue, May 21, 2019 at 4:39 AM Christian Brauner = wrote: > > > > On Tue, May 21, 2019 at 01:30:29PM +0200, Christian Brauner wrote: > > > On Tue, May 21, 2019 at 08:05:52PM +0900, Minchan Kim wrote: > > > > On Tue, May 21, 2019 at 10:42:00AM +0200, Christian Brauner wrote: > > > > > On Mon, May 20, 2019 at 12:52:47PM +0900, Minchan Kim wrote: > > > > > > - Background > > > > > > > > > > > > The Android terminology used for forking a new process and star= ting an app > > > > > > from scratch is a cold start, while resuming an existing app is= a hot start. > > > > > > While we continually try to improve the performance of cold sta= rts, hot > > > > > > starts will always be significantly less power hungry as well a= s faster so > > > > > > we are trying to make hot start more likely than cold start. > > > > > > > > > > > > To increase hot start, Android userspace manages the order that= apps should > > > > > > be killed in a process called ActivityManagerService. ActivityM= anagerService > > > > > > tracks every Android app or service that the user could be inte= racting with > > > > > > at any time and translates that into a ranked list for lmkd(low= memory > > > > > > killer daemon). They are likely to be killed by lmkd if the sys= tem has to > > > > > > reclaim memory. In that sense they are similar to entries in an= y other cache. > > > > > > Those apps are kept alive for opportunistic performance improve= ments but > > > > > > those performance improvements will vary based on the memory re= quirements of > > > > > > individual workloads. > > > > > > > > > > > > - Problem > > > > > > > > > > > > Naturally, cached apps were dominant consumers of memory on the= system. > > > > > > However, they were not significant consumers of swap even thoug= h they are > > > > > > good candidate for swap. Under investigation, swapping out only= begins > > > > > > once the low zone watermark is hit and kswapd wakes up, but the= overall > > > > > > allocation rate in the system might trip lmkd thresholds and ca= use a cached > > > > > > process to be killed(we measured performance swapping out vs. z= apping the > > > > > > memory by killing a process. Unsurprisingly, zapping is 10x tim= es faster > > > > > > even though we use zram which is much faster than real storage)= so kill > > > > > > from lmkd will often satisfy the high zone watermark, resulting= in very > > > > > > few pages actually being moved to swap. > > > > > > > > > > > > - Approach > > > > > > > > > > > > The approach we chose was to use a new interface to allow users= pace to > > > > > > proactively reclaim entire processes by leveraging platform inf= ormation. > > > > > > This allowed us to bypass the inaccuracy of the kernel=E2=80=99= s LRUs for pages > > > > > > that are known to be cold from userspace and to avoid races wit= h lmkd > > > > > > by reclaiming apps as soon as they entered the cached state. Ad= ditionally, > > > > > > it could provide many chances for platform to use much informat= ion to > > > > > > optimize memory efficiency. > > > > > > > > > > > > IMHO we should spell it out that this patchset complements MADV= _WONTNEED > > > > > > and MADV_FREE by adding non-destructive ways to gain some free = memory > > > > > > space. MADV_COLD is similar to MADV_WONTNEED in a way that it h= ints the > > > > > > kernel that memory region is not currently needed and should be= reclaimed > > > > > > immediately; MADV_COOL is similar to MADV_FREE in a way that it= hints the > > > > > > kernel that memory region is not currently needed and should be= reclaimed > > > > > > when memory pressure rises. > > > > > > > > > > > > To achieve the goal, the patchset introduce two new options for= madvise. > > > > > > One is MADV_COOL which will deactive activated pages and the ot= her is > > > > > > MADV_COLD which will reclaim private pages instantly. These new= options > > > > > > complement MADV_DONTNEED and MADV_FREE by adding non-destructiv= e ways to > > > > > > gain some free memory space. MADV_COLD is similar to MADV_DONTN= EED in a way > > > > > > that it hints the kernel that memory region is not currently ne= eded and > > > > > > should be reclaimed immediately; MADV_COOL is similar to MADV_F= REE in a way > > > > > > that it hints the kernel that memory region is not currently ne= eded and > > > > > > should be reclaimed when memory pressure rises. > > > > > > > > > > > > This approach is similar in spirit to madvise(MADV_WONTNEED), b= ut the > > > > > > information required to make the reclaim decision is not known = to the app. > > > > > > Instead, it is known to a centralized userspace daemon, and tha= t daemon > > > > > > must be able to initiate reclaim on its own without any app inv= olvement. > > > > > > To solve the concern, this patch introduces new syscall - > > > > > > > > > > > > struct pr_madvise_param { > > > > > > int size; > > > > > > const struct iovec *vec; > > > > > > } > > > > > > > > > > > > int process_madvise(int pidfd, ssize_t nr_elem, int *be= havior, > > > > > > struct pr_madvise_param *restul= s, > > > > > > struct pr_madvise_param *ranges= , > > > > > > unsigned long flags); > > > > > > > > > > > > The syscall get pidfd to give hints to external process and pro= vides > > > > > > pair of result/ranges vector arguments so that it could give se= veral > > > > > > hints to each address range all at once. > > > > > > > > > > > > I guess others have different ideas about the naming of syscall= and options > > > > > > so feel free to suggest better naming. > > > > > > > > > > Yes, all new syscalls making use of pidfds should be named > > > > > pidfd_. So please make this pidfd_madvise. > > > > > > > > I don't have any particular preference but just wondering why pidfd= is > > > > so special to have it as prefix of system call name. > > > > > > It's a whole new API to address processes. We already have > > > clone(CLONE_PIDFD) and pidfd_send_signal() as you have seen since you > > > exported pidfd_to_pid(). And we're going to have pidfd_open(). Your > > > syscall works only with pidfds so it's tied to this api as well so it > > > should follow the naming scheme. This also makes life easier for > > > userspace and is consistent. > > > > This is at least my reasoning. I'm not going to make this a whole big > > pedantic argument. If people have really strong feelings about not usin= g > > this prefix then fine. But if syscalls can be grouped together and have > > consistent naming this is always a big plus. > > My hope has been that pidfd use becomes normalized enough that > prefixing "pidfd_" to pidfd-accepting system calls becomes redundant. > We write write(), not fd_write(), right? :-) pidfd_open() makes sense > because the primary purpose of this system call is to operate on a > pidfd, but I think process_madvise() is fine. This madvise syscall just operates on pidfds. It would make sense to name it process_madvise() if were to operate both on pid_t and int pidfd. Giving specific names to system calls won't stop it from becoming normalized. The fact that people built other system calls around it is enough proof of that. :) For userspace pidfd_madvise is nicer and it clearly expresses that it only accepts pidfds. So please, Minchan make it pidfd_madvise() in the next version. :) Christian